perf(mutator): optimize result API and benchmark allocations

rian-be · rian-be · commit 21278630779e · 2026-07-28T02:23:08.000+02:00
diff --git a/Benchmarks/Governance/Materialization/GovernanceMaterializationOutputBenchmarks.cs b/Benchmarks/Governance/Materialization/GovernanceMaterializationOutputBenchmarks.cs
@@ -37,7 +37,7 @@ public MutationHistoryEntry HistoryEntry_FromGovernedExecution()
             StateId = _fixture.Result.Request.StateId,
             Intent = _fixture.Mutation.Intent,
             Context = _fixture.Mutation.Context,
-            Changes = _fixture.Result.MutationResult!.Changes,
+            Changes = _fixture.Result.MutationResult!.Value.Changes,
             SideEffects = _fixture.Result.Request.SideEffects.ToList(),
             Timestamp = _fixture.Result.Request.Versioning.ExecutedAt ?? DateTimeOffset.UtcNow,
             ExecutionTime = TimeSpan.FromMilliseconds(2)
@@ -50,17 +50,18 @@ public MutationHistoryEntry HistoryEntry_FromGovernedExecution()
     [Benchmark]
     public MutationAuditEntry AuditEntry_FromGovernedExecution()
     {
+        var mr = _fixture.Result.MutationResult!.Value;
         return new MutationAuditEntry
         {
             ExecutionId = _fixture.Result.Request.RequestId,
             StateId = _fixture.Result.Request.StateId,
             StateType = _fixture.Result.Request.StateType,
             MutationIntent = _fixture.Mutation.Intent,
             Context = _fixture.Mutation.Context,
-            Changes = _fixture.Result.MutationResult!.Changes,
-            IsSuccess = _fixture.Result.MutationResult.IsSuccess,
+            Changes = mr.Changes,
+            IsSuccess = mr.IsSuccess,
             ErrorMessage = null,
-            PolicyDecisions = _fixture.Result.MutationResult.PolicyDecisions,
+            PolicyDecisions = mr.PolicyDecisions,
             SideEffects = _fixture.Result.Request.SideEffects.ToList(),
             Timestamp = _fixture.Result.Request.Versioning.ExecutedAt ?? DateTimeOffset.UtcNow,
             Duration = TimeSpan.FromMilliseconds(2),
diff --git a/Benchmarks/Results/MutationOutputMaterializationBenchmarks.cs b/Benchmarks/Results/MutationOutputMaterializationBenchmarks.cs
@@ -1,70 +1,71 @@
 using BenchmarkDotNet.Attributes;
 using ModularityKit.Mutator.Abstractions.Audit;
+using ModularityKit.Mutator.Abstractions.Context;
+using ModularityKit.Mutator.Abstractions.Effects;
 using ModularityKit.Mutator.Abstractions.History;
+using ModularityKit.Mutator.Abstractions.Intent;
 using ModularityKit.Mutator.Abstractions.Results;
 using ModularityKit.Mutator.Benchmarks.Results.Support;
 
 namespace ModularityKit.Mutator.Benchmarks.Results;
 
-/// <summary>
-/// Benchmarks materialization of history and audit output from an executed mutation result.
-/// </summary>
 [BenchmarkCategory("Results")]
 [MemoryDiagnoser]
 [InProcess]
 public class MutationOutputMaterializationBenchmarks
 {
-    private MutationResult<ResultsBenchmarkSupport.ResultBenchmarkState> _result = null!;
+    private MutationResult<ResultsBenchmarkSupport.ResultBenchmarkState> _result = default!;
     private string _executionId = string.Empty;
     private TimeSpan _duration;
+    private IReadOnlyList<SideEffect> _sideEffectList = null!;
+    private MutationIntent _historyIntent = null!;
+    private MutationIntent _auditIntent = null!;
+    private MutationContext _historyContext = null!;
+    private MutationContext _auditContext = null!;
 
-    /// <summary>
-    /// Prepares a representative executed mutation result for output materialization benchmarks.
-    /// </summary>
     [GlobalSetup]
     public void Setup()
     {
         _result = ResultsBenchmarkSupport.CreateExecutedResult(sideEffectCount: 3, changeCount: 4);
         _executionId = "results-benchmark-execution";
         _duration = TimeSpan.FromMilliseconds(2);
+        _sideEffectList = _result.SideEffects.ToList();
+        _historyIntent = ResultsBenchmarkSupport.CreateIntent(
+            "ResultHistoryMaterialization",
+            "Materialize history output for benchmark results.");
+        _auditIntent = ResultsBenchmarkSupport.CreateIntent(
+            "ResultAuditMaterialization",
+            "Materialize audit output for benchmark results.");
+        _historyContext = ResultsBenchmarkSupport.CreateContext("history");
+        _auditContext = ResultsBenchmarkSupport.CreateContext("audit");
     }
 
-    /// <summary>
-    /// Measures materialization of the mutation history entry, including change and side effect copying.
-    /// </summary>
     [Benchmark(Baseline = true)]
     public MutationHistoryEntry HistoryEntry_Materialization()
     {
         return new MutationHistoryEntry
         {
             ExecutionId = _executionId,
             StateId = ResultsBenchmarkSupport.StateId,
-            Intent = ResultsBenchmarkSupport.CreateIntent(
-                "ResultHistoryMaterialization",
-                "Materialize history output for benchmark results."),
-            Context = ResultsBenchmarkSupport.CreateContext("history"),
+            Intent = _historyIntent,
+            Context = _historyContext,
             Changes = _result.Changes,
-            SideEffects = _result.SideEffects.ToList(),
+            SideEffects = _sideEffectList,
             Timestamp = DateTimeOffset.UtcNow,
             ExecutionTime = _duration
         };
     }
 
-    /// <summary>
-    /// Measures materialization of the audit entry produced from the same executed mutation result.
-    /// </summary>
     [Benchmark]
     public MutationAuditEntry AuditEntry_Materialization()
     {
         return new MutationAuditEntry
         {
             ExecutionId = _executionId,
             StateId = ResultsBenchmarkSupport.StateId,
-            StateType = nameof(ResultsBenchmarkSupport.ResultBenchmarkState),
-            MutationIntent = ResultsBenchmarkSupport.CreateIntent(
-                "ResultAuditMaterialization",
-                "Materialize audit output for benchmark results."),
-            Context = ResultsBenchmarkSupport.CreateContext("audit"),
+            StateType = "ResultBenchmarkState",
+            MutationIntent = _auditIntent,
+            Context = _auditContext,
             Changes = _result.Changes,
             IsSuccess = _result.IsSuccess,
             ErrorMessage = null,
diff --git a/Benchmarks/Results/MutationResultCreationBenchmarks.cs b/Benchmarks/Results/MutationResultCreationBenchmarks.cs
@@ -14,17 +14,21 @@ namespace ModularityKit.Mutator.Benchmarks.Results;
 [InProcess]
 public class MutationResultCreationBenchmarks
 {
-    private ResultsBenchmarkSupport.ResultBenchmarkState _state = null!;
+    private ResultsBenchmarkSupport.ResultBenchmarkState _state = default!;
     private ChangeSet _changes = null!;
+    private IReadOnlyList<SideEffect> _singleSideEffect = null!;
+    private IReadOnlyList<SideEffect> _multipleSideEffects = null!;
 
     /// <summary>
-    /// Prepares the shared state and change set used by the result creation cases.
+    /// Prepares the shared state, change set, and side effect lists used by the result creation cases.
     /// </summary>
     [GlobalSetup]
     public void Setup()
     {
         _state = new ResultsBenchmarkSupport.ResultBenchmarkState(0, 42);
         _changes = ResultsBenchmarkSupport.CreateChangeSet(_state.Revision, 2);
+        _singleSideEffect = ResultsBenchmarkSupport.CreateSideEffects(1);
+        _multipleSideEffects = ResultsBenchmarkSupport.CreateSideEffects(4);
     }
 
     /// <summary>
@@ -45,22 +49,14 @@ _state with
     /// </summary>
     [Benchmark]
     public MutationResult<ResultsBenchmarkSupport.ResultBenchmarkState> Success_SingleSideEffect()
-    {
-        var sideEffect = SideEffect.Create(
-            "ResultMaterialization",
-            "Single side effect",
-            new ResultsBenchmarkSupport.SideEffectPayload(1, "single"),
-            SideEffectSeverity.Info);
-
-        return MutationResult<ResultsBenchmarkSupport.ResultBenchmarkState>.Success(
+        => MutationResult<ResultsBenchmarkSupport.ResultBenchmarkState>.Success(
             _state with
             {
                 Revision = _state.Revision + 1,
                 Value = _state.Value + 1
             },
             _changes,
-            [sideEffect]);
-    }
+            _singleSideEffect);
 
     /// <summary>
     /// Measures creation of a successful mutation result with several side effects.
@@ -74,5 +70,5 @@ _state with
                 Value = _state.Value + 1
             },
             _changes,
-            ResultsBenchmarkSupport.CreateSideEffects(4));
+            _multipleSideEffects);
 }
diff --git a/Benchmarks/Results/Support/ResultsBenchmarkSupport.cs b/Benchmarks/Results/Support/ResultsBenchmarkSupport.cs
@@ -119,12 +119,12 @@ public static MutationResult<ResultBenchmarkState> CreateExecutedResult(
     /// </summary>
     /// <param name="Revision">The revision counter advanced on each benchmark mutation.</param>
     /// <param name="Value">The mutable numeric value exercised by the benchmark mutation.</param>
-    public sealed record ResultBenchmarkState(int Revision, int Value);
+    public readonly record struct ResultBenchmarkState(int Revision, int Value);
 
     /// <summary>
     /// Typed payload used to give side effects realistic materialization shape.
     /// </summary>
     /// <param name="Index">The ordinal of the side effect.</param>
     /// <param name="Token">A stable payload token.</param>
-    public sealed record SideEffectPayload(int Index, string Token);
+    public readonly record struct SideEffectPayload(int Index, string Token);
 }
diff --git a/Tests/ModularityKit.Mutator.Governance.Tests/Execution/GovernanceExecutionManagerCompensationTests.cs b/Tests/ModularityKit.Mutator.Governance.Tests/Execution/GovernanceExecutionManagerCompensationTests.cs
@@ -73,7 +73,7 @@ public async Task ExecuteApproved_executes_operator_rollback_compensation_and_li
         var compensationResult = await executionManager.ExecuteApproved(
             compensationRequest.RequestId,
             compensationMutation,
-            originalResult.MutationResult!.NewState!,
+            originalResult.MutationResult!.Value.NewState!,
             governanceContext: MutationContext.Service("governance-runtime", "Execute operator rollback"),
             strategy: VersionedRequestResolutionStrategy.RejectStale);
 
