Skip to content

Cache miss on maven metadata with matching hashes #32

Description

@PaintNinja

The hash checks for the maven-metadata.xml appears to be broken, as the server returns a string with a trailing \n while Mavenizer expects a string without one, causing the cache to always miss:

Image
> Configure project :
Minecraft Mavenizer 0.5.19 by Forge Development LLC
  Output:             C:\Users\oscar\Documents\Projects\FG7cleandev\.gradle\mavenizer\repo
  Output JSON:        C:\Users\oscar\Documents\Projects\FG7cleandev\.gradle\mavenizer\dependencies\default.json
  Dependencies Only:  false
  Cache:              C:\Users\oscar\.gradle\caches\minecraftforge\forgegradle\mavenizer\caches
  JDK Cache:          C:\Users\oscar\.gradle\caches\minecraftforge\forgegradle\mavenizer\caches
  Offline:            false
  Cache Only:         false
  Ignore Cache:       false
  Mappings:           auto
  Foreign Repos:      [https://repo.maven.apache.org/maven2/, https://maven.minecraftforge.net/, file:/C:/Users/oscar/.m2/repository/, https://libraries.minecraft.net/]
  GradleVariantHack:  true
  Disable Gradle:     false
  Stub Jars:          false

Processing Minecraft dependency: net.minecraft:client:26.2
Cache miss!
java.lang.Exception: Cache miss! Stacktrace for Information Only
	at net.minecraftforge.mcmaven.impl.Mavenizer.assertNotCacheOnly(Mavenizer.java:60)
	at net.minecraftforge.mcmaven.impl.cache.MavenCache.download(MavenCache.java:267)
	at net.minecraftforge.mcmaven.impl.cache.MavenCache.downloadMeta(MavenCache.java:129)
	at net.minecraftforge.mcmaven.impl.cache.MavenCache.getVersions(MavenCache.java:296)
	at net.minecraftforge.mcmaven.impl.MinecraftMaven.createMinecraft(MinecraftMaven.java:257)
	at net.minecraftforge.mcmaven.impl.MinecraftMaven.run(MinecraftMaven.java:121)
	at net.minecraftforge.mcmaven.cli.MavenTask.run(MavenTask.java:218)
	at net.minecraftforge.mcmaven.cli.Main.run(Main.java:70)
	at net.minecraftforge.mcmaven.cli.Main.main(Main.java:23)
Outdated cached file: C:\Users\oscar\.gradle\caches\minecraftforge\forgegradle\mavenizer\caches\maven\forge\de\oceanlabs\mcp\mcp\maven-metadata.xml
Expected: ce783ed28e83ef26f331c0499ef0cfef776d202e

Actual:   ce783ed28e83ef26f331c0499ef0cfef776d202e
Using Mappings: official-26.2
Sources
  downloadLauncherManifest
  downloadVersionJson[26.2]
  download[26.2][client]
  strip
  listLibraries
  decompile
  patch
  srg2names[official-26.2][Empty]
  remap[client][official-26.2][javadoc]
  remap[client][official-26.2][javadoc][variants]
Classes
  extra[client]
  recompile[client][official-26.2]
  mergeExtra[client][official-26.2]
  mergeExtra[client][official-26.2][variants]
Metadata
  metadata[client]
  metadata[client][variants]
Maven POM
  pom[26.2][client]
Mappings POM
  pom[mappings_official]
Minecraft Maven has finished, took 0:00.927

Adding an rhash = rhash.stripTrailing() may suffice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions