Skip to content

Commit 860f3a7

Browse files
committed
refactor(compiler): remove unused code and exports
Removes unused code and exports that are no longer referenced anywhere in the compiler codebase.
1 parent 1b13db7 commit 860f3a7

18 files changed

Lines changed: 22 additions & 61 deletions

File tree

packages/compiler/src/constant_pool.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ class FixupExpression extends o.Expression {
7979
export class ConstantPool {
8080
statements: o.Statement[] = [];
8181
private literals = new Map<string, FixupExpression>();
82-
private literalFactories = new Map<string, o.Expression>();
8382
private sharedConstants = new Map<string, o.Expression>();
8483

8584
/**
@@ -90,8 +89,6 @@ export class ConstantPool {
9089
*/
9190
private _claimedNames = new Map<string, number>();
9291

93-
private nextNameIndex = 0;
94-
9592
constructor(private readonly isClosureCompilerEnabled: boolean = false) {}
9693

9794
getConstLiteral(literal: o.Expression, forceShared?: boolean): o.Expression {

packages/compiler/src/output/map_util.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ export type MapEntry = {
1616

1717
export type MapLiteral = MapEntry[];
1818

19-
export function mapEntry(key: string, value: o.Expression): MapEntry {
20-
return {key, value, quoted: false};
21-
}
22-
2319
export function mapLiteral(
2420
obj: {[key: string]: o.Expression},
2521
quoted: boolean = false,

packages/compiler/src/render3/partial/component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export function compileDeclareComponentFromMetadata(
7979
/**
8080
* Gathers the declaration fields for a component into a `DefinitionMap`.
8181
*/
82-
export function createComponentDefinitionMap(
82+
function createComponentDefinitionMap(
8383
meta: R3ComponentMetadata<R3TemplateDependencyMetadata>,
8484
template: ParsedTemplate,
8585
templateInfo: DeclareComponentTemplateInfo,

packages/compiler/src/render3/partial/injectable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export function compileDeclareInjectableFromMetadata(
4040
/**
4141
* Gathers the declaration fields for a Injectable into a `DefinitionMap`.
4242
*/
43-
export function createInjectableDefinitionMap(
43+
function createInjectableDefinitionMap(
4444
meta: R3InjectableMetadata,
4545
): DefinitionMap<R3DeclareInjectableMetadata> {
4646
const definitionMap = new DefinitionMap<R3DeclareInjectableMetadata>();

packages/compiler/src/render3/partial/pipe.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ export function compileDeclarePipeFromMetadata(meta: R3PipeMetadata): R3Compiled
3737
/**
3838
* Gathers the declaration fields for a Pipe into a `DefinitionMap`.
3939
*/
40-
export function createPipeDefinitionMap(
41-
meta: R3PipeMetadata,
42-
): DefinitionMap<R3DeclarePipeMetadata> {
40+
function createPipeDefinitionMap(meta: R3PipeMetadata): DefinitionMap<R3DeclarePipeMetadata> {
4341
const definitionMap = new DefinitionMap<R3DeclarePipeMetadata>();
4442

4543
definitionMap.set('minVersion', o.literal(MINIMUM_PARTIAL_LINKER_VERSION));

packages/compiler/src/render3/partial/service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function compileDeclareServiceFromMetadata(meta: R3ServiceMetadata): R3Co
3737
/**
3838
* Gathers the declaration fields for a Service into a `DefinitionMap`.
3939
*/
40-
export function createServiceDefinitionMap(
40+
function createServiceDefinitionMap(
4141
meta: R3ServiceMetadata,
4242
): DefinitionMap<R3DeclareServiceMetadata> {
4343
const definitionMap = new DefinitionMap<R3DeclareServiceMetadata>();

packages/compiler/src/render3/r3_factory.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -316,16 +316,12 @@ function createCtorDepType(dep: R3DependencyMetadata): o.LiteralMapExpr | null {
316316
return entries.length > 0 ? o.literalMap(entries) : null;
317317
}
318318

319-
export function isDelegatedFactoryMetadata(
320-
meta: R3FactoryMetadata,
321-
): meta is R3DelegatedFnOrClassMetadata {
322-
return (meta as R3DelegatedFnOrClassMetadata).delegateType !== undefined;
319+
function isDelegatedFactoryMetadata(meta: R3FactoryMetadata): meta is R3DelegatedFnOrClassMetadata {
320+
return (meta as any).delegateType !== undefined;
323321
}
324322

325-
export function isExpressionFactoryMetadata(
326-
meta: R3FactoryMetadata,
327-
): meta is R3ExpressionFactoryMetadata {
328-
return (meta as R3ExpressionFactoryMetadata).expression !== undefined;
323+
function isExpressionFactoryMetadata(meta: R3FactoryMetadata): meta is R3ExpressionFactoryMetadata {
324+
return (meta as any).expression !== undefined;
329325
}
330326

331327
function getInjectFn(target: FactoryTarget): o.ExternalReference {

packages/compiler/src/render3/util.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,24 +45,11 @@ export interface R3CompiledExpression {
4545
statements: o.Statement[];
4646
}
4747

48-
const LEGACY_ANIMATE_SYMBOL_PREFIX = '@';
49-
export function prepareSyntheticPropertyName(name: string) {
50-
return `${LEGACY_ANIMATE_SYMBOL_PREFIX}${name}`;
51-
}
52-
53-
export function prepareSyntheticListenerName(name: string, phase: string) {
54-
return `${LEGACY_ANIMATE_SYMBOL_PREFIX}${name}.${phase}`;
55-
}
56-
5748
export function getSafePropertyAccessString(accessor: string, name: string): string {
5849
const escapedName = escapeIdentifier(name, false);
5950
return escapedName !== name ? `${accessor}[${escapedName}]` : `${accessor}.${name}`;
6051
}
6152

62-
export function prepareSyntheticListenerFunctionName(name: string, phase: string) {
63-
return `animation_${name}_${phase}`;
64-
}
65-
6653
export function jitOnlyGuardedExpression(expr: o.Expression): o.Expression {
6754
return guardedExpression('ngJitMode', expr);
6855
}
@@ -71,7 +58,7 @@ export function devOnlyGuardedExpression(expr: o.Expression): o.Expression {
7158
return guardedExpression('ngDevMode', expr);
7259
}
7360

74-
export function guardedExpression(guard: string, expr: o.Expression): o.Expression {
61+
function guardedExpression(guard: string, expr: o.Expression): o.Expression {
7562
const guardExpr = new o.ExternalExpr({name: guard, moduleName: null});
7663
const guardNotDefined = new o.BinaryOperatorExpr(
7764
o.BinaryOperator.Identical,

packages/compiler/src/render3/view/query_generation.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,7 @@ function toQueryFlags(query: R3QueryMetadata): number {
6464
);
6565
}
6666

67-
export function getQueryPredicate(
68-
query: R3QueryMetadata,
69-
constantPool: ConstantPool,
70-
): o.Expression {
67+
function getQueryPredicate(query: R3QueryMetadata, constantPool: ConstantPool): o.Expression {
7168
if (Array.isArray(query.predicate)) {
7269
let predicate: o.Expression[] = [];
7370
query.predicate.forEach((selector: string): void => {

packages/compiler/src/render3/view/util.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,6 @@ export function temporaryAllocator(
4444
};
4545
}
4646

47-
export function invalid<T>(this: t.Visitor, arg: o.Expression | o.Statement | t.Node): never {
48-
throw new Error(
49-
`Invalid state: Visitor ${this.constructor.name} doesn't handle ${arg.constructor.name}`,
50-
);
51-
}
52-
5347
export function asLiteral(value: any): o.Expression {
5448
if (Array.isArray(value)) {
5549
return o.literalArr(value.map(asLiteral));

0 commit comments

Comments
 (0)