Enhance documentation for assertion timeout

[philipp2023]

Documentation for assertion timeout and browser timeout shall be enhanced to make clear, that maximum timeout actually used is alway the browser timeout.

E.g.

• browser timeout is 5s and assertion timeout is 10s.
• Browser.Get Text my_selector == expected text
  will fail after 5s also, if element identified by my_selector is visible but different from expected text

It does not make sense to set the assertion timeout to a higher value than browser timeout, since this will never take effect.

I suggest to add an appropritate log message (warning) in this case.

[aaltat]

@allcontributors please add @philipp2023 for bugs

[allcontributors]

@aaltat

I've put up a pull request to add @philipp2023! 🎉

[aaltat]

Would you like to make a PR to enhance the documentation? Also I agree that warning would be good idea.

[philipp2023]

@aaltat:
I cloned the repo and found the location to change.

I tried to set up the dev environment as described using the bootstrap and activating the venv. Trying the invoke failed. Thus I seperately installed this as well. Following I installed beautifulsoup4, since this was missing as well.
It looks like the dev dependencies are missing in the pyproject?
This makes it hard to run/update the tests.

Thanks

[aaltat]

Bootstrap should have taken care of that, but all dev dependencies are in here https://github.com/MarketSquare/robotframework-browser/blob/main/Browser/dev-requirements.txt

[aaltat]

Do you happen to have the error message still available on how the bootstrap failed?

[philipp2023]

Hi @aaltat,
finally found some time to look into this again and solved the previous issue.
Is it correct that I need to run

• inv deps
• inv build

after python bootstrap.py and activating the venv to complete dev setup?

inv build results in following error:
`> robotframework-playwright@19.15.1 grpc_tools_node_protoc

grpc_tools_node_protoc --plugin=protoc-gen-ts_proto=D:\Data\Dev\robotframework-browser\node_modules.bin\protoc-gen-ts_proto.cmd --ts_proto_out=D:\Data\Dev\robotframework-browser\node\playwright-wrapper\generated --ts_proto_opt=outputServices=grpc-js,env=node -I ./protobuf protobuf/*.proto

D:\Data\Dev\robotframework-browser\node_modules\grpc-tools\bin\protoc.js:41
throw error;
^

Error: Command failed: D:\Data\Dev\robotframework-browser\node_modules\grpc-tools\bin\protoc.exe --plugin=protoc-gen-grpc=D:\Data\Dev\robotframework-browser\node_modules\grpc-tools\bin\grpc_node_plugin.exe --plugin=protoc-gen-ts_proto=D:\Data\Dev\robotframework-browser\node_modules.bin\protoc-gen-ts_proto.cmd --ts_proto_out=D:\Data\Dev\robotframework-browser\node\playwright-wrapper\generated --ts_proto_opt=outputServices=grpc-js,env=node -I ./protobuf protobuf/*.proto

at genericNodeError (node:internal/errors:985:15)
at wrappedFn (node:internal/errors:539:14)
at ChildProcess.exithandler (node:child_process:417:12)
at ChildProcess.emit (node:events:509:28)
at maybeClose (node:internal/child_process:1124:16)
at ChildProcess._handle.onexit (node:internal/child_process:306:5) {

code: 3221225781,
killed: false,
signal: null,
cmd: 'D:\Data\Dev\robotframework-browser\node_modules\grpc-tools\bin\protoc.exe --plugin=protoc-gen-grpc=D:\Data\Dev\robotframework-browser\node_modules\grpc-tools\bin\grpc_node_plugin.exe --plugin=protoc-gen-ts_proto=D:\Data\Dev\robotframework-browser\node_modules\.bin\protoc-gen-ts_proto.cmd --ts_proto_out=D:\Data\Dev\robotframework-browser\node\playwright-wrapper\generated --ts_proto_opt=outputServices=grpc-js,env=node -I ./protobuf protobuf/*.proto'
}`

Any idea what I could change?
Thanks, Philipp

[aaltat]

Did you also do inv protobuf?

[philipp2023]

Tried just now, same effect. Do I need to delete venv and start from scratch?

[aaltat]

Deleting venv doesn’t help, this is NodeJS side thing. Can you run the command what is shown at the error message directly in the cmd: D:\Data\Dev\robotframework-browser\node_modules\grpc-tools\bin\protoc.exe --plugin=protoc-gen-grpc=D:\Data\Dev\robotframework-browser\node_modules\grpc-tools\bin\grpc_node_plugin.exe --plugin=protoc-gen-ts_proto=D:\Data\Dev\robotframework-browser\node_modules\.bin\protoc-gen-ts_proto.cmd --ts_proto_out=D:\Data\Dev\robotframework-browser\node\playwright-wrapper\generated --ts_proto_opt=outputServices=grpc-js,env=node -I ./protobuf protobuf/*.proto

Most likely the real error is hidden by the Python and NodeJS wrapping. Also it’s worth of looking that all folders and files in the command actually exist and that command is executed from the root of the repository.

[philipp2023]

I can run the command directly in the terminal and no error message is shown (not sure, if there's no error however). I also tried different terminal types (powershell and cmd) without a difference.

Runing inv build afterwards shows the same errors as before.

[aaltat]

Interesting. I looked at CI and on windows inv node-build is working

and because the command does work from PowerShell, I am clueless. What version of nodejs you have installed? Is a reasent LTS version: https://nodejs.org/en/about/previous-releases NodeJS 26 is not yet supported, because Playwright does not support it.