TICKET-575: Remove get_repo_auth_records function as it is now deprecated

Author: Naragod

app/lib/repository.rb

@@ -224,28 +224,6 @@ def self.update_permissions_after(only_on_request: false, &block)
       nil
     end
 
-    # Returns the assignments for which students have repository access.
-    #
-    # Repository authentication subtleties:
-    # 1) a repository is associated with a Group, but..
-    # 2) ..students are associated with a Grouping (an "instance" of Group for a specific Assignment)
-    # That creates a problem since authentication in git is at the repository level, while Markus handles it at
-    # the assignment level, allowing the same Group repo to have different students according to the assignment.
-    # The two extremes to implement it are using the union of all students (permissive) or the intersection
-    # (restrictive). Instead, we are going to take a last-deadline approach, where we assume that the valid students at
-    # any point in time are the ones valid for the last assignment due. (Basically, it's nice for a group to share a
-    # repo among assignments, but at a certain point during the course we may want to add or [more frequently] remove
-    # some students from it)
-    def self.get_repo_auth_records
-      records = Assignment.joins(:assignment_properties, :course)
-                          .includes(groupings: [:group, { accepted_students: :section }])
-                          .where(assignment_properties: { vcs_submit: true }, 'courses.is_hidden': false)
-                          .order(due_date: :desc)
-      records.where(assignment_properties: { is_timed: false })
-             .or(records.where.not(groupings: { start_time: nil }))
-             .or(records.where(groupings: { start_time: nil }, due_date: Time.utc(0)..Time.current))
-    end
-
     # Return a nested hash of the form { assignment_id => { section_id => visibility } } where visibility
     # is a boolean indicating whether the given assignment is visible to the given section.
     def self.visibility_hash

spec/lib/repo/repository/abstract_repository_spec.rb

@@ -188,83 +188,6 @@
     end
   end
 
-  describe '#get_repo_auth_records' do
-    let(:assignment1) { create(:assignment, assignment_properties_attributes: { vcs_submit: false }) }
-    let(:assignment2) { create(:assignment, assignment_properties_attributes: { vcs_submit: false }) }
-
-    before do
-      create_list(:grouping_with_inviter, 3, assignment: assignment1)
-      create_list(:grouping_with_inviter, 3, assignment: assignment2)
-    end
-
-    context 'all assignments with vcs_submit == false' do
-      it 'should be empty' do
-        expect(Repository.get_class.get_repo_auth_records).to be_empty
-      end
-    end
-
-    context 'one assignment with vcs_submit == true' do
-      let(:assignment1) { create(:assignment, assignment_properties_attributes: { vcs_submit: true }) }
-
-      it 'should only contain valid memberships' do
-        ids = assignment1.groupings.map { |g| g.inviter.id }
-        expect(Repository.get_class.get_repo_auth_records.pluck('roles.id')).to match_array(ids)
-      end
-
-      context 'when there is a pending membership' do
-        before { create(:student_membership, grouping: assignment1.groupings.first) }
-
-        it 'should not contain the pending membership' do
-          ids = assignment1.groupings.map { |g| g.inviter.id }
-          expect(Repository.get_class.get_repo_auth_records.pluck('roles.id')).to match_array(ids)
-        end
-      end
-
-      context 'when the assignment belongs to a hidden course' do
-        let(:assignment1) do
-          course = create(:course, is_hidden: true)
-          create(:assignment, assignment_properties_attributes: { vcs_submit: true }, course: course)
-        end
-
-        it 'should be empty' do
-          expect(Repository.get_class.get_repo_auth_records).to be_empty
-        end
-      end
-    end
-
-    context 'both assignments with vcs_submit == true and is_timed == true' do
-      let(:assignment1) { create(:timed_assignment, assignment_properties_attributes: { vcs_submit: true }) }
-      let(:assignment2) { create(:timed_assignment, assignment_properties_attributes: { vcs_submit: true }) }
-
-      it 'should be empty' do
-        expect(Repository.get_class.get_repo_auth_records).to be_empty
-      end
-
-      context 'when one grouping has started their assignment' do
-        let!(:grouping) do
-          g = assignment1.groupings.first
-          g.update!(start_time: 1.hour.ago)
-          g.reload
-        end
-
-        it 'should contain only the members of that group' do
-          expect(Repository.get_class.get_repo_auth_records.pluck('roles.id')).to contain_exactly(grouping.inviter.id)
-        end
-
-        context 'when the timed assessment due date has ended' do
-          let(:assignment1) do
-            create(:timed_assignment, assignment_properties_attributes: { vcs_submit: true }, due_date: 1.minute.ago)
-          end
-
-          it 'should contain all members of all groups' do
-            inviter_ids = assignment1.groupings.map { |g| g.inviter.id }
-            expect(Repository.get_class.get_repo_auth_records.pluck('roles.id')).to match_array(inviter_ids)
-          end
-        end
-      end
-    end
-  end
-
   describe '#get_all_permissions' do
     let!(:course) { create(:course) }
     let(:assignment) { create(:assignment_with_criteria_and_results_and_tas) }