TICKET-578: Change tags and split_pdf_logs to restrict_with_exception

Author: Naragod

app/models/instructor.rb

@@ -9,6 +9,6 @@ class Instructor < Role
   has_many :annotation_texts, dependent: :nullify, inverse_of: :creator, foreign_key: :creator_id
   has_many :annotations, dependent: :nullify, inverse_of: :creator, foreign_key: :creator_id
   has_many :notes, dependent: :restrict_with_exception, inverse_of: :role, foreign_key: :creator_id
-  has_many :tags, dependent: :destroy, foreign_key: :role_id, inverse_of: :role
-  has_many :split_pdf_logs, dependent: :destroy, foreign_key: :role_id, inverse_of: :role
+  has_many :tags, dependent: :restrict_with_exception, foreign_key: :role_id, inverse_of: :role
+  has_many :split_pdf_logs, dependent: :restrict_with_exception, foreign_key: :role_id, inverse_of: :role
 end

spec/controllers/instructors_controller_spec.rb

@@ -178,11 +178,46 @@
         end
       end
 
+      context 'when instructor has associated tags' do
+        let(:admin) { create(:admin_user) }
+        let(:target_instructor) { create(:instructor, course: course) }
+
+        before do
+          create(:tag, role: target_instructor)
+          delete_as admin, :destroy, params: { course_id: course.id, id: target_instructor.id }
+        end
+
+        it 'does not delete the instructor and returns a conflict response' do
+          expect(Instructor.exists?(target_instructor.id)).to be(true)
+          expect(flash[:error]).to contain_message(
+            I18n.t('flash.instructors.destroy.restricted', user_name: target_instructor.user_name, message: '')
+          )
+          expect(response).to have_http_status(:conflict)
+        end
+      end
+
+      context 'when instructor has associated split_pdf_logs' do
+        let(:admin) { create(:admin_user) }
+        let(:target_instructor) { create(:instructor, course: course) }
+
+        before do
+          create(:split_pdf_log, role: target_instructor)
+          delete_as admin, :destroy, params: { course_id: course.id, id: target_instructor.id }
+        end
+
+        it 'does not delete the instructor and returns a conflict response' do
+          expect(Instructor.exists?(target_instructor.id)).to be(true)
+          expect(flash[:error]).to contain_message(
+            I18n.t('flash.instructors.destroy.restricted', user_name: target_instructor.user_name, message: '')
+          )
+          expect(response).to have_http_status(:conflict)
+        end
+      end
+
       context 'succeeds for instructor deletion' do
         let(:admin) { create(:admin_user) }
         let!(:target_instructor) { create(:instructor, course: course) }
         let!(:annotation) { create(:text_annotation, creator: target_instructor) }
-        let!(:tag) { create(:tag, role: target_instructor) }
 
         before do
           delete_as admin, :destroy, params: { course_id: course.id, id: target_instructor.id }
@@ -201,10 +236,6 @@
           expect(annotation.creator_id).to be_nil
           expect(Annotation.exists?(annotation.id)).to be(true)
         end
-
-        it 'deletes associated tags' do
-          expect(Tag.exists?(tag.id)).to be(false)
-        end
       end
     end