Skip to content

Commit 39dbbd8

Browse files
committed
ISSUE-7795: Internationalize name length validation and add frontend maxlength
1 parent cbea73e commit 39dbbd8

4 files changed

Lines changed: 9 additions & 3 deletions

File tree

app/models/exam_template.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class ExamTemplate < ApplicationRecord
99
validates :filename, :num_pages, :name, presence: true
1010
validates :name,
1111
uniqueness: { scope: :assignment },
12-
length: { maximum: 20, message: 'must be at most 20 characters' }
12+
length: { maximum: 20 }
1313
validates :num_pages, numericality: { greater_than_or_equal_to: 0,
1414
only_integer: true }
1515

app/views/exam_templates/_create_new_template.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<%= f.label :file_io, t('exam_templates.create.upload'), class: "required" %>
99
<%= f.file_field :file_io, required: true, accept: 'application/pdf' %>
1010
<%= f.label :name, ExamTemplate.human_attribute_name('name') %>
11-
<%= f.text_field :name %>
11+
<%= f.text_field :name, maxlength: 20 %>
1212
</div>
1313
<section class='dialog-actions'>
1414
<%= f.submit t(:save),

app/views/exam_templates/_form.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<div class='exam-template-section'>
99
<div class='inline-labels'>
1010
<%= f.label :name, ExamTemplate.human_attribute_name('name') %>
11-
<%= f.text_field :name %>
11+
<%= f.text_field :name, maxlength: 20 %>
1212
<span class="label">
1313
<%= t('key_pairs.file') %>
1414
</span>

config/locales/models/exam_templates/en.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ en:
88
name: Name
99
num_pages: pages
1010
template_divisions: Template Divisions
11+
errors:
12+
models:
13+
exam_template:
14+
attributes:
15+
name:
16+
too_long: "must be at most %{count} characters"
1117
models:
1218
exam_template:
1319
one: Exam Template

0 commit comments

Comments
 (0)