Mapping an object with getter only properties seems to be broken in v10.0.6 (works as expected in 7.4.0)

[ripebananas]

Hello. I am trying to map an object with getter-only properties using a custom Map functon. This seems to be broken in v10.0.6, while it was fine in v7.4.0. See the following sample:

var typeAdapterConfig = new Mapster.TypeAdapterConfig();
typeAdapterConfig.Scan(typeof(Program).Assembly);
typeAdapterConfig.Compile();
var mapper = new MapsterMapper.Mapper(typeAdapterConfig);

var dto = new Dto { Data = new("new") };
Console.WriteLine(mapper.Map(dto, new Entity { Data = new("old") }).Data?.Value); // outputs "old" with v10.0.6, outputs "new" with v7.4.0
Console.WriteLine(mapper.Map(dto, new Entity()).Data?.Value); // outputs "new" with both v10.0.6 and v7.4.0
Console.WriteLine(mapper.Map<Entity>(dto).Data?.Value); // outputs "new" with both v10.0.6 and v7.4.0

class Dto { public Data? Data { get; set; } }
class Entity { public Data? Data { get; set; } }
class Data(string value) { public string Value => value; }

class Mappings : Mapster.IRegister
{
    public void Register(Mapster.TypeAdapterConfig config)
    {
        config.NewConfig<Dto, Entity>()
            .Map(x => x.Data, x => x.Data == null ? null : new Data(x.Data.Value));
    }
}

Specifically this case seems to be broken:

var dto = new Dto { Data = new("new") };
var entity = mapper.Map(dto, new Entity { Data = new("old") });

I would expect the result entity's Data property to be mapped correctly from the source dto, as specified in the mapping function:
config.NewConfig<Dto, Entity>().Map(x => x.Data, x => x.Data == null ? null : new Data(x.Data.Value));
As noted, Mapster v7.4.0 seems to be find, but v10.0.* seems to be broken.
Or maybe I am missing something here, please advise, thank you.

[DocSvartz]

Hi @ripebananas
Due to numerous issues, classes with this signature
class Data(string value) { public string Value => value; }
are no longer automatically recognized as record types. and release notes

That is, it no support non-destructive mutation by creating a new modified object.

Do you want to get a new instance of the Data type each time or change the value in an existing one?

[DocSvartz]

If I understand you correctly and you want to update the null destination, then this should all work without any configuration at all.

If you want to get a new Data instance:

record Data 
//or 

[AdaptWith(AdaptDirectives.DestinationAsRecord)]
class Data

If you want to get a mutation current Data instance:

class Data(string value)
{
    [UseDestinationValue]
    public string Value => value; 
}

// or
 config
     .ForDestinationType<Data>()
     .UseDestinationValue(x => x.Value);

Although the use destinatinvalue case really doesn't work, it seems there's some kind of bug

[DocSvartz]

new UsedestinationValue for primitive type, currently work only autoproperty

class Data(string value)
{
    public string Value { get; } = value;
}

[ripebananas]

Hey @DocSvartz
Here's my real world example from my application where I noticed the mapping issue (the above was just an example).
I have some DTOs with System.Uri property, and these DTOs need to be mapped to EF Core entities. The EF Core entities also have System.Uri properties.

class Dto { public System.Uri Uri { get; set; } }
class Entity { public System.Uri Uri { get; set; } }

class Mappings : Mapster.IRegister
{
    public void Register(Mapster.TypeAdapterConfig config)
    {
        config.NewConfig<Dto, Entity>();
    }
}

I need to support these cases:

// mapping from a dto to an existing/instantiated entity
mapper.Map<Dto, Entity>(dto, entity); => with v10 this would not update the Uri property of the entity

// mapping from a dto to a non-existing entity
mapper.Map<Entity>(dto); => with v10 this would produce an exception

Both cases seem to be fine with v7.4.0
I also tried these configs and they seem to have no effect:

config.NewConfig<Dto, Entity>().Map(x => x.Uri, x => new Uri(x.Uri.OriginalString));

config.NewConfig<Dto, Entity>().Map(x => x.Uri, x => x.Uri);

And to answer you question - in this specific case with System.Uri, I don't trully care if the destination property gets re-created, updated, or uses the source value.

I'll try your suggestions now...

[bkaidbb]

I had the same/similar issue upgrading from 7.4.0 to to 10.0.6:

Program.cs:

using Mapster;
using MapsterMapper;

var config = new TypeAdapterConfig();
config.Apply(new MyRegister());
var mapper = new Mapper(config);

var source = new Source { MyUrl = "https://example.com" };
var dest = mapper.Map<Source, Destination>(source);
Console.WriteLine($"Url is {dest.MyUrl}");

public class Source
{
    public string? MyUrl { get; set; }
}

public class Destination
{
    public Uri? MyUrl { get; set; }
}

public class MyRegister : IRegister
{
    public void Register(TypeAdapterConfig config)
    {
        config.NewConfig<Source, Destination>()
            .Map(dest => dest.MyUrl, src => src.MyUrl != null ? new Uri(src.MyUrl) : null);
    }
}

Csproj:

<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>net10.0</TargetFramework>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
    </PropertyGroup>
    <ItemGroup>
      <PackageReference Include="Mapster" Version="10.0.6" />
    </ItemGroup>
</Project>

Stack trace (10.0.6)

System.ArgumentNullException: Value cannot be null. (Parameter 'uriString')
   at System.ArgumentNullException.Throw(String paramName)
   at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)
   at System.Uri..ctor(String uriString)
   at lambda_method1(Closure, Source)
   at MapsterMapper.Mapper.Map[TSource,TDestination](TSource source)
   at Program.<Main>$(String[] args) in ~/Code/MapsterTest/ConsoleApp1/ConsoleApp1/Program.cs:line 9

[DocSvartz]

@ripebananas @bkaidbb

This URI issue is completely different.
Judging by the wiki description, it shouldn't have worked. Because .Map() aren't designed for constructing objects at all.

Also, Url can't create itself, since it doesn't contain any fields from which it can be created.

[DocSvartz]

Most likely this didn't work in 7.4.0. But now it works.

[TestMethod]
public void TestMethod1()
{
    TypeAdapterConfig<string, Uri>
        .NewConfig()
        .MapWith((src) => src != null ? new Uri(src) : null);


    var source = new MyURI {  Uri = "https://example.com" };
    var nullUri = new MyURI { Uri = null };
    
    var result = source.Adapt<DestinationURI>();
    var nullResult = nullUri.Adapt<DestinationURI>();
}


class MyURI
{
   public string Uri { get; set; }
}

class DestinationURI
{
    public Uri Uri { get; set; }
}

var updateNullUri = source.Adapt(nullResult); // this too work

[ripebananas]

Most likely this didn't work in 7.4.0. But now it works.

[TestMethod]
public void TestMethod1()
{
    TypeAdapterConfig<string, Uri>
        .NewConfig()
        .MapWith((src) => src != null ? new Uri(src) : null);


    var source = new MyURI {  Uri = "https://example.com" };
    var nullUri = new MyURI { Uri = null };
    
    var result = source.Adapt<DestinationURI>();
    var nullResult = nullUri.Adapt<DestinationURI>();
}


class MyURI
{
   public string Uri { get; set; }
}

class DestinationURI
{
    public Uri Uri { get; set; }
}

var updateNullUri = source.Adapt(nullResult); // this too work

Ok, I don't know where I have been looking at and how I could have missed it, but it seems like the MapWith method does the trick for me:

config.NewConfig<Uri, Uri>().MapWith(x => x);

Thanks.

[bkaidbb]

Yeah that did fix my issue too, thanks!

using Mapster;
using MapsterMapper;

var config = new TypeAdapterConfig();
config.Apply(new MyRegister());
var mapper = new Mapper(config);

var source = new Source { MyUrl = "https://example.com" };
var dest = mapper.Map<Source, Destination>(source);
Console.WriteLine($"Url is {dest.MyUrl}");

public class Source
{
    public string? MyUrl { get; set; }
}

public class Destination
{
    public Uri? MyUrl { get; set; }
}

public class MyRegister : IRegister
{
    public void Register(TypeAdapterConfig config)
    {
        config
            .NewConfig<string?, Uri?>()
            .MapWith(src => !string.IsNullOrEmpty(src) ? new Uri(src) : null);

        config
            .NewConfig<Source, Destination>();
    }
}