Skip to content

Commit 10e0984

Browse files
sbryngelsonclaude
andcommitted
Update docs to reflect 6 precheck steps (was 5)
This PR adds a 6th lint check (Fortran/Fypp analysis). Update CLAUDE.md and common-pitfalls.md to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7bd4a4b commit 10e0984

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.claude/rules/common-pitfalls.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
## PR Checklist
5555
Before submitting a PR:
5656
- [ ] `./mfc.sh format -j 8` (auto-format)
57-
- [ ] `./mfc.sh precheck -j 8` (5 CI lint checks)
57+
- [ ] `./mfc.sh precheck -j 8` (6 CI lint checks)
5858
- [ ] `./mfc.sh build -j 8` (compiles)
5959
- [ ] `./mfc.sh test --only <relevant> -j 8` (tests pass)
6060
- [ ] If adding parameters: all 4 locations updated

CLAUDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ All commands run from the repo root via `./mfc.sh`.
3939
./mfc.sh test --generate --only <feature> # Regenerate golden files after intentional output change
4040

4141
# Verification (pre-commit CI checks)
42-
./mfc.sh precheck -j 8 # Run all 5 lint checks (same as CI gate)
42+
./mfc.sh precheck -j 8 # Run all 6 lint checks (same as CI gate)
4343
./mfc.sh format -j 8 # Auto-format Fortran (.fpp/.f90) + Python
4444
./mfc.sh lint # Pylint + Python unit tests
4545
./mfc.sh spelling # Spell check
@@ -99,7 +99,7 @@ IMPORTANT: Follow this loop for ALL code changes. Do not skip steps.
9999
2. **Plan** — For multi-file changes, outline your approach before implementing.
100100
3. **Implement** — Make small, focused changes. One logical change per commit.
101101
4. **Format** — Run `./mfc.sh format -j 8` to auto-format.
102-
5. **Verify** — Run `./mfc.sh precheck -j 8` (same 5 checks as CI lint gate).
102+
5. **Verify** — Run `./mfc.sh precheck -j 8` (same 6 checks as CI lint gate).
103103
6. **Build** — Run `./mfc.sh build -j 8` to verify compilation.
104104
7. **Test** — Run relevant tests: `./mfc.sh test --only <feature> -j 8`.
105105
For changes to `src/common/`, test ALL three targets: `./mfc.sh test -j 8`.

0 commit comments

Comments
 (0)