Reverting to old blockchain code

The notification code requiring the new support library broke
the app in production.  Going back to the way it was, but keeping
all the other changes to the app.  Production ready signed APK
tested on one of my devices.

Author: hank

wallet/libs/android-support-v4.jar

@@ -39,9 +39,7 @@
 		<dependency>
 			<groupId>com.google.android</groupId>
 			<artifactId>support-v4</artifactId>
-			<version>r13</version>
-            <scope>system</scope>
-            <systemPath>${basedir}/libs/android-support-v4.jar</systemPath>
+			<version>r7</version>
         </dependency>
 
 		<!-- com.actionbarsherlock.* -->

wallet/pom.xml

@@ -234,7 +234,7 @@ private void notifyCoinsReceived(@Nullable final Address from, @Nonnull final Bi
 		notification.setNumber(notificationCount == 1 ? 0 : notificationCount);
 		notification.setWhen(System.currentTimeMillis());
 		notification.setSound(Uri.parse("android.resource://" + getPackageName() + "/" + R.raw.coins_received));
-		nm.notify(NOTIFICATION_ID_COINS_RECEIVED, notification.build());
+		nm.notify(NOTIFICATION_ID_COINS_RECEIVED, notification.getNotification());
 	}
 
 	private final class PeerConnectivityListener extends AbstractPeerEventListener implements OnSharedPreferenceChangeListener
@@ -287,31 +287,25 @@ private void changed(final int numPeers)
 				@Override
 				public void run()
 				{
-                    if (numPeers == 0 || GenericUtils.isBlackberry())
-                    {
-                        nm.cancel(NOTIFICATION_ID_CONNECTED);
-                    }
-                    else
-                    {
-                        final NotificationCompat.Builder notification = new NotificationCompat.Builder(BlockchainServiceImpl.this)
-                                .setSmallIcon(R.drawable.stat_sys_peers, numPeers > 4 ? 4 : numPeers)
-                                .setContentTitle(getString(R.string.app_name))
-                                .setContentText(getString(R.string.notification_peers_connected_msg, numPeers))
-                                .setContentIntent(PendingIntent.getActivity(BlockchainServiceImpl.this, 0, new Intent(BlockchainServiceImpl.this,
-                                        WalletActivity.class), 0))
-                                .setWhen(System.currentTimeMillis())
-                                .setOngoing(true)
-                                /*
-                                 * These calls are ignored by the support library for
-                                 * pre-4.1 devices.
-                                 */
-                                .addAction(R.drawable.ic_action_clear,
-                                        getString(R.string.wallet_options_disconnect),
-                                        PendingIntent.getService(BlockchainServiceImpl.this, 0,
-                                                new Intent(BlockchainServiceImpl.this, BlockchainServiceImpl.class)
-                                                        .setAction(BlockchainService.ACTION_STOP_SERVICE), 0));
-                        nm.notify(NOTIFICATION_ID_CONNECTED, notification.build());
-                    }
+					final boolean connectivityNotification = prefs.getBoolean(Constants.PREFS_KEY_CONNECTIVITY_NOTIFICATION, false);
+
+					if (!connectivityNotification || numPeers == 0)
+					{
+						nm.cancel(NOTIFICATION_ID_CONNECTED);
+					}
+					else
+					{
+						final NotificationCompat.Builder notification = new NotificationCompat.Builder(BlockchainServiceImpl.this);
+						notification.setSmallIcon(R.drawable.stat_sys_peers, numPeers > 4 ? 4 : numPeers);
+						notification.setContentTitle(getString(R.string.app_name));
+						notification.setContentText(getString(R.string.notification_peers_connected_msg, numPeers));
+						notification.setContentIntent(PendingIntent.getActivity(BlockchainServiceImpl.this, 0, new Intent(BlockchainServiceImpl.this,
+								WalletActivity.class), 0));
+						notification.setWhen(System.currentTimeMillis());
+						notification.setOngoing(true);
+						nm.notify(NOTIFICATION_ID_CONNECTED, notification.getNotification());
+					}
+
 					// send broadcast
 					sendBroadcastPeerState(numPeers);
 				}
@@ -569,7 +563,6 @@ public void onReceive(final Context context, final Intent intent)
 				if (isIdle)
 				{
 					log.info("idling detected, stopping service");
-                    WalletApplication.scheduleStartBlockchainService(BlockchainServiceImpl.this);
 					stopSelf();
 				}
 			}
@@ -715,7 +708,6 @@ else if (BlockchainService.ACTION_RESET_BLOCKCHAIN.equals(action))
 			log.info("will remove blockchain on service shutdown");
 
 			resetBlockchainOnShutdown = true;
-            WalletApplication.scheduleStartBlockchainService(this);
 			stopSelf();
 		}
 		else if (BlockchainService.ACTION_BROADCAST_TRANSACTION.equals(action))
@@ -733,12 +725,6 @@ else if (BlockchainService.ACTION_BROADCAST_TRANSACTION.equals(action))
 				log.info("peergroup not available, not broadcasting transaction " + tx.getHashAsString());
 			}
 		}
-        else if (BlockchainService.ACTION_STOP_SERVICE.equals(action))
-        {
-            log.info("stopping self");
-            // deliberate stop command, so don't schedule restart
-            stopSelf();
-        }
 
 		return START_NOT_STICKY;
 	}
@@ -748,6 +734,8 @@ public void onDestroy()
 	{
 		log.debug(".onDestroy()");
 
+		WalletApplication.scheduleStartBlockchainService(this);
+
 		unregisterReceiver(tickReceiver);
 
 		application.getWallet().removeEventListener(walletEventListener);
@@ -804,7 +792,6 @@ public void onDestroy()
 	public void onLowMemory()
 	{
 		log.warn("low memory detected, stopping service");
-        WalletApplication.scheduleStartBlockchainService(this);
 		stopSelf();
 	}