extract sleep duration to constant

Author: ElectricalBoy

scripts/deploy.py

@@ -3,7 +3,6 @@
 import pathlib
 import re
 import sys
-import time
 
 from typing import Iterable
 
@@ -45,7 +44,6 @@ def deploy_all_files_for_wiki(
                     session, file_path, file_content, wiki, page, token, deploy_reason
                 )
                 all_modules_deployed = all_modules_deployed and module_deployed
-                time.sleep(4)
             print("::endgroup::")
     return all_modules_deployed
 

scripts/deploy_res.py

@@ -2,7 +2,6 @@
 import pathlib
 import sys
 import subprocess
-import time
 
 from typing import Iterable
 
@@ -41,7 +40,6 @@ def deploy_resources(
             all_deployed = all_deployed and deploy_result[0]
             changes_made = changes_made or deploy_result[1]
             print("::endgroup::")
-            time.sleep(4)
     return (all_deployed, changes_made)
 
 

scripts/deploy_util.py

@@ -10,6 +10,7 @@
 __all__ = [
     "DEPLOY_TRIGGER",
     "HEADER",
+    "SLEEP_DURATION",
     "deploy_file_to_wiki",
     "get_git_deploy_reason",
     "get_wiki_api_url",
@@ -28,6 +29,7 @@
     "accept": "application/json",
     "Accept-Encoding": "gzip",
 }
+SLEEP_DURATION = 4
 
 
 def get_wikis() -> set[str]:
@@ -36,7 +38,7 @@ def get_wikis() -> set[str]:
         headers=HEADER,
     )
     wikis = response.json()
-    time.sleep(4)
+    time.sleep(SLEEP_DURATION)
     return set(wikis["allwikis"].keys())
 
 
@@ -94,6 +96,7 @@ def deploy_file_to_wiki(
         print(f"::warning file={str(file_path)}::failed to deploy")
         write_to_github_summary_file(f":warning: {str(file_path)} failed to deploy")
         deployed = False
+    time.sleep(SLEEP_DURATION)
     return deployed, change_made
 
 

scripts/login_and_get_token.py

@@ -4,7 +4,7 @@
 
 import requests
 
-from deploy_util import HEADER, get_wiki_api_url, read_cookie_jar
+from deploy_util import HEADER, SLEEP_DURATION, get_wiki_api_url, read_cookie_jar
 
 __all__ = ["get_token"]
 
@@ -43,7 +43,7 @@ def login(wiki: str):
         )
         loggedin.add(wiki)
         cookie_jar.save(ignore_discard=True)
-        time.sleep(4)
+        time.sleep(SLEEP_DURATION)
 
 
 @functools.cache

scripts/protect_page.py

@@ -6,6 +6,7 @@
 
 from deploy_util import (
     HEADER,
+    SLEEP_DURATION,
     get_wiki_api_url,
     read_cookie_jar,
     write_to_github_summary_file,
@@ -48,7 +49,7 @@ def protect_page(page: str, wiki: str, protect_mode: Literal["edit", "create"]):
             },
         ).json()
 
-        time.sleep(4)
+        time.sleep(SLEEP_DURATION)
         protections = response["protect"].get("protections")
         for protection in protections:
             if protection[protect_mode] == "allow-only-sysop":
@@ -68,7 +69,7 @@ def check_if_page_exists(page: str, wiki: str) -> bool:
             data={"titles": page, "prop": "info"},
         ).text
 
-        time.sleep(4)
+        time.sleep(SLEEP_DURATION)
         return 'missing":"' in result
 
 

scripts/remove_dev.py

@@ -5,6 +5,7 @@
 
 from deploy_util import (
     HEADER,
+    SLEEP_DURATION,
     get_wiki_api_url,
     get_wikis,
     read_cookie_jar,
@@ -34,7 +35,7 @@ def remove_page(session: requests.Session, page: str, wiki: str):
             "token": token,
         },
     ).text
-    time.sleep(8)
+    time.sleep(SLEEP_DURATION)
 
     if '"delete"' not in result:
         print(f"::warning::could not delete {page} on {wiki}")
@@ -57,7 +58,7 @@ def search_and_remove(wiki: str):
                 "srprop": "",
             },
         ).json()
-        time.sleep(4)
+        time.sleep(SLEEP_DURATION)
         pages = search_result["query"].get("search")
 
         if len(pages) == 0: