Skip to content

Commit fbaa1c4

Browse files
Followup fixes
1 parent b9020e7 commit fbaa1c4

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/org/labkey/targetedms/TargetedMSManager.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2151,7 +2151,7 @@ public static void renameRun(long runId, String newDescription, User user) throw
21512151
if (newDescription == null || newDescription.isEmpty())
21522152
return;
21532153

2154-
try (DbScope.Transaction _ = getSchema().getScope().ensureTransaction())
2154+
try (DbScope.Transaction t = getSchema().getScope().ensureTransaction())
21552155
{
21562156
new SqlExecutor(getSchema()).execute("UPDATE " + getTableInfoRuns() + " SET Description=? WHERE Id = ?",
21572157
newDescription, runId);
@@ -2166,6 +2166,7 @@ public static void renameRun(long runId, String newDescription, User user) throw
21662166
expRun.save(user);
21672167
}
21682168
}
2169+
t.commit();
21692170
}
21702171
}
21712172

@@ -2865,7 +2866,7 @@ public static List<QCTraceMetricValues> calculateTraceMetricValues(List<QCMetric
28652866
Double traceValue = qcMetricConfiguration.getTraceValue();
28662867
QCMetricConfiguration.TimeValueOption timeValueOption = qcMetricConfiguration.getParsedTimeValueOption();
28672868
float minValue = Float.MAX_VALUE;
2868-
float maxValue = -Float.MIN_VALUE;
2869+
float maxValue = -Float.MAX_VALUE;
28692870
for (int i = 0; i < times.length; i++)
28702871
{
28712872
if (timeValueOption == QCMetricConfiguration.TimeValueOption.First)
@@ -2961,7 +2962,7 @@ else if (traceValue != null && values[i] >= traceValue)
29612962
{
29622963
valuesToStore.put(sampleFileChromInfo, minValue);
29632964
}
2964-
else if (timeValueOption == QCMetricConfiguration.TimeValueOption.Max && maxValue != Float.MIN_VALUE)
2965+
else if (timeValueOption == QCMetricConfiguration.TimeValueOption.Max && maxValue != -Float.MAX_VALUE)
29652966
{
29662967
valuesToStore.put(sampleFileChromInfo, maxValue);
29672968
}

0 commit comments

Comments
 (0)