Skip to content

Commit dbd2b07

Browse files
authored
Remove object-level discussions (#937)
1 parent 5728827 commit dbd2b07

4 files changed

Lines changed: 7 additions & 71 deletions

File tree

flow/src/org/labkey/flow/controllers/compensation/showCompensation.jsp

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
* limitations under the License.
1616
*/
1717
%>
18-
<%@ page import="org.labkey.api.announcements.DiscussionService" %>
1918
<%@ page import="org.labkey.api.security.permissions.UpdatePermission" %>
2019
<%@ page import="org.labkey.api.util.HtmlString" %>
2120
<%@ page import="org.labkey.api.view.ActionURL" %>
@@ -25,10 +24,10 @@
2524
<%@ page import="org.labkey.flow.controllers.FlowParam" %>
2625
<%@ page import="org.labkey.flow.controllers.well.WellController" %>
2726
<%@ page import="org.labkey.flow.data.FlowCompensationMatrix" %>
28-
<%@ page import="org.labkey.flow.data.FlowDataType"%>
27+
<%@ page import="org.labkey.flow.data.FlowDataType" %>
2928
<%@ page import="org.labkey.flow.data.FlowRun"%>
3029
<%@ page import="org.labkey.flow.data.FlowWell"%>
31-
<%@ page import="org.labkey.flow.view.SetCommentView" %>
30+
<%@ page import="org.labkey.flow.view.SetCommentView"%>
3231
<%@ page import="org.labkey.flow.view.SetGraphSizeView" %>
3332
<%@ page import="java.text.DecimalFormat" %>
3433
<%@ page import="java.util.HashMap" %>
@@ -192,17 +191,3 @@
192191
</table>
193192
<% } %>
194193
<%=link("Download", flowComp.urlDownload()).nofollow()%><br>
195-
<%
196-
DiscussionService service = DiscussionService.get();
197-
if (service != null)
198-
{
199-
DiscussionService.DiscussionView discussion = service.getDiscussionArea(
200-
getViewContext(),
201-
flowComp.getLSID(),
202-
flowComp.urlShow(),
203-
"Discussion of " + flowComp.getLabel(),
204-
false, true);
205-
if (discussion != null)
206-
include(discussion, out);
207-
}
208-
%>

flow/src/org/labkey/flow/controllers/executescript/showScript.jsp

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
*/
1717
%>
1818
<%@ page import="org.labkey.api.action.NullSafeBindException" %>
19-
<%@ page import="org.labkey.api.announcements.DiscussionService" %>
2019
<%@ page import="org.labkey.api.data.CompareType" %>
2120
<%@ page import="org.labkey.api.data.Table" %>
2221
<%@ page import="org.labkey.api.query.FieldKey" %>
@@ -92,19 +91,3 @@ The analysis section describes which gates in the analysis, as well as the stati
9291
}
9392
} %>
9493
</div>
95-
96-
<%
97-
DiscussionService service = DiscussionService.get();
98-
if (service != null)
99-
{
100-
DiscussionService.DiscussionView discussion = service.getDiscussionArea(
101-
context,
102-
script.getLSID(),
103-
script.urlShow(),
104-
"Discussion of " + script.getLabel(),
105-
false, true);
106-
if (discussion != null)
107-
include(discussion, out);
108-
}
109-
%>
110-

flow/src/org/labkey/flow/controllers/run/showRun.jsp

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,10 @@
1616
*/
1717
%>
1818
<%@ page buffer="none" %>
19-
<%@ page import="org.labkey.api.announcements.DiscussionService" %>
20-
<%@ page import="org.labkey.api.attachments.Attachment"%>
19+
<%@ page import="org.labkey.api.attachments.Attachment" %>
2120
<%@ page import="org.labkey.api.data.Container"%>
2221
<%@ page import="org.labkey.api.data.ContainerManager"%>
23-
<%@ page import="org.labkey.api.exp.api.ExperimentUrls" %>
22+
<%@ page import="org.labkey.api.exp.api.ExperimentUrls"%>
2423
<%@ page import="org.labkey.api.portal.ProjectUrls" %>
2524
<%@ page import="org.labkey.api.security.User" %>
2625
<%@ page import="org.labkey.api.security.permissions.UpdatePermission" %>
@@ -38,7 +37,6 @@
3837
<%@ page import="org.labkey.flow.data.FlowRun" %>
3938
<%@ page import="org.labkey.flow.view.FlowQueryView" %>
4039
<%@ page import="org.labkey.flow.view.SetCommentView" %>
41-
<%@ page import="java.util.Map" %>
4240
<%@ page extends="org.labkey.api.jsp.JspBase" %>
4341
<%@ taglib prefix="labkey" uri="http://www.labkey.org/taglib" %>
4442
<%!
@@ -115,25 +113,11 @@
115113
%><%=link("Download Analysis zip", run.urlFor(RunController.ExportAnalysis.class).addParameter("selectionType", "runs")).nofollow()%><br><%
116114
}
117115
118-
119116
for (Attachment a : run.getAttachments())
120117
{
121118
%><div>
122119
<a href="<%=h(run.getAttachmentDownloadURL(a))%>"><i class="<%=h(Attachment.getFileIconFontCls(a.getName()))%>"></i> <%=h(a.getName())%></a>
123120
</div><%
124121
}
125-
126-
DiscussionService service = DiscussionService.get();
127-
if (service != null)
128-
{
129-
DiscussionService.DiscussionView discussion = service.getDiscussionArea(
130-
getViewContext(),
131-
run.getLSID(),
132-
run.urlShow(),
133-
"Discussion of " + run.getLabel(),
134-
false, true);
135-
if (discussion != null)
136-
include(discussion, out);
137-
}
138122
%>
139123
</p>

flow/src/org/labkey/flow/controllers/well/showWell.jsp

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
* limitations under the License.
1616
*/
1717
%>
18-
<%@ page import="org.labkey.api.announcements.DiscussionService" %>
1918
<%@ page import="org.labkey.api.exp.OntologyManager" %>
2019
<%@ page import="org.labkey.api.exp.api.ExpMaterial" %>
2120
<%@ page import="org.labkey.api.exp.api.ExperimentUrls" %>
@@ -26,7 +25,8 @@
2625
<%@ page import="org.labkey.api.security.User" %>
2726
<%@ page import="org.labkey.api.security.permissions.ReadPermission" %>
2827
<%@ page import="org.labkey.api.security.permissions.UpdatePermission" %>
29-
<%@ page import="org.labkey.api.util.DateUtil"%>
28+
<%@ page import="org.labkey.api.util.DateUtil" %>
29+
<%@ page import="org.labkey.api.util.JavaScriptFragment"%>
3030
<%@ page import="org.labkey.api.util.PageFlowUtil" %>
3131
<%@ page import="org.labkey.api.util.Tuple3" %>
3232
<%@ page import="org.labkey.api.util.URIUtil" %>
@@ -58,7 +58,6 @@
5858
<%@ page import="java.util.Map" %>
5959
<%@ page import="java.util.regex.Matcher" %>
6060
<%@ page import="java.util.regex.Pattern" %>
61-
<%@ page import="org.labkey.api.util.JavaScriptFragment" %>
6261
<%@ page extends="org.labkey.flow.controllers.well.WellController.Page" %>
6362
<%@ taglib prefix="labkey" uri="http://www.labkey.org/taglib" %>
6463
<%!
@@ -592,22 +591,7 @@ if (getRun() != null)
592591
%><%=link("Experiment Run Graph Details", urlProvider(ExperimentUrls.class).getRunGraphDetailURL(getRun().getExperimentRun(), well.getData()))%><br><%
593592
}
594593
595-
%></p><%
596-
597-
DiscussionService service = DiscussionService.get();
598-
if (service != null)
599-
{
600-
DiscussionService.DiscussionView discussion = service.getDiscussionArea(
601-
getViewContext(),
602-
well.getLSID(),
603-
well.urlShow(),
604-
"Discussion of " + well.getLabel(),
605-
false, true);
606-
if (discussion != null)
607-
include(discussion, out);
608-
}
609-
%>
610-
594+
%></p>
611595

612596
<%!
613597
boolean canReadPipelineFiles(User user, PipeRoot root)

0 commit comments

Comments
 (0)