Skip to content

Commit 7c9c071

Browse files
Still more forUpdate parameters (#891)
1 parent 0ded3cc commit 7c9c071

20 files changed

Lines changed: 41 additions & 31 deletions

elisa/src/org/labkey/elisa/ElisaAssayProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ public DataExchangeHandler createDataExchangeHandler()
410410

411411
public Domain getConcentrationWellGroupDomain(ExpProtocol protocol)
412412
{
413-
return getDomainByPrefix(protocol, ASSAY_DOMAIN_DATA);
413+
return getDomainByPrefix(protocol, ASSAY_DOMAIN_DATA, false);
414414
}
415415

416416
@Override

elispotassay/src/org/labkey/elispot/ElispotAssayProvider.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ public AssayTableMetadata getTableMetadata(@NotNull ExpProtocol protocol)
222222
}
223223

224224
@Override
225-
public Domain getResultsDomain(ExpProtocol protocol)
225+
public Domain getResultsDomain(ExpProtocol protocol, boolean forUpdate)
226226
{
227227
return null;
228228
}
@@ -350,12 +350,12 @@ public ActionURL getImportURL(Container container, ExpProtocol protocol)
350350

351351
public Domain getAntigenWellGroupDomain(ExpProtocol protocol)
352352
{
353-
return getDomainByPrefix(protocol, ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
353+
return getDomainByPrefix(protocol, ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
354354
}
355355

356356
public Domain getAnalyteDomain(ExpProtocol protocol)
357357
{
358-
return getDomainByPrefix(protocol, ASSAY_DOMAIN_ANALYTE);
358+
return getDomainByPrefix(protocol, ASSAY_DOMAIN_ANALYTE, false);
359359
}
360360

361361
@Override

elispotassay/src/org/labkey/elispot/ElispotDataHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ public static void populateAntigenDataProperties(ExpRun run, Plate plate, PlateR
265265
{
266266
Container container = run.getContainer();
267267

268-
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(run.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
268+
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(run.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
269269
DomainProperty cellWellProp = antigenDomain.getPropertyByName(ElispotAssayProvider.CELLWELL_PROPERTY_NAME);
270270

271271
List<? extends ExpData> data = run.getOutputDatas(ElispotDataHandler.ELISPOT_DATA_TYPE);
@@ -324,7 +324,7 @@ public static void populateAntigenRunProperties(ExpRun run, Plate plate, PlateRe
324324
{
325325
Container container = run.getContainer();
326326

327-
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(run.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
327+
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(run.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
328328
List<? extends DomainProperty> antigenProps = antigenDomain.getProperties();
329329
DomainProperty cellWellProp = antigenDomain.getPropertyByName(ElispotAssayProvider.CELLWELL_PROPERTY_NAME);
330330

elispotassay/src/org/labkey/elispot/ElispotManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public static TableInfo getTableInfoElispotRunData()
7676
@NotNull
7777
public static TableInfo getTableInfoElispotAntigen(ExpProtocol protocol)
7878
{
79-
Domain domain = AbstractAssayProvider.getDomainByPrefix(protocol, ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
79+
Domain domain = AbstractAssayProvider.getDomainByPrefix(protocol, ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
8080
if (null != domain)
8181
return StorageProvisioner.createTableInfo(domain);
8282
throw new IllegalStateException("Domain not found for protocol: " + protocol.getName());

elispotassay/src/org/labkey/elispot/ElispotProtocolSchema.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public TableInfo createProviderTable(String name, ContainerFilter cf)
8484
{
8585
if (name.equalsIgnoreCase(ANTIGEN_TABLE_NAME))
8686
{
87-
Domain domain = AbstractAssayProvider.getDomainByPrefix(getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
87+
Domain domain = AbstractAssayProvider.getDomainByPrefix(getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
8888
if (null != domain)
8989
return new ElispotRunAntigenTable(this, cf, domain, getProtocol());
9090
}

elispotassay/src/org/labkey/elispot/ElispotUploadWizardAction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public PlateAnalytePropertyHelper createAnalytePropertyHelper(ElispotRunUploadFo
168168
@Override
169169
protected void addRunActionButtons(ElispotRunUploadForm newRunForm, InsertView insertView, ButtonBar bbar)
170170
{
171-
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(_protocol, ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
171+
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(_protocol, ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
172172
List<? extends DomainProperty> antigenColumns = antigenDomain.getProperties();
173173
if (antigenColumns.isEmpty())
174174
{
@@ -338,7 +338,7 @@ public boolean executeStep(ElispotRunUploadForm form, BindException errors) thro
338338
}
339339
}
340340

341-
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(form.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
341+
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(form.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
342342
List<? extends DomainProperty> antigenColumns = antigenDomain.getProperties();
343343
if (antigenColumns.isEmpty())
344344
{

elispotassay/src/org/labkey/elispot/pipeline/BackgroundSubtractionJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ public void run()
124124
{
125125
String dataLsid = data.get(0).getLSID();
126126
Map<String, Object> propMap = new HashMap<>();
127-
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(run.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
127+
Domain antigenDomain = AbstractAssayProvider.getDomainByPrefix(run.getProtocol(), ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
128128

129129
DomainProperty cellWellProp = antigenDomain.getPropertyByName(ElispotAssayProvider.CELLWELL_PROPERTY_NAME);
130130
DomainProperty antigenNameProp = antigenDomain.getPropertyByName(ElispotAssayProvider.ANTIGENNAME_PROPERTY_NAME);

elispotassay/src/org/labkey/elispot/query/ElispotRunAntigenTable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ protected ColumnInfo resolveColumn(String name)
9090
@Override
9191
public TableInfo getLookupTableInfo()
9292
{
93-
Domain domain = AbstractAssayProvider.getDomainByPrefix(_protocol, ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP);
93+
Domain domain = AbstractAssayProvider.getDomainByPrefix(_protocol, ElispotAssayProvider.ASSAY_DOMAIN_ANTIGEN_WELLGROUP, false);
9494
return new ElispotRunAntigenTable(_userSchema, getLookupContainerFilter(), domain, _protocol);
9595
}
9696
};

flow/src/org/labkey/flow/data/FlowAssayProvider.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,18 @@ public Domain getRunDomain(ExpProtocol protocol)
198198

199199
@Override
200200
public Domain getBatchDomain(ExpProtocol protocol)
201+
{
202+
return getBatchDomain(protocol, false);
203+
}
204+
205+
@Override
206+
public Domain getBatchDomain(ExpProtocol protocol, boolean forUpdate)
201207
{
202208
return null;
203209
}
204210

205211
@Override
206-
public Domain getResultsDomain(ExpProtocol protocol)
212+
public Domain getResultsDomain(ExpProtocol protocol, boolean forUpdate)
207213
{
208214
return null;
209215
}

flow/src/org/labkey/flow/reports/FlowReportManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ public static Domain ensureDomain(FlowReport report, User user, FlowTableType ta
202202
domain.setDescription("Domain for " + report.getDescriptor().getDescriptorType() + " reports on flow table " + tableType);
203203
domain.save(user);
204204

205-
domain = PropertyService.get().getDomain(domain.getTypeId());
205+
domain = PropertyService.get().getDomain(domain.getTypeId(), true);
206206

207207
for (PropertyDescriptor prop : properties)
208208
{

0 commit comments

Comments
 (0)