Address Claude Code reviewer comments

- Catch ConfigurationException from sendEmail (was only catching MessagingException)
- Add status="ERROR" to API captcha-failure response for consistency with other response paths
- Remove hardcoded "six characters" from kaptcha instruction text
- Add aria-label to kaptcha input field
- Use method reference in errorsToMessages stream

Co-Authored-By: Claude <noreply@anthropic.com>

Author: vagisha

signup/src/org/labkey/signup/SignUpController.java

@@ -55,6 +55,7 @@
 import org.labkey.api.security.permissions.ReadPermission;
 import org.labkey.api.settings.LookAndFeelProperties;
 import org.labkey.api.util.ButtonBuilder;
+import org.labkey.api.util.ConfigurationException;
 import org.labkey.api.util.DOM;
 import org.labkey.api.util.PageFlowUtil;
 import org.labkey.api.util.URLHelper;
@@ -68,6 +69,7 @@
 import org.labkey.api.view.WebPartView;
 import org.springframework.validation.BindException;
 import org.springframework.validation.Errors;
+import org.springframework.validation.ObjectError;
 import org.springframework.web.servlet.ModelAndView;
 
 import java.util.ArrayList;
@@ -699,7 +701,7 @@ private boolean createUserAndSendEmail(SignupForm form, ValidEmail email, Errors
                         SecurityManager.getRegistrationMessage(null, false),
                         email.getEmailAddress(), confirmationUrl);
             }
-            catch (MessagingException e)
+            catch (MessagingException | ConfigurationException e)
             {
                 String systemEmail = LookAndFeelProperties.getInstance(getContainer()).getSystemEmailAddress();
                 errors.reject(ERROR_MSG, "Could not send new user registration email. Please contact your server administrator at " + systemEmail);
@@ -717,7 +719,7 @@ private boolean createUserAndSendEmail(SignupForm form, ValidEmail email, Errors
     private static List<String> errorsToMessages(Errors errors)
     {
         return errors.getAllErrors().stream()
-                .map(e -> e.getDefaultMessage())
+                .map(ObjectError::getDefaultMessage)
                 .toList();
     }
 
@@ -882,6 +884,7 @@ public ApiResponse execute(SignupForm signupForm, BindException errors) throws E
             String kaptchaError = verifyCaptcha(signupForm.getKaptchaText(), signupForm.getEmail());
             if (kaptchaError != null)
             {
+                response.put("status", "ERROR");
                 response.put("error_message", List.of(kaptchaError));
                 return response;
             }

signup/src/org/labkey/signup/signupPage.jsp

@@ -18,10 +18,10 @@
 
     <%-- Verification: standalone full-width block --%>
     <div style="margin-top:20px;"><strong>Verification</strong></div>
-    <p style="margin:8px 0 4px 0;">Please enter the six characters shown below (case-insensitive).</p>
+    <p style="margin:8px 0 4px 0;">Please enter the characters shown below (case-insensitive).</p>
     <p style="margin:0 0 8px 0;"><a id="kaptchaReload" href="#">Get a new image.</a></p>
     <img id="kaptchaImg" src="<%=h(contextPath)%>/kaptcha.jpg" alt="Captcha" width="200" height="50" style="border: 1px solid #ccc; display:block; margin-bottom:6px;"/>
-    <input type="text" id="kaptchaText" name="kaptchaText" style="width:200px;"/>
+    <input type="text" id="kaptchaText" name="kaptchaText" aria-label="Verification code" style="width:200px;"/>
 
     <div style="margin-top:20px; clear:both;">
         <button type="submit" class="btn btn-default labkey-button">Register</button>