Skip to content

Commit 241c9f8

Browse files
checkpoint - migrate to using long/Long to represent any integer ID value (rowId, objectId, etc). (#563)
1 parent 87f0aed commit 241c9f8

21 files changed

Lines changed: 58 additions & 49 deletions

File tree

SkylineToolsStore/src/org/labkey/skylinetoolsstore/view/SkylineToolsStoreWebPart.jsp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<%@ page import="java.util.Iterator" %>
2121
<%@ page import="java.util.List" %>
2222
<%@ page import="java.util.Map" %>
23+
<%@ page import="org.labkey.api.collections.IntHashMap" %>
2324
<%@ page extends="org.labkey.api.jsp.JspBase" %>
2425

2526
<%!
@@ -237,7 +238,7 @@
237238

238239
<div id="all-tools" style="clear: both; padding-top: 2px;">
239240
<%
240-
HashMap<Integer, String> toolOwners = new HashMap<>();
241+
HashMap<Integer, String> toolOwners = new IntHashMap<>();
241242
for (SkylineTool tool : tools)
242243
{
243244
final String tableId = "table-" + tool.getName().replaceAll("[^A-Za-z0-9]", "");

lincs/src/org/labkey/lincs/DocImportListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public void onDocumentImport(Container container, User user, ITargetedMSRun skyl
137137
return;
138138
}
139139

140-
int jobId = PipelineService.get().getJobId(user, container, job.getJobGUID());
140+
long jobId = PipelineService.get().getJobId(user, container, job.getJobGUID());
141141
_log.info("LINCS: Queued job Id " + jobId +" for creating GCT files for " + skylineRun.getFileName() + ". Container: " + container.getPath());
142142

143143
pspJob.setPipelineJobId(jobId);

lincs/src/org/labkey/lincs/LincsController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1555,7 +1555,7 @@ public boolean handlePost(LincsPspJobForm form, BindException errors)
15551555
return false;
15561556
}
15571557

1558-
int jobId = PipelineService.get().getJobId(getUser(), container, job.getJobGUID());
1558+
long jobId = PipelineService.get().getJobId(getUser(), container, job.getJobGUID());
15591559
newPspJob.setPipelineJobId(jobId);
15601560
lincsManager.updatePipelineJobId(newPspJob);
15611561
return true;

lincs/src/org/labkey/lincs/psp/LincsPspJob.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class LincsPspJob
99
private int id;
1010
private long _runId;
1111
private Container _container;
12-
private Integer _pipelineJobId;
12+
private Long _pipelineJobId;
1313

1414
private String _pspJobId;
1515
private String pspJobName;
@@ -59,12 +59,12 @@ public void setContainer(Container container)
5959
_container = container;
6060
}
6161

62-
public Integer getPipelineJobId()
62+
public Long getPipelineJobId()
6363
{
6464
return _pipelineJobId;
6565
}
6666

67-
public void setPipelineJobId(Integer pipelineJobId)
67+
public void setPipelineJobId(Long pipelineJobId)
6868
{
6969
_pipelineJobId = pipelineJobId;
7070
}

lincs/src/org/labkey/lincs/psp/LincsPspTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ private void postToPsp(LincsPspJobSupport jobSupport, User user, Logger log) thr
8181

8282
if(pspJob.getPipelineJobId() == null)
8383
{
84-
Integer pipelineJobId = (PipelineService.get().getJobId(getJob().getUser(), getJob().getContainer(), getJob().getJobGUID()));
84+
Long pipelineJobId = (PipelineService.get().getJobId(getJob().getUser(), getJob().getContainer(), getJob().getJobGUID()));
8585
pspJob.setPipelineJobId(pipelineJobId);
8686
}
8787

nextflow/src/org/labkey/nextflow/NextFlowManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ private DbSchema getDbSchema()
174174
return DbSchema.get(SCHEMA_NAME, DbSchemaType.Module);
175175
}
176176

177-
private Integer getJobId(NextFlowPipelineJob job)
177+
private Long getJobId(NextFlowPipelineJob job)
178178
{
179179
PipelineStatusFile file = PipelineService.get().getStatusFile(job.getJobGUID());
180180
return file == null ? null : file.getRowId();
@@ -185,15 +185,15 @@ public int getInvocationCount(NextFlowPipelineJob job)
185185
return getInvocationCount(getJobId(job));
186186
}
187187

188-
private int getInvocationCount(int jobId)
188+
private int getInvocationCount(long jobId)
189189
{
190190
Integer result = new SqlSelector(getDbSchema(), new SQLFragment("SELECT InvocationCount FROM nextflow.Job WHERE JobId = ?", jobId)).getObject(Integer.class);
191191
return result != null ? result.intValue() : 0;
192192
}
193193

194194
public int incrementInvocationCount(NextFlowPipelineJob job)
195195
{
196-
int jobId = getJobId(job);
196+
long jobId = getJobId(job);
197197
int current = getInvocationCount(jobId);
198198
current++;
199199
if (current == 1)

panoramapublic/src/org/labkey/panoramapublic/PanoramaPublicController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3417,7 +3417,7 @@ private DataValidation submitValidationJob(@NotNull ExperimentAnnotations experi
34173417
validation = DataValidationManager.saveDataValidation(validation, user);
34183418
PxDataValidationPipelineJob job = new PxDataValidationPipelineJob(info, root, experimentAnnotations, validation.getId());
34193419
PipelineService.get().queueJob(job);
3420-
Integer jobId = PipelineService.get().getJobId(user, container, job.getJobGUID());
3420+
Long jobId = PipelineService.get().getJobId(user, container, job.getJobGUID());
34213421
if (jobId == null)
34223422
{
34233423
errors.reject(ERROR_MSG, "Data validation job was not submitted for experiment Id: " + experimentAnnotations.getId());
@@ -3488,7 +3488,7 @@ public ModelAndView getView(PxDataValidationForm form, BindException errors)
34883488
return new SimpleErrorView(errors, false);
34893489
}
34903490

3491-
int jobId = validation.getJobId();
3491+
long jobId = validation.getJobId();
34923492
PipelineStatusFile pipelineJobStatus = PipelineService.get().getStatusFile(jobId);
34933493
JournalSubmission js = SubmissionManager.getNewestJournalSubmission(_experimentAnnotations);
34943494
JspView view;
@@ -3586,7 +3586,7 @@ public Object execute(PxDataValidationForm form, BindException errors) throws Ex
35863586
DataValidation validation = DataValidationManager.getValidation(form.getValidationId(), getContainer());
35873587
if (validation != null)
35883588
{
3589-
int jobId = validation.getJobId();
3589+
long jobId = validation.getJobId();
35903590
PipelineStatusFile status = PipelineService.get().getStatusFile(jobId);
35913591
if (status != null)
35923592
{
@@ -5810,7 +5810,7 @@ public boolean handlePost(NewExperimentAnnotationsForm form, BindException error
58105810

58115811
// Add all runs in the folder
58125812
List<? extends ExpRun> runsInFolder = ExperimentService.get().getExpRuns(getContainer(), null, null);
5813-
int[] runIds = new int[runsInFolder.size()];
5813+
long[] runIds = new long[runsInFolder.size()];
58145814
int i = 0;
58155815
for(ExpRun run: runsInFolder)
58165816
{

panoramapublic/src/org/labkey/panoramapublic/PanoramaPublicMetadataImporter.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.labkey.panoramapublic;
22

3+
import org.apache.commons.lang3.ArrayUtils;
34
import org.apache.logging.log4j.Logger;
45
import org.jetbrains.annotations.Nullable;
56
import org.labkey.api.admin.AbstractFolderImportFactory;
@@ -98,7 +99,7 @@ else if (experiments.size() > 1)
9899
ExperimentAnnotations targetExperiment = createNewExperimentAnnotations(experiment, sourceExperiment, user, log);
99100

100101
// Get a list of all the ExpRuns imported to subfolders of this folder.
101-
int[] runRowIdsInSubfolders = getAllExpRunRowIdsInSubfolders(container);
102+
long[] runRowIdsInSubfolders = getAllExpRunRowIdsInSubfolders(container);
102103
if (runRowIdsInSubfolders.length > 0)
103104
{
104105
// The folder export and import process, creates a new experiment in exp.experiment.
@@ -119,11 +120,11 @@ else if (experiments.size() > 1)
119120
}
120121
}
121122

122-
private static int[] getAllExpRunRowIdsInSubfolders(Container container)
123+
private static long[] getAllExpRunRowIdsInSubfolders(Container container)
123124
{
124125
Set<Container> children = ContainerManager.getAllChildren(container);
125126
ExperimentService expService = ExperimentService.get();
126-
List<Integer> expRunRowIds = new ArrayList<>();
127+
List<Long> expRunRowIds = new ArrayList<>();
127128
for(Container child: children)
128129
{
129130
if(container.equals(child))
@@ -136,7 +137,7 @@ private static int[] getAllExpRunRowIdsInSubfolders(Container container)
136137
expRunRowIds.add(run.getRowId());
137138
}
138139
}
139-
int[] intIds = new int[expRunRowIds.size()];
140+
long[] intIds = new long[expRunRowIds.size()];
140141
for(int i = 0; i < expRunRowIds.size(); i++)
141142
{
142143
intIds[i] = expRunRowIds.get(i);

panoramapublic/src/org/labkey/panoramapublic/model/ExperimentAnnotations.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
*/
5050
public class ExperimentAnnotations extends DbEntity
5151
{
52-
private int _experimentId;
52+
private long _experimentId;
5353
private Container _container;
5454
private String _title;
5555
private String _experimentDescription;
@@ -83,12 +83,12 @@ public class ExperimentAnnotations extends DbEntity
8383

8484
public ExperimentAnnotations() {}
8585

86-
public int getExperimentId()
86+
public long getExperimentId()
8787
{
8888
return _experimentId;
8989
}
9090

91-
public void setExperimentId(int experimentId)
91+
public void setExperimentId(long experimentId)
9292
{
9393
_experimentId = experimentId;
9494
}

panoramapublic/src/org/labkey/panoramapublic/model/validation/DataValidation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class DataValidation extends DbEntity
1515
private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("yyyy-MM-d HH:mm");
1616

1717
private int _experimentAnnotationsId;
18-
private int _jobId;
18+
private long _jobId;
1919
private PxStatus _status;
2020

2121
public DataValidation() {}
@@ -35,12 +35,12 @@ public void setExperimentAnnotationsId(int experimentAnnotationsId)
3535
_experimentAnnotationsId = experimentAnnotationsId;
3636
}
3737

38-
public int getJobId()
38+
public long getJobId()
3939
{
4040
return _jobId;
4141
}
4242

43-
public void setJobId(int jobId)
43+
public void setJobId(long jobId)
4444
{
4545
_jobId = jobId;
4646
}

0 commit comments

Comments
 (0)