Skip to content

Commit 1415644

Browse files
committed
Revert "scheduled charging: handle concurrent plans (openWB#2458)"
This reverts commit 7a97d9b.
1 parent 181198a commit 1415644

2 files changed

Lines changed: 7 additions & 16 deletions

File tree

packages/control/ev/charge_template.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,7 @@ def scheduled_charging_recent_plan(self,
326326
f"oder im Plan {p.name} als Begrenzung Energie einstellen.")
327327
try:
328328
if ((p.limit.selected == "amount" and used_amount >= p.limit.amount) or
329-
((p.limit.selected == "soc" and soc >= p.limit.soc_scheduled) and
330-
(p.limit.selected == "soc" and soc >= p.limit.soc_limit))):
329+
(p.limit.selected == "soc" and soc >= p.limit.soc_scheduled)):
331330
plan_fulfilled = True
332331
else:
333332
plan_fulfilled = False

packages/control/ev/charge_template_test.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -209,38 +209,30 @@ def test_scheduled_charging_recent_plan(end_time_mock,
209209
if selected_plan:
210210
assert selected_plan.plan.id == expected_plan_num
211211
else:
212-
assert selected_plan is None
212+
selected_plan = None
213213

214214

215-
@pytest.mark.parametrize("end_time_mock, expected_plan_num",
216-
[
217-
pytest.param([-10000, 1500, 2000], 0, id="1st plan"),
218-
pytest.param([None, -100, 2000], 1, id="1st plan fulfilled, 2nd plan"),
219-
pytest.param([None, -50, -100], 2, id="1st plan fulfilled, 3rd plan"),
220-
pytest.param([None]*3, None, id="no plan"),
221-
])
222-
def test_scheduled_charging_recent_plan_fulfilled(end_time_mock, expected_plan_num, monkeypatch):
215+
def test_scheduled_charging_recent_plan_fulfilled(monkeypatch):
223216
# setup
224217
# der erste PLan ist erfüllt, der zweite wird ausgewählt
225218
calculate_duration_mock = Mock(return_value=(100, 3000, 3, 500))
226219
monkeypatch.setattr(ChargeTemplate, "_calc_remaining_time", calculate_duration_mock)
227-
check_end_time_mock = Mock(side_effect=end_time_mock)
220+
check_end_time_mock = Mock(side_effect=[None, 1500])
228221
monkeypatch.setattr(timecheck, "check_end_time", check_end_time_mock)
229222
ct = ChargeTemplate()
230223
plan_mock_0 = Mock(spec=ScheduledChargingPlan, active=True, current=14, id=0, limit=Limit(selected="amount"))
231224
plan_mock_1 = Mock(spec=ScheduledChargingPlan, active=True, current=14, id=1, limit=Limit(selected="amount"))
232-
plan_mock_2 = Mock(spec=ScheduledChargingPlan, active=True, current=14, id=2, limit=Limit(selected="amount"))
233-
ct.data.chargemode.scheduled_charging.plans = {"0": plan_mock_0, "1": plan_mock_1, "2": plan_mock_2}
225+
ct.data.chargemode.scheduled_charging.plans = {"0": plan_mock_0, "1": plan_mock_1}
234226

235227
# execution
236228
selected_plan = ct.scheduled_charging_recent_plan(
237229
60, EvTemplate(), 3, 1200, 3, True, ChargingType.AC.value, 1652688000, Mock(spec=ControlParameter))
238230

239231
# evaluation
240232
if selected_plan:
241-
assert selected_plan.plan.id == expected_plan_num
233+
assert selected_plan.plan.id == 1
242234
else:
243-
assert selected_plan is expected_plan_num
235+
selected_plan = None
244236

245237

246238
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)