From 6987c9dc09a0f2399cc94b502ef0a7f83433e809 Mon Sep 17 00:00:00 2001 From: William Allen Date: Wed, 13 May 2026 19:00:07 -0400 Subject: [PATCH] Fix flaky project settings test measurements test --- tests/Browser/Pages/ProjectSettingsPageTest.php | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/Browser/Pages/ProjectSettingsPageTest.php b/tests/Browser/Pages/ProjectSettingsPageTest.php index 420f0cdf03..c0aff7e02e 100644 --- a/tests/Browser/Pages/ProjectSettingsPageTest.php +++ b/tests/Browser/Pages/ProjectSettingsPageTest.php @@ -257,7 +257,8 @@ public function testCanCreateAndDeleteIntegrations(): void ->waitFor('@integrations-tab-link') ->click('@integrations-tab-link') ->whenAvailable('@integrations-tab', function (Browser $browser) use ($branch, $password, $username, $url): void { - $browser->assertButtonDisabled('@create-repository-button') + $browser->waitForText('No integrations configured yet.') + ->assertButtonDisabled('@create-repository-button') ->type('@repository-url-input', $url) ->type('@repository-username-input', $username) ->type('@repository-password-input', $password) @@ -274,8 +275,8 @@ public function testCanCreateAndDeleteIntegrations(): void ->waitFor('@integrations-tab-link') ->click('@integrations-tab-link') ->whenAvailable('@integrations-tab', function (Browser $browser) use ($branch, $username, $url): void { - $browser->assertButtonDisabled('@create-repository-button') - ->waitForText($url) + $browser->waitForText($url) + ->assertButtonDisabled('@create-repository-button') ->assertSee($username) ->assertSee($branch) ->click('@delete-repository-button') @@ -289,7 +290,8 @@ public function testCanCreateAndDeleteIntegrations(): void ->waitFor('@integrations-tab-link') ->click('@integrations-tab-link') ->whenAvailable('@integrations-tab', function (Browser $browser) use ($branch, $username, $url): void { - $browser->assertButtonDisabled('@create-repository-button') + $browser->waitForText('No integrations configured yet.') + ->assertButtonDisabled('@create-repository-button') ->assertDontSee($url) ->assertDontSee($username) ->assertDontSee($branch) @@ -321,13 +323,15 @@ public function testCanManageTestMeasurements(): void ->assertSee($m2) ->click('@delete-test-measurement-button') ->waitUntilMissingText($m1) + ->waitForText($m2) ->assertSee($m2); }) ->refresh() ->waitFor('@test-measurements-tab-link') ->click('@test-measurements-tab-link') ->whenAvailable('@test-measurements-tab', function (Browser $browser) use ($m1, $m2): void { - $browser->assertSee($m2) + $browser->waitForText($m2) + ->assertSee($m2) ->assertDontSee($m1); }); });