Invalid pointers no longer throw.

Author: Jmangles

Runtime/Scripts/Interactivity/Playback/BehaviourEngine.cs

@@ -103,15 +103,14 @@ public bool TryGetPointer(string pointerString, BehaviourEngineNode engineNode,
             try
             {
                 pointer = pointerResolver.GetPointer(pointerString, engineNode);
-                return true;
             }
             catch (Exception ex)
             {
-                Debug.LogWarning(ex);
+                Debug.LogException(ex); // Feeding in a really malformed pointerString could throw maybe?
 
-                pointer = default;
-                return false;
+                pointer = PointerHelpers.InvalidPointer();
             }
+            return !pointer.invalid;
         }
 
         public void SetAnimationWrapper(GLTFInteractivityAnimationWrapper wrapper, Animation animation)

Runtime/Scripts/Interactivity/Playback/Data/Helpers/Pointers.cs

@@ -4,10 +4,18 @@
 using Unity.Mathematics;
 using UnityEngine;
 
-namespace UnityGLTF.Interactivity.Playback.Materials
+namespace UnityGLTF.Interactivity.Playback
 {
     public static class PointerHelpers
     {
+        public static Pointer<int> InvalidPointer()
+        {
+            return new Pointer<int>()
+            {
+                invalid = true
+            };
+        }
+
         public static Pointer<T> CreatePointer<T>(Action<T> setter, Func<T> getter, Func<T, T, float, T> evaluator)
         {
             return new Pointer<T>()

Runtime/Scripts/Interactivity/Playback/Pointers/ActiveCameraPointers.cs

@@ -45,7 +45,7 @@ public IPointer ProcessActiveCameraPointer(StringSpanReader reader)
             {
                 var a when a.Is("translation") => translation,
                 var a when a.Is("rotation") => rotation,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }

Runtime/Scripts/Interactivity/Playback/Pointers/AnimationPointers.cs

@@ -25,7 +25,8 @@ public static IPointer ProcessPointer(StringSpanReader reader, BehaviourEngineNo
         {
             reader.AdvanceToNextToken('/');
 
-            var nodeIndex = PointerResolver.GetIndexFromArgument(reader, engineNode);
+            if (!PointerResolver.TryGetIndexFromArgument(reader, engineNode, pointers, out int nodeIndex))
+                return PointerHelpers.InvalidPointer();
 
             var pointer = pointers[nodeIndex];
 
@@ -41,7 +42,7 @@ var a when a.Is(Pointers.MIN_TIME) => pointer.minTime,
                 var a when a.Is(Pointers.MAX_TIME) => pointer.maxTime,
                 var a when a.Is(Pointers.PLAYHEAD) => pointer.playhead,
                 var a when a.Is(Pointers.VIRTUAL_PLAYHEAD) => pointer.virtualPlayhead,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }

Runtime/Scripts/Interactivity/Playback/Pointers/CameraPointers.cs

@@ -69,7 +69,8 @@ public static IPointer ProcessCameraPointer(StringSpanReader reader, BehaviourEn
         {
             reader.AdvanceToNextToken('/');
 
-            var nodeIndex = PointerResolver.GetIndexFromArgument(reader, engineNode);
+            if (!PointerResolver.TryGetIndexFromArgument(reader, engineNode, pointers, out int nodeIndex))
+                return PointerHelpers.InvalidPointer();
 
             var pointer = pointers[nodeIndex];
 
@@ -80,7 +81,7 @@ public static IPointer ProcessCameraPointer(StringSpanReader reader, BehaviourEn
             {
                 var a when a.Is("orthographic") => ProcessOrthographicPointer(reader, pointer),
                 var a when a.Is("perspective") => ProcessPerspectivePointer(reader, pointer),
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
 
@@ -95,7 +96,7 @@ var a when a.Is("aspectRatio") => pointer.perspectiveAspectRatio,
                 var a when a.Is("yfov") => pointer.perspectiveYFov,
                 var a when a.Is("zfar") => pointer.zFar,
                 var a when a.Is("znear") => pointer.zNear,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
 
@@ -110,7 +111,7 @@ var a when a.Is("xmag") => pointer.orthographicXMag,
                 var a when a.Is("ymag") => pointer.orthographicYMag,
                 var a when a.Is("zfar") => pointer.zFar,
                 var a when a.Is("znear") => pointer.zNear,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }

Runtime/Scripts/Interactivity/Playback/Pointers/Materials/BaseColor.cs

@@ -41,7 +41,7 @@ public static IPointer ProcessExtensionsPointer(StringSpanReader reader, BaseCol
                 var a when a.Is("offset") => pointers.transformPointers.offset,
                 var a when a.Is("rotation") => pointers.transformPointers.rotation,
                 var a when a.Is("scale") => pointers.transformPointers.scale,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }

Runtime/Scripts/Interactivity/Playback/Pointers/Materials/Clearcoat.cs

@@ -42,7 +42,7 @@ var a when a.Is("clearcoatRoughnessTexture") => ClearcoatRoughnessPointers.Proce
                 // TODO: This property is not mentioned anywhere in the PBRGraph UnityGLTF shader so I didn't include it.
                 //var a when a.Is("clearcoatNormalTexture") => ,
 
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
 
@@ -58,7 +58,7 @@ public static IPointer ProcessExtensionsPointer(StringSpanReader reader, Clearco
                 var a when a.Is("offset") => pointers.transformPointers.offset,
                 var a when a.Is("rotation") => pointers.transformPointers.rotation,
                 var a when a.Is("scale") => pointers.transformPointers.scale,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }

Runtime/Scripts/Interactivity/Playback/Pointers/Materials/ClearcoatRoughness.cs

@@ -39,7 +39,7 @@ public static IPointer ProcessExtensionsPointer(StringSpanReader reader, Clearco
                 var a when a.Is("offset") => pointers.transformPointers.offset,
                 var a when a.Is("rotation") => pointers.transformPointers.rotation,
                 var a when a.Is("scale") => pointers.transformPointers.scale,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }

Runtime/Scripts/Interactivity/Playback/Pointers/Materials/Emissive.cs

@@ -39,7 +39,7 @@ public static IPointer ProcessExtensionsPointer(StringSpanReader reader, Emissiv
                 var a when a.Is("offset") => pointers.transformPointers.offset,
                 var a when a.Is("rotation") => pointers.transformPointers.rotation,
                 var a when a.Is("scale") => pointers.transformPointers.scale,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }

Runtime/Scripts/Interactivity/Playback/Pointers/Materials/Iridescence.cs

@@ -44,7 +44,7 @@ var a when a.Is("iridescenceThicknessMaximum") => matPointer.iridescenceThicknes
                 var a when a.Is("iridescenceTexture") => ProcessExtensionsPointer(reader, matPointer.iridescencePointers),
                 var a when a.Is("iridescenceThicknessTexture") => IridescenceThicknessPointers.ProcessExtensionsPointer(reader, matPointer.iridescenceThicknessPointers),
 
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
 
@@ -60,7 +60,7 @@ public static IPointer ProcessExtensionsPointer(StringSpanReader reader, Iridesc
                 var a when a.Is("offset") => pointers.transformPointers.offset,
                 var a when a.Is("rotation") => pointers.transformPointers.rotation,
                 var a when a.Is("scale") => pointers.transformPointers.scale,
-                _ => throw new InvalidOperationException($"Property {reader.ToString()} is unsupported at this time!"),
+                _ => PointerHelpers.InvalidPointer(),
             };
         }
     }