요약 및 리뷰 모델 수정

Author: Jwhyee

src/main/kotlin/com/project/codereview/client/util/ReviewModels.kt

@@ -58,17 +58,4 @@ enum class GeminiTextModel(
 //        maxTpm = 1_000_000,
 //        maxRpd = 200
 //    )
-    ;
-
-    fun toRateLimit(): RateLimit = RateLimit(
-        rpm = maxRpm,
-        tpm = maxTpm,
-        rpd = maxRpd
-    )
-}
-
-data class RateLimit(
-    val rpm: Int,
-    val tpm: Int,
-    val rpd: Int
-)
+}

src/main/kotlin/com/project/codereview/core/service/CodeReviewFacade.kt

@@ -3,6 +3,7 @@ package com.project.codereview.core.service
 import com.project.codereview.client.github.GithubDiffClient
 import com.project.codereview.client.github.GithubDiffUtils
 import com.project.codereview.client.github.dto.ReviewContext
+import com.project.codereview.client.util.GeminiTextModel
 import com.project.codereview.core.dto.GithubActionType
 import com.project.codereview.core.dto.GithubEvent
 import com.project.codereview.core.dto.GithubPayload
@@ -17,6 +18,10 @@ class CodeReviewFacade(
     private val githubDiffClient: GithubDiffClient,
     private val codeSummaryService: CodeSummaryService
 ) {
+    companion object {
+        val SUMMARY_MODEL = GeminiTextModel.GEMINI_2_5_FLASH_LITE
+        val REVIEW_MODEL = GeminiTextModel.GEMINI_3_FLASH
+    }
     private val logger = LoggerFactory.getLogger(CodeReviewFacade::class.java)
 
     suspend fun handle(githubEvent: GithubEvent, payload: GithubPayload) = coroutineScope {
@@ -30,7 +35,7 @@ class CodeReviewFacade(
         when (action) {
             GithubActionType.OPENED -> {
                 withPrContexts(pullRequestPayload, payload) { contexts ->
-                    codeSummaryService.summary(payload, contexts)
+                    codeSummaryService.summary(payload, contexts, SUMMARY_MODEL)
                 }
             }
 
@@ -41,7 +46,7 @@ class CodeReviewFacade(
                 }
 
                 withPrContexts(pullRequestPayload, payload) { contexts ->
-                    reviewJobQueue.enqueue(payload, contexts)
+                    reviewJobQueue.enqueue(payload, contexts, REVIEW_MODEL)
                 }
             }
 

src/main/kotlin/com/project/codereview/core/service/CodeReviewService.kt

@@ -44,7 +44,11 @@ class CodeReviewService(
         val path: String get() = ctx.type.path()
     }
 
-    suspend fun review(payload: GithubPayload, contexts: List<ReviewContext>) = coroutineScope {
+    suspend fun review(
+        payload: GithubPayload,
+        contexts: List<ReviewContext>,
+        model: GeminiTextModel
+    ) = coroutineScope {
         val pr = payload.pull_request
 
         val tasks = if (contexts.size > MAX_FILES_TO_REVIEW) {
@@ -61,15 +65,15 @@ class CodeReviewService(
         tasks.mapIndexed { index, task ->
             async {
                 semaphore.withPermit {
-                    processOne(task, index + 1, tasks.size)
+                    processOne(task, model, index + 1, tasks.size)
                 }
             }
         }.awaitAll()
 
         logger.info("[Review Completed] total={}", tasks.size)
     }
 
-    private suspend fun processOne(task: ReviewTask, order: Int, total: Int) {
+    private suspend fun processOne(task: ReviewTask, model: GeminiTextModel, order: Int, total: Int) {
         val path = task.path
         if (path.isBlank()) {
             logger.warn("[Review Skip] Empty file path ({} / {})", order, total)
@@ -84,8 +88,6 @@ class CodeReviewService(
 
         logger.info("[Review Start] file={} ({} / {})", path, order, total)
 
-        val model = GeminiTextModel.GEMINI_2_5_FLASH_LITE
-
         val reviewText = callGeminiOrNull(path, prompt, model) ?: run {
             logger.warn("[Review Failed] Gemini returned null/blank file={} model={}", path, model.modelName)
             return

src/main/kotlin/com/project/codereview/core/service/CodeSummaryService.kt

@@ -17,7 +17,7 @@ class CodeSummaryService(
 ) {
     private val logger = LoggerFactory.getLogger(CodeSummaryService::class.java)
 
-    suspend fun summary(payload: GithubPayload, fileContexts: List<ReviewContext>) {
+    suspend fun summary(payload: GithubPayload, fileContexts: List<ReviewContext>, model: GeminiTextModel) {
         logger.info("[Summary] Making summary ...")
 
         val prompt = fileContexts.buildPrompt()
@@ -26,12 +26,10 @@ class CodeSummaryService(
             return
         }
 
-        val summaryText =
-            generateSummaryOnce(payload, prompt, GeminiTextModel.GEMINI_3_FLASH)
-                ?: generateSummaryOnce(payload, prompt, GeminiTextModel.GEMINI_2_5_FLASH)
+        val summaryText = generateSummaryOnce(payload, prompt, model)
 
         if (summaryText.isNullOrBlank()) {
-            logger.warn("[Summary] Failed with both models. Stop.")
+            logger.warn("[Summary] Failed with ${model.modelName} model. Stop.")
             return
         }
 

src/main/kotlin/com/project/codereview/core/service/ReviewJobQueue.kt

@@ -1,6 +1,7 @@
 package com.project.codereview.core.service
 
 import com.project.codereview.client.github.dto.ReviewContext
+import com.project.codereview.client.util.GeminiTextModel
 import com.project.codereview.core.dto.GithubPayload
 import jakarta.annotation.PostConstruct
 import jakarta.annotation.PreDestroy
@@ -25,7 +26,8 @@ class ReviewJobQueue(
 
     data class ReviewJob(
         val payload: GithubPayload,
-        val contexts: List<ReviewContext>
+        val contexts: List<ReviewContext>,
+        val model: GeminiTextModel
     )
 
     @PostConstruct
@@ -34,7 +36,7 @@ class ReviewJobQueue(
             scope.launch(CoroutineName("review-worker-$idx")) {
                 for (job in channel) {
                     runCatching {
-                        codeReviewService.review(job.payload, job.contexts)
+                        codeReviewService.review(job.payload, job.contexts, job.model)
                     }.onFailure { t ->
                         logger.error(
                             "[ReviewJob] failed worker={} cause={}",
@@ -50,8 +52,8 @@ class ReviewJobQueue(
         logger.info("[ReviewJobQueue] started workers={}", workerCount)
     }
 
-    fun enqueue(payload: GithubPayload, contexts: List<ReviewContext>): Boolean {
-        val res = channel.trySend(ReviewJob(payload, contexts))
+    fun enqueue(payload: GithubPayload, contexts: List<ReviewContext>, model: GeminiTextModel): Boolean {
+        val res = channel.trySend(ReviewJob(payload, contexts, model))
         if (res.isFailure) {
             logger.warn("[ReviewJobQueue] enqueue failed cause={}", res.exceptionOrNull()?.message)
         }