Skip to content

Commit adb32e0

Browse files
committed
impr: removed jquery (close #8)
1 parent 05a107f commit adb32e0

6 files changed

Lines changed: 7 additions & 178 deletions

File tree

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"authors": [
55
"Jonathan Hornung <jonathan.hornung@gmail.com>"
66
],
7-
"version": "0.7.7",
7+
"version": "0.7.8",
88
"description": "GitHub plugin for apiNG",
99
"main": "dist/aping-plugin-github.min.js",
1010
"moduleType": [],

demo/index.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
<meta charset="UTF-8">
55
<title>Github Demo</title>
66

7-
<script src="../bower_components/jquery/dist/jquery.min.js"></script>
87
<script src="../bower_components/angular/angular.min.js"></script>
98
<script src="../bower_components/apiNG/dist/aping.min.js"></script>
109
<script src="aping-config.js"></script>

dist/aping-plugin-github.js

Lines changed: 2 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
@name: aping-plugin-github
3-
@version: 0.7.7 (24-01-2016)
3+
@version: 0.7.8 (28-01-2016)
44
@author: Jonathan Hornung
55
@url: https://github.com/JohnnyTheTank/apiNG-plugin-github
66
@license: MIT
@@ -178,11 +178,6 @@ angular.module("jtt_aping_github")
178178
case "repo":
179179
returnObject = this.getRepoItemByJsonData(_item);
180180
break;
181-
/*
182-
case "activity":
183-
returnObject = this.getActivityItemByJsonData(_item);
184-
break;
185-
*/
186181

187182
default:
188183
return false;
@@ -194,7 +189,7 @@ angular.module("jtt_aping_github")
194189
this.getRepoItemByJsonData = function (_item) {
195190
var repoObject = apingModels.getNew("repo", this.getThisPlatformString());
196191

197-
$.extend(true, repoObject, {
192+
angular.extend(repoObject, {
198193
owner_name: _item.owner ? _item.owner.login : undefined,
199194
owner_id: _item.owner ? _item.owner.id : undefined,
200195
owner_link: _item.owner ? _item.owner.html_url : undefined,
@@ -225,86 +220,6 @@ angular.module("jtt_aping_github")
225220

226221
return repoObject;
227222
};
228-
/*
229-
this.getActivityItemByJsonData = function (_item) {
230-
var activityObject = apingModels.getNew("activity", this.getThisPlatformString());
231-
232-
$.extend(true, activityObject, {
233-
body : undefined,
234-
235-
actor_name : _item.actor ? _item.actor.login : undefined, //who?
236-
actor_id : _item.actor ? _item.actor.id : undefined,
237-
actor_url : _item.actor ? this.getThisPlatformLink()+_item.actor.login : undefined,
238-
actor_img_url : _item.actor ? _item.actor.avatar_url : undefined,
239-
actor_type: undefined,
240-
241-
//action_name : undefined,
242-
//action_message : undefined,
243-
action_id : _item.id,
244-
//action_url : undefined,
245-
//action_img : undefined,
246-
action_type: _item.type,
247-
248-
object_name : _item.repo ? _item.repo.name : undefined,
249-
object_id : _item.repo ? _item.repo.id : undefined,
250-
object_img : undefined,
251-
object_url : _item.repo ? this.getThisPlatformLink()+_item.repo.name : undefined,
252-
object_type: _item.repo ? "repository" : undefined,
253-
254-
//context : undefined,
255-
timestamp : apingTimeHelper.getTimestampFromDateString(_item.created_at, 1000, 3600*1000),
256-
date_time: new Date(_item.created_at),
257-
258-
});
259-
260-
var actionTempObject = this.getActionMessageByTypeAndPayload(_item.type, _item.payload);
261-
262-
activityObject.action_message = actionTempObject.message;
263-
activityObject.action_name = actionTempObject.name;
264-
activityObject.action_url = actionTempObject.url;
265-
266-
return activityObject;
267-
};
268-
269-
this.getActionMessageByTypeAndPayload = function (_type, _payload) {
270-
271-
var returnObject ={
272-
name : undefined,
273-
message : "",
274-
url : undefined,
275-
};
276-
277-
switch(_type) {
278-
case "PushEvent":
279-
280-
returnObject.name = "pushed";
281-
282-
if(_payload.commits && _payload.commits.constructor === Array) {
283-
angular.forEach(_payload.commits, function (value, key) {
284-
if(returnObject.message === "") {
285-
returnObject.message += value.message;
286-
} else {
287-
returnObject.message += "\n"+value.message;
288-
}
289-
});
290-
}
291-
break;
292-
293-
case "PullRequestReviewCommentEvent":
294-
returnObject.name = _payload.action + " pull request review comment";
295-
returnObject.message = _payload.pull_request.title;
296-
returnObject.url = _payload.pull_request.html_url;
297-
298-
break;
299-
}
300-
301-
if(returnObject.message === "") {
302-
returnObject.message = undefined;
303-
}
304-
305-
return returnObject;
306-
};
307-
*/
308223
}]);;"use strict";
309224

310225
angular.module("jtt_github", [])

dist/aping-plugin-github.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "aping-plugin-github",
3-
"version": "0.7.7",
3+
"version": "0.7.8",
44
"description": "GitHub plugin for apiNG",
55
"main": "dist/aping-plugin-github.min.js",
66
"scripts": {

src/aping-github-helper.js

Lines changed: 1 addition & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,6 @@ angular.module("jtt_aping_github")
6767
case "repo":
6868
returnObject = this.getRepoItemByJsonData(_item);
6969
break;
70-
/*
71-
case "activity":
72-
returnObject = this.getActivityItemByJsonData(_item);
73-
break;
74-
*/
7570

7671
default:
7772
return false;
@@ -83,7 +78,7 @@ angular.module("jtt_aping_github")
8378
this.getRepoItemByJsonData = function (_item) {
8479
var repoObject = apingModels.getNew("repo", this.getThisPlatformString());
8580

86-
$.extend(true, repoObject, {
81+
angular.extend(repoObject, {
8782
owner_name: _item.owner ? _item.owner.login : undefined,
8883
owner_id: _item.owner ? _item.owner.id : undefined,
8984
owner_link: _item.owner ? _item.owner.html_url : undefined,
@@ -114,84 +109,4 @@ angular.module("jtt_aping_github")
114109

115110
return repoObject;
116111
};
117-
/*
118-
this.getActivityItemByJsonData = function (_item) {
119-
var activityObject = apingModels.getNew("activity", this.getThisPlatformString());
120-
121-
$.extend(true, activityObject, {
122-
body : undefined,
123-
124-
actor_name : _item.actor ? _item.actor.login : undefined, //who?
125-
actor_id : _item.actor ? _item.actor.id : undefined,
126-
actor_url : _item.actor ? this.getThisPlatformLink()+_item.actor.login : undefined,
127-
actor_img_url : _item.actor ? _item.actor.avatar_url : undefined,
128-
actor_type: undefined,
129-
130-
//action_name : undefined,
131-
//action_message : undefined,
132-
action_id : _item.id,
133-
//action_url : undefined,
134-
//action_img : undefined,
135-
action_type: _item.type,
136-
137-
object_name : _item.repo ? _item.repo.name : undefined,
138-
object_id : _item.repo ? _item.repo.id : undefined,
139-
object_img : undefined,
140-
object_url : _item.repo ? this.getThisPlatformLink()+_item.repo.name : undefined,
141-
object_type: _item.repo ? "repository" : undefined,
142-
143-
//context : undefined,
144-
timestamp : apingTimeHelper.getTimestampFromDateString(_item.created_at, 1000, 3600*1000),
145-
date_time: new Date(_item.created_at),
146-
147-
});
148-
149-
var actionTempObject = this.getActionMessageByTypeAndPayload(_item.type, _item.payload);
150-
151-
activityObject.action_message = actionTempObject.message;
152-
activityObject.action_name = actionTempObject.name;
153-
activityObject.action_url = actionTempObject.url;
154-
155-
return activityObject;
156-
};
157-
158-
this.getActionMessageByTypeAndPayload = function (_type, _payload) {
159-
160-
var returnObject ={
161-
name : undefined,
162-
message : "",
163-
url : undefined,
164-
};
165-
166-
switch(_type) {
167-
case "PushEvent":
168-
169-
returnObject.name = "pushed";
170-
171-
if(_payload.commits && _payload.commits.constructor === Array) {
172-
angular.forEach(_payload.commits, function (value, key) {
173-
if(returnObject.message === "") {
174-
returnObject.message += value.message;
175-
} else {
176-
returnObject.message += "\n"+value.message;
177-
}
178-
});
179-
}
180-
break;
181-
182-
case "PullRequestReviewCommentEvent":
183-
returnObject.name = _payload.action + " pull request review comment";
184-
returnObject.message = _payload.pull_request.title;
185-
returnObject.url = _payload.pull_request.html_url;
186-
187-
break;
188-
}
189-
190-
if(returnObject.message === "") {
191-
returnObject.message = undefined;
192-
}
193-
194-
return returnObject;
195-
};
196-
*/
197112
}]);

0 commit comments

Comments
 (0)