[DBA-295] Migrate validate-agent-guidance from Bash to Python (#79)

* DBA-295 Migrate `validate-agent-guidance` from Bash to Python

* Replace `validate-agent-guidance` script with `make lint-skills` in smoke test

* Update .pre-commit-config.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Address copilot comments

* Redundant copy of Makefile in documentation

* Update scripts/validate_agent_guidance.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* drop autosteer skill from evals

* Update scripts/validate_agent_guidance.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update scripts/validate_agent_guidance.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix ruff-format on validate_agent_guidance.py

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Andrei Gasparian <andrei.gasparian@jetbrains.com>
Co-authored-by: Andrey Gasparyan <gasparian.andrey@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: 5 people

.pre-commit-config.yaml

@@ -36,7 +36,7 @@ repos:
       - id: validate-agent-guidance
         name: validate-agent-guidance
         description: Validate agent skills and guidance docs structure
-        entry: scripts/validate-agent-guidance.sh
-        language: script
+        entry: uv run python scripts/validate_agent_guidance.py
+        language: system
         pass_filenames: false
-        files: ^(\.claude/skills/|docs/(python-coding-guidelines|architecture|testing-strategy)\.md|scripts/validate-agent-guidance\.sh)$
+        files: ^(\.claude/skills/|CLAUDE\.md|docs/(python-coding-guidelines|architecture|testing-strategy)\.md|scripts/validate_agent_guidance\.py)$

Makefile

@@ -32,7 +32,7 @@ nickname:
 	@git config user.email | cut -d@ -f1
 
 lint-skills:
-	scripts/validate-agent-guidance.sh
+	uv run python scripts/validate_agent_guidance.py
 
 smoke-skills:
 	scripts/smoke-test-skills.sh

docs/testing-strategy.md

@@ -41,18 +41,6 @@ Run the smallest relevant slice first, then broaden before finalizing:
 - Add a regression test for every bug fix when feasible.
 - Test files mirror source modules (e.g., `test_init.py` tests `commands/init.py`).
 
-## Make Targets
-
-| Target         | Command                                              | What it does               |
-|----------------|------------------------------------------------------|----------------------------|
-| `make setup`        | `uv sync --dev` + pre-commit + verify                | One-time environment setup        |
-| `make check`        | `uv run pre-commit run --all-files`                  | Ruff lint + mypy                  |
-| `make test`         | `uv run pytest tests/ -v` (sources `.env` if present)| Unit tests                        |
-| `make test-cov`     | `uv run pytest ... --cov`                            | Coverage report (no threshold)    |
-| `make test-cov-check`| `uv run pytest ... --cov` (threshold from `pyproject.toml`)| Coverage enforcement              |
-| `make lint-skills`   | `scripts/validate-agent-guidance.sh`                 | Static checks on agent guidance   |
-| `make smoke-skills`  | `scripts/smoke-test-skills.sh`                       | Functional skill verification     |
-
 ## What Does NOT Run in CI / Pre-commit
 
 Everything above (lint, type-check, unit tests, skill validation) is

scripts/smoke-test-skills.sh

@@ -24,7 +24,7 @@ run_test() {
 }
 
 echo "=== Tier 1: Static validation ==="
-run_test "validate-agent-guidance" "scripts/validate-agent-guidance.sh"
+run_test "validate-agent-guidance" "make lint-skills"
 
 echo ""
 echo "=== Tier 2: Functional smoke tests ==="