feat: can pass in params and update method for MenuItems created with the controller method.

Author: athphane

src/Traits/HasController.php

@@ -2,17 +2,19 @@
 
 namespace Javaabu\MenuBuilder\Traits;
 
-use Illuminate\Database\Eloquent\Model;
-
 trait HasController
 {
     protected ?string $controller = null;
+    protected string $controller_method = 'index';
+    protected array $controller_params = [];
 
-    public function controller(string $controller): self
+    public function controller(string $controller, array $params = [], ?string $controller_method = 'index'): self
     {
         $this->clearLink();
 
         $this->controller = $controller;
+        $this->controller_method = $controller_method;
+        $this->controller_params = $params;
 
         return $this;
     }
@@ -24,7 +26,7 @@ public function getController(): ?string
 
     public function hasController(): bool
     {
-        return ! empty($this->getController());
+        return !empty($this->getController());
     }
 
     protected function checkActiveFromController(): bool
@@ -46,11 +48,16 @@ protected function clearController(): self
 
     protected function generateControllerLink(): string
     {
-        return action([$this->getController(), $this->getControllerMethod()]);
+        return action([$this->getController(), $this->getControllerMethod()], $this->getControllerParams());
+    }
+
+    public function getControllerParams(): array
+    {
+        return $this->controller_params;
     }
 
     protected function getControllerMethod(): string
     {
-        return 'index';
+        return $this->controller_method;
     }
 }

tests/Controllers/HomeController.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Javaabu\MenuBuilder\Tests\Controllers;
+
+class HomeController
+{
+    public function index(string $locale)
+    {
+        return view('locale-index', compact('locale'));
+    }
+}

tests/Controllers/UsersController.php

@@ -3,6 +3,7 @@
 namespace Javaabu\MenuBuilder\Tests\Controllers;
 
 use Javaabu\MenuBuilder\Menu\MenuItem;
+use Javaabu\MenuBuilder\Tests\Models\User;
 
 class UsersController
 {
@@ -13,4 +14,16 @@ public function index()
 
         return view('active-link', compact('active_item', 'inactive_item'));
     }
+
+    public function show($user)
+    {
+        $user = User::find($user);
+
+        return view('user', compact('user'));
+    }
+
+    public function localeIndex(string $locale)
+    {
+        return view('locale-index', compact('locale'));
+    }
 }

tests/Unit/MenuItemTest.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Gate;
+use Javaabu\MenuBuilder\Tests\Controllers\HomeController;
 use Javaabu\MenuBuilder\Tests\Controllers\UsersController;
 use Illuminate\Support\Facades\Route;
 use Javaabu\MenuBuilder\Tests\InteractsWithDatabase;
@@ -174,6 +175,42 @@ public function it_can_set_the_menu_item_controller(): void
         $this->assertEquals('http://localhost/users', $menu_item->getLink());
     }
 
+    /** @test */
+    public function it_can_set_menu_item_from_controller_with_params(): void
+    {
+        Route::get('/users/{user}', [UsersController::class, 'show']);
+
+        $user = User::factory()->create();
+
+        $menu_item = MenuItem::make('Users')
+            ->controller(UsersController::class, compact('user'), 'show');
+
+        $this->assertEquals(UsersController::class, $menu_item->getController());
+        $this->assertEquals('http://localhost/users/1', $menu_item->getLink());
+
+        $this->visit($menu_item->getLink())
+            ->seeText("User: {$user->name}");
+    }
+
+    /** @test */
+    public function it_can_set_menu_item_for_index_method_from_controller_with_params(): void
+    {
+        Route::get('/{locale}/users', [HomeController::class, 'index']);
+
+        $menu_item = MenuItem::make('Users')
+            ->controller(
+                HomeController::class,
+                ['locale' => 'jp'],
+                'index'
+            );
+
+        $this->assertEquals(HomeController::class, $menu_item->getController());
+        $this->assertEquals('http://localhost/jp/users', $menu_item->getLink());
+
+        $this->visit($menu_item->getLink())
+            ->seeText("Locale: jp");
+    }
+
     /** @test */
     public function it_can_determine_active_state_from_controller(): void
     {

tests/views/locale-index.blade.php

@@ -0,0 +1 @@
+Locale: {{ $locale }}

tests/views/user.blade.php

@@ -0,0 +1 @@
+User: {{ $user->name }}