Skip to content

Commit 33c28b6

Browse files
author
bytekeeper
committed
#13 - Added some "protection" to the Array.asList usages.
1 parent 3223415 commit 33c28b6

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/main/java/bwapi/TechType.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package bwapi;
22

33
import java.util.Arrays;
4+
import java.util.Collections;
45
import java.util.List;
56

67
import static bwapi.Order.*;
@@ -223,7 +224,7 @@ public boolean targetsPosition() {
223224
}
224225

225226
public List<UnitType> whatsUses() {
226-
return Arrays.asList(techWhatUses[id]);
227+
return Collections.unmodifiableList(Arrays.asList(techWhatUses[id]));
227228
}
228229

229230
public Order getOrder() {

src/main/java/bwapi/UnitType.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -305,11 +305,11 @@ public TechType cloakingTech() {
305305
}
306306

307307
public List<TechType> abilities() {
308-
return Arrays.asList(UnitTypeContainer.unitTechs[id]);
308+
return Collections.unmodifiableList(Arrays.asList(UnitTypeContainer.unitTechs[id]));
309309
}
310310

311311
public List<UpgradeType> upgrades() {
312-
return Arrays.asList(UnitTypeContainer.upgrades[id]);
312+
return Collections.unmodifiableList(Arrays.asList(UnitTypeContainer.upgrades[id]));
313313
}
314314

315315
public UpgradeType armorUpgrade() {
@@ -644,15 +644,15 @@ public boolean canBuildAddon() {
644644
}
645645

646646
public List<UnitType> buildsWhat() {
647-
return Arrays.asList(UnitTypeContainer.buildsWhat[id]);
647+
return Collections.unmodifiableList(Arrays.asList(UnitTypeContainer.buildsWhat[id]));
648648
}
649649

650650
public List<TechType> researchesWhat() {
651-
return Arrays.asList(UnitTypeContainer.researchesWhat[id]);
651+
return Collections.unmodifiableList(Arrays.asList(UnitTypeContainer.researchesWhat[id]));
652652
}
653653

654654
public List<UpgradeType> upgradesWhat() {
655-
return Arrays.asList(UnitTypeContainer.upgradesWhat[id]);
655+
return Collections.unmodifiableList(Arrays.asList(UnitTypeContainer.upgradesWhat[id]));
656656
}
657657

658658
public boolean isSuccessorOf(final UnitType type) {

src/main/java/bwapi/UpgradeType.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package bwapi;
22

33
import java.util.Arrays;
4+
import java.util.Collections;
45
import java.util.List;
56

67
public enum UpgradeType {
@@ -252,7 +253,7 @@ public UnitType whatUpgrades() {
252253
}
253254

254255
public List<UnitType> whatUses() {
255-
return Arrays.asList(upgradeWhatUses[id]);
256+
return Collections.unmodifiableList(Arrays.asList(upgradeWhatUses[id]));
256257
}
257258

258259
public int maxRepeats() {

0 commit comments

Comments
 (0)