Skip to content

Commit 4541422

Browse files
committed
chore: reduce mark skipped
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent f36b6b6 commit 4541422

2 files changed

Lines changed: 15 additions & 6 deletions

File tree

src/Sign/JSignService.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ private function commandSign(JSignParam $params)
120120
list ($pdf, $certificate) = $this->storeTempFiles($params);
121121
$java = $this->javaCommand($params);
122122
$jSignPdf = $this->getjSignPdfJarPath($params);
123-
$this->throwIf(!file_exists($jSignPdf), 'Jar of JSignPDF not found on path: '. $jSignPdf);
124123

125124
$password = escapeshellarg($params->getPassword());
126125
return "$java -Duser.language=en -jar $jSignPdf $pdf -ksf $certificate -ksp {$password} {$params->getJSignParameters()} -d {$params->getPathPdfSigned()} 2>&1";

tests/JSignPDFTest.php

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,23 @@ private function getNewCert($password)
6868

6969
public function testSignSuccess()
7070
{
71-
if (!class_exists('JSignPDF\JSignPDFBin\JavaCommandService')) {
72-
$this->markTestSkipped('Install jsignpdf/jsignpdf-bin');
73-
}
71+
global $mockExec;
72+
$mockExec = ['Finished: Signature succesfully created.'];
7473
$params = JSignParamBuilder::instance()->withDefault();
74+
vfsStream::setup('download');
75+
mkdir('vfs://download/bin');
76+
touch('vfs://download/bin/java');
77+
chmod('vfs://download/bin/java', 0755);
78+
$params->setJavaPath('vfs://download/bin/java');
79+
$params->setJavaDownloadUrl('');
80+
$params->setjSignPdfJarPath('faje_path');
81+
$params->setJSignPdfDownloadUrl('');
7582
$params->setCertificate($this->getNewCert($params->getPassword()));
76-
$fileSigned = $this->service->sign($params);
77-
$this->assertNotNull($fileSigned);
83+
$params->setPathPdfSigned('vfs://download/temp');
84+
$signedFilePath = $params->getTempPdfSignedPath();
85+
file_put_contents($signedFilePath, 'signed file content');
86+
$fileSignedContent = $this->service->sign($params);
87+
$this->assertEquals('signed file content', $fileSignedContent);
7888
}
7989

8090
#[DataProvider('providerSignUsingDifferentPasswords')]

0 commit comments

Comments
 (0)