Changes to getInterfaceType getMotherBoardName and getPartitionId

Signed-off-by: Avinash Niyas <avinashNiyaz1423@gmail.com>

Author: Avinash1423

src/jdiskmark/App.java

@@ -674,17 +674,17 @@ static public String getDriveInfo() {
         if (locationDir == null) {
             return LOCATION_NOT_SELECTED_ERROR;
         }
-        String interFaceType=Util.getInterfaceType();
         String driveModel = Util.getDriveModel(locationDir);
         String partitionId = Util.getPartitionId(locationDir.toPath());
+        String interFaceType=Util.getInterfaceType(partitionId);
         DiskUsageInfo usageInfo;
         try {
             usageInfo = Util.getDiskUsage(locationDir.toString());
         } catch (IOException | InterruptedException ex) {
             usageInfo = new DiskUsageInfo();
             Logger.getLogger(App.class.getName()).log(Level.SEVERE, null, ex);
         }
-        return interFaceType + " - " + driveModel + " - " + partitionId + ": " + usageInfo.getUsageTitleDisplay();
+        return  driveModel + " - " + interFaceType + " - " + partitionId + ": " + usageInfo.getUsageTitleDisplay();
     }
 
     static public String getDriveModel() {

src/jdiskmark/MainFrame.java

@@ -72,7 +72,7 @@ public MainFrame() {
         }
 
         if (App.motherBoardName != null && !App.motherBoardName.isEmpty()) {
-            titleSb.append(" | ").append(App.motherBoardName);
+            titleSb.append(" - ").append(App.motherBoardName);
         }
 
         // permission indicator

src/jdiskmark/Util.java

@@ -245,16 +245,29 @@ public static DiskUsageInfo getDiskUsage(String diskPath) throws IOException, In
     }
 
     public static String getPartitionId(Path path) {
-        if (System.getProperty("os.name").startsWith("Windows")) {
-            String driveLetter = UtilOs.getDriveLetterWindows(path);
-            return driveLetter;
-        } else {
+
+        String os=System.getProperty("os.name");
+
+        if (os.startsWith("Windows")) {
+           return UtilOs.getDriveLetterWindows(path);
+        }
+        if (os.startsWith("Mac")) {
+            String partitionPath=UtilOs.getDeviceFromPathMacOs(path);
+            if(partitionPath.startsWith("/dev/")){
+               return partitionPath.substring("/dev/".length());
+            }
+            return partitionPath;
+        }
+
+        else if (os.startsWith("Linux"))  {
             String partitionPath = UtilOs.getPartitionFromFilePathLinux(path);
             if (partitionPath.contains("/dev/")) {
                 return partitionPath.split("/dev/")[1];
             }
             return partitionPath;
         }
+
+        return "Os Not Found";
     }
 
     public static String getJvmInfo() {
@@ -276,6 +289,39 @@ public static String getProcessorName() {
         return "processor name unknown";
     }
 
+    /**
+     * Get the motherboard / baseboard name of the current system.
+     *
+     * This method executes OS-specific system commands to retrieve
+     * motherboard identification information.
+     *
+     * Commands used:
+     *
+     * Windows:
+     *   wmic baseboard get Product
+     *
+     *   Example output:
+     *     Product
+     *     B450M PRO-VDH MAX
+     *
+     * Linux:
+     *   cat /sys/devices/virtual/dmi/id/board_name
+     *
+     *   Example output:
+     *     B450M PRO-VDH MAX
+     *
+     * macOS:
+     *   system_profiler SPHardwareDataType
+     *
+     *   Example output snippet:
+     *     Model Identifier: MacBookPro15,2
+     *
+     * Note:
+     * - macOS does not expose a direct motherboard name.
+     * - For macOS, the "Model Identifier" is returned instead.
+     *
+     * @return motherboard name as a String, or null if unavailable
+     */
     public static String getMotherBoardName() {
 
         Process process = null;
@@ -304,6 +350,16 @@ public static String getMotherBoardName() {
             String line;
 
             while ((line = reader.readLine()) != null) {
+
+                line=line.trim();
+
+                // If OS is mac return Model Identifier as MotherBoard name is not explicitly provided
+                if (line.startsWith("Model Identifier:")) {
+
+                    return line.split(":",2)[1].trim();
+                }
+
+                if (line.equalsIgnoreCase("Product")) { continue;}
                 builder.append(line).append(" ");
             }
 
@@ -316,16 +372,54 @@ public static String getMotherBoardName() {
         }
     }
 
-    public static String getInterfaceType(){
+    /**
+     * Get the physical interface (bus / transport) type of a disk or partition.
+     *
+     * This method determines the underlying storage interface (e.g. SATA, NVMe,
+     * USB) by executing OS-specific system commands and parsing their output.
+     *
+     * Commands used:
+     *
+     * Windows:
+     *   powershell -Command
+     *   Get-Partition -DriveLetter <partitionId> | Get-Disk | Select -Expand BusType
+     *
+     *   Example output:
+     *     SATA
+     *     NVMe
+     *     USB
+     *
+     * Linux:
+     *   lsblk -d -o TRAN /dev/<partitionId>
+     *
+     *   Example output:
+     *     TRAN
+     *     sata
+     *
+     * macOS:
+     *   diskutil info <partitionId>
+     *
+     *   Example output snippet:
+     *     Protocol: SATA
+     *
+     * Notes:
+     * - On Windows, the BusType field is returned.
+     * - On Linux, the TRAN (transport) column is used.
+     * - On macOS, the interface type is parsed from the "Protocol" field.
+     *
+     * @param partitionId drive letter (Windows) or device identifier (Linux/macOS)
+     * @return interface type as a String, or "OS not supported" if unavailable
+     */
+    public static String getInterfaceType(String partitionId){
         Process process = null;
 
         try {
             if (App.os.startsWith("Windows")) {
-                process = new ProcessBuilder("wmic", "diskdrive", "get", "InterfaceType").start();
+                process = new ProcessBuilder( "powershell", "-Command", "Get-Partition -DriveLetter " +  partitionId + " | Get-Disk | Select -Expand BusType").start();
             } else if (App.os.contains("Linux")) {
-                process = new ProcessBuilder("lsblk", "-d", "-o", "tran").start();
+                process = new ProcessBuilder("lsblk", "-d", "-o", "TRAN", "/dev/" + partitionId).start();
             } else if (App.os.startsWith("Mac OS")) {
-                process = new ProcessBuilder("diskutil", "info", "disk0").start();
+                process = new ProcessBuilder("diskutil", "info", partitionId).start();
             }
         } catch (IOException e) {
             Logger.getLogger(Util.class.getName())
@@ -342,13 +436,20 @@ public static String getInterfaceType(){
 
             while ((line = reader.readLine()) != null) {
 
-                line=line.trim();
+                line = line.trim();
+
+                if (line.isEmpty()) { continue;}
 
-                if(line.isEmpty()) { continue;}
+                if (line.equalsIgnoreCase("InterfaceType") || line.equalsIgnoreCase("TRAN")|| line.equalsIgnoreCase("NAME")) { continue;}
 
-                if(line.equalsIgnoreCase("InterfaceType") || line.equalsIgnoreCase("TRAN")|| line.equalsIgnoreCase("NAME")) { continue;}
+                // In case of MacOs parse the output for interface type
+                if (line.startsWith("Protocol:")) {
+
+                    return line.split(":",2)[1].trim();
+                }
 
                 return line;
+
             }
 
         } catch (IOException e) {