Skip to content

ISSUE_CHECK.md

Latest commit

 

History

History
136 lines (110 loc) · 5.47 KB

ISSUE_CHECK.md

File metadata and controls

136 lines (110 loc) · 5.47 KB

Issue Check Review - issueCheck Branch

Overview

This document tracks the status of all open issues to determine which can be closed after the recent Publish-SFACertificates work.

Open Issues (7 total)

1. ✅ #61 - Add edge case testing for Publish-SFACertificates

  • Status: ✅ CLOSED
  • Closed by: PR #63 - Edge case testing (merged into feat/Publish-SFACertificates)
  • Key commits: 1c8d03b, 8dde74a, 34fe65c, 9921ef7
  • Tests Added: 76+ comprehensive edge case tests
  • Coverage:
    • ✅ Expired certificates
    • ✅ Special characters in names
    • ✅ Archive folder filtering
    • ✅ Long filenames
    • ✅ Mixed case branch codes
    • ✅ Missing/malformed mappings
    • ✅ Duplicate certificate names
    • ✅ Report generation

2. ⏳ #50 - Debug SFA Certificate Distribution Issues

  • Status: PARTIALLY COMPLETE
  • Phases:
    • ✅ Phase 1: Setup & Prerequisites
    • ✅ Phase 2: Core Feature Verification
    • ✅ Phase 3: Common Failure Scenarios
    • ✅ Phase 4: Edge Cases (via #61)
    • ✅ Phase 5: Integration & Validation
  • Sub-Issues: #61, #64, #65
  • Action: KEEP OPEN - Parent issue with sub-issues #64 and #65 still pending

3. 🆕 #65 - Run cleanup on local SFA source before publishing certificates

  • Status: 🚀 PLANNING / IN PROGRESS
  • Branch: feat/local-cert-cleanup-preprocessing (created)
  • Implementation Plan: Posted as comment on issue #65
  • Key Features:
    • ✅ Run Move-ExpiredUserCertificates on local source BEFORE publishing
    • ✅ Prevent expired certs from being distributed
    • ✅ Still run remote cleanup as safety net
    • ✅ Track and report cleanup warnings
  • Requirements:
    • Invoke-LocalSourceCleanup function implemented
    • Local cleanup invoked at script start
    • Cleanup warnings tracked and reported
    • Report generation includes local results
    • 5 unit tests added and passing
    • Manual integration test passed
    • PR created and ready for review
  • Impact: Workflow improvement - prevents bad data distribution
  • Effort: Medium

4. 🆕 #64 - Skip already-present certificates on remote branches

  • Status: 🚀 PLANNING / IN PROGRESS
  • Branch: feat/skip-present-certificates (created)
  • Implementation Plan: Posted as comment on issue #64
  • Key Features:
    • ✅ Check remote filesystem before copying
    • ✅ Skip certificates already present
    • ✅ Compare by filename only (no hash validation)
    • ✅ Log skipped in reports
    • ✅ Reduce network traffic (90%+ on subsequent runs)
  • Requirements:
    • Test-RemoteCertificateExists function implemented
    • Skip logic integrated into copy loop
    • Skipped count tracked in metrics
    • Report generation includes skip stats
    • 7 unit tests added and passing
    • Manual integration test passed
    • Performance test validates reduction
    • PR created and ready for review
  • Prerequisite: #65 (local cleanup preprocessing)
  • Impact: Performance optimization - significant traffic reduction on subsequent runs
  • Effort: Medium
  • Performance: 90%+ traffic reduction after first run, 50%+ faster execution

5. ❌ #56 - Archive folder being copied to remote

  • Status: ✅ CLOSED
  • Closed by: Commit 5315770 - Fix archive folder name from 'Archive' to 'Old'
  • Merged into: PR #66 - Complete Publish-SFACertificates implementation
  • Root cause: Archive folder structure created even though files excluded
  • Fix: Changed folder name from 'Archive' to 'Old', aligned with Move-ExpiredUserCertificates
  • Verified by: PR #63 - Comprehensive archive folder filtering tests

6. 📚 #55 - Add comprehensive tests for 1Password credential management in PersonalUtils

  • Status: NOT IMPLEMENTED
  • Requirements:
    • Add unit/integration tests for PersonalUtils 1Password functions
    • Cover credential retrieval, error handling, CLI availability
    • Test interactions with DPAPI caching
    • Ensure tests are stable and don't leak secrets
  • Scope: PersonalUtils module testing
  • Action: KEEP OPEN - Separate from SFA work, needs own effort

7. 💾 #34 - 1Password CLI Service Account Limitation with DateFormat Scripts

  • Status: IN PROGRESS (feat/1password-credential-management branch)
  • Proposed: Credential file cache with DPAPI encryption
  • Impact: DateFormat scripts usability enhancement
  • Action: KEEP OPEN - Active development on separate branch

Summary

Issues Closed (2) ✅

  • ✅ #61 - Edge case testing (PR #63, merged)
  • ✅ #56 - Archive folder bug (Commit 5315770, merged via PR #66)

Issues in Planning/Development (2) 🚀

  • 🚀 #65 - Local cleanup preprocessing (feat/local-cert-cleanup-preprocessing)

    • Implementation plan: Posted on issue
    • Expected: Medium effort, high impact
    • Status: Ready to implement

  • 🚀 #64 - Skip present certificates (feat/skip-present-certificates)

    • Implementation plan: Posted on issue
    • Expected: Medium effort, performance boost
    • Status: Depends on #65, ready when #65 complete
    • Performance: 90%+ traffic reduction on subsequent runs

Issues in Different Scope (3) 📚

  • 📚 #55 - 1Password PersonalUtils tests (separate scope)
  • 📚 #34 - 1Password credential management (separate scope)
  • 📚 #50 - Parent tracking issue (depends on #64, #65)