Address PR review: simplify calcMinFeeRecursive and remove redundant constraints

- Remove getMultiAssets helper and inline the MaryValue extraction, since
  EraCommonConstraints guarantees Value ~ MaryValue for all eras including
  Dijkstra
- Remove unnecessary parameters from go's recursive loop — utxo, pparams,
  poolids, stakeDelegDeposits, drepDelegDeposits, and nExtraWitnesses are
  never modified and are already in scope from the enclosing function
- Remove redundant obtainCommonConstraints calls in test generators where
  constraints are already in scope from the outer call

Author: Jimbo4350

cardano-api/src/Cardano/Api/Experimental/Tx/Internal/Fee.hs

@@ -760,18 +760,13 @@ calcMinFeeRecursive changeAddr unsignedTx utxo pparams poolids stakeDelegDeposit
   | multiAssetIsNegative =
       Left $ NonAdaAssetsUnbalanced multiAssets
   | otherwise =
-      go
-        maxIterations
-        unsignedTx
-        utxo
-        pparams
-        poolids
-        stakeDelegDeposits
-        drepDelegDeposits
-        nExtraWitnesses
+      go maxIterations unsignedTx
  where
   initialBalance = evaluateTransactionBalance pparams poolids stakeDelegDeposits drepDelegDeposits utxo unsignedTx
-  multiAssets = getMultiAssets (useEra @era) initialBalance
+  multiAssets =
+    obtainCommonConstraints (useEra @era) $
+      let L.MaryValue _ ma = initialBalance
+       in ma
   -- Check whether any native token quantity is negative.
   -- ADA is zeroed out so it doesn't influence the check.
   multiAssetIsNegative =
@@ -783,34 +778,28 @@ calcMinFeeRecursive changeAddr unsignedTx utxo pparams poolids stakeDelegDeposit
   go
     :: Int
     -> UnsignedTx (LedgerEra era)
-    -> L.UTxO (LedgerEra era)
-    -> L.PParams (LedgerEra era)
-    -> Set PoolId
-    -> Map StakeCredential L.Coin
-    -> Map (Ledger.Credential Ledger.DRepRole) L.Coin
-    -> Int
     -> Either FeeCalculationError (UnsignedTx (LedgerEra era))
-  go 0 _ _ _ _ _ _ _ = Left FeeCalculationDidNotConverge
-  go n unSignTx@(UnsignedTx ledgerTx) utxo' pparams' poolids' stakeDelegDeposits' drepDelegDeposits' nExtraWitnesses'
+  go 0 _ = Left FeeCalculationDidNotConverge
+  go n unSignTx@(UnsignedTx ledgerTx)
     | minFee == txBodyFee && L.isZero txBalanceValue = do
         -- Case 1
         let outs = toList $ ledgerTx ^. L.bodyTxL . L.outputsTxBodyL
-        mapM_ (checkOutputMinUTxO pparams') outs
+        mapM_ (checkOutputMinUTxO pparams) outs
         return unSignTx
     | minFee == txBodyFee = do
         -- Case 2
         balancedOuts <- balanceTxOuts @era changeAddr txBalanceValue unSignTx
         let updatedTx = UnsignedTx (ledgerTx & L.bodyTxL . L.outputsTxBodyL .~ balancedOuts)
-        go (n - 1) updatedTx utxo' pparams' poolids' stakeDelegDeposits' drepDelegDeposits' nExtraWitnesses'
+        go (n - 1) updatedTx
     | otherwise =
         -- Case 3
         let newTx = UnsignedTx (ledgerTx & L.bodyTxL . L.feeTxBodyL .~ minFee)
-         in go (n - 1) newTx utxo' pparams' poolids' stakeDelegDeposits' drepDelegDeposits' nExtraWitnesses'
+         in go (n - 1) newTx
    where
-    minFee = obtainCommonConstraints (useEra @era) $ L.calcMinFeeTx utxo' pparams' ledgerTx nExtraWitnesses'
+    minFee = obtainCommonConstraints (useEra @era) $ L.calcMinFeeTx utxo pparams ledgerTx nExtraWitnesses
     txBodyFee = ledgerTx ^. L.bodyTxL . L.feeTxBodyL
     txBalanceValue =
-      evaluateTransactionBalance pparams' poolids' stakeDelegDeposits' drepDelegDeposits' utxo' unSignTx
+      evaluateTransactionBalance pparams poolids stakeDelegDeposits drepDelegDeposits utxo unSignTx
 
 checkOutputMinUTxO
   :: forall era
@@ -826,12 +815,6 @@ checkOutputMinUTxO pp out =
           Left (TxOut offending, minRequired) ->
             Left $ MinUTxONotMet (offending ^. L.coinTxOutL) minRequired
 
-getMultiAssets :: Era era -> L.Value (LedgerEra era) -> L.MultiAsset
-getMultiAssets era val = case era of
-  DijkstraEra -> mempty
-  ConwayEra ->
-    let L.MaryValue _ ma = val
-     in ma
 
 balanceTxOuts
   :: forall era

cardano-api/test/cardano-api-test/Test/Cardano/Api/Experimental.hs

@@ -606,7 +606,6 @@ genFundedSimpleTx era = do
       sendTxOut =
         Exp.obtainCommonConstraints era $
           Exp.TxOut $
-            Exp.obtainCommonConstraints era $
               Ledger.mkBasicTxOut addr (L.MaryValue sendCoin mempty)
       txBodyContent =
         Exp.defaultTxBodyContent
@@ -644,7 +643,6 @@ genFundedMultiAssetTx era = do
       sendTxOut =
         Exp.obtainCommonConstraints era $
           Exp.TxOut $
-            Exp.obtainCommonConstraints era $
               Ledger.mkBasicTxOut addr (L.MaryValue sendCoin multiAsset)
       txBodyContent =
         Exp.defaultTxBodyContent
@@ -678,7 +676,6 @@ genUnderfundedTx era = do
       sendTxOut =
         Exp.obtainCommonConstraints era $
           Exp.TxOut $
-            Exp.obtainCommonConstraints era $
               Ledger.mkBasicTxOut addr (L.MaryValue sendCoin mempty)
       txBodyContent =
         Exp.defaultTxBodyContent
@@ -787,7 +784,6 @@ genNonAdaUnbalancedTx era = do
       sendTxOut =
         Exp.obtainCommonConstraints era $
           Exp.TxOut $
-            Exp.obtainCommonConstraints era $
               Ledger.mkBasicTxOut addr sendValue
       txBodyContent =
         Exp.defaultTxBodyContent
@@ -827,13 +823,11 @@ genMinUTxOViolatingTx era = do
       sendTxOut1 =
         Exp.obtainCommonConstraints era $
           Exp.TxOut $
-            Exp.obtainCommonConstraints era $
               Ledger.mkBasicTxOut addr (L.MaryValue (L.Coin 1_000_000) mempty)
       -- Output 2: tokens with tiny ADA (below min UTxO)
       sendTxOut2 =
         Exp.obtainCommonConstraints era $
           Exp.TxOut $
-            Exp.obtainCommonConstraints era $
               Ledger.mkBasicTxOut addr (L.MaryValue (L.Coin 1_000) multiAsset)
       txBodyContent =
         Exp.defaultTxBodyContent
@@ -955,7 +949,6 @@ genTinySurplusTx era = do
       sendTxOut =
         Exp.obtainCommonConstraints era $
           Exp.TxOut $
-            Exp.obtainCommonConstraints era $
               Ledger.mkBasicTxOut addr (L.MaryValue sendCoin mempty)
       txBodyContent =
         Exp.defaultTxBodyContent