Skip to content

Commit 04c3e97

Browse files
committed
Remove redundant macOS Intel job
The macOS Apple Silicon runner already cross-compiles for both ARM64 and x86_64, making the separate Intel runner unnecessary and wasteful.
1 parent a6b5b82 commit 04c3e97

1 file changed

Lines changed: 4 additions & 77 deletions

File tree

.github/workflows/precompile.yml

Lines changed: 4 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -129,82 +129,9 @@ jobs:
129129
--health-timeout 5s
130130
--health-retries 5
131131
132-
# Build and test on macOS Intel
133-
macos-intel:
134-
name: macOS Intel (x86_64)
135-
runs-on: macos-13
136-
strategy:
137-
matrix:
138-
otp: ["25.0", "26.2", "27.2"]
139-
140-
steps:
141-
- uses: actions/checkout@v4
142-
with:
143-
submodules: recursive
144-
145-
- uses: erlef/setup-beam@v1
146-
with:
147-
otp-version: ${{ matrix.otp }}
148-
elixir-version: "1.18.4"
149-
150-
- name: Download ClickHouse binary
151-
run: |
152-
curl https://clickhouse.com/ | sh
153-
chmod +x ./clickhouse
154-
155-
- name: Start ClickHouse server
156-
run: |
157-
./clickhouse server > ./clickhouse_server.log 2>&1 &
158-
echo $! > ./clickhouse_server.pid
159-
echo "ClickHouse server started with PID $(cat ./clickhouse_server.pid)"
160-
sleep 5
161-
162-
- name: Wait for ClickHouse
163-
run: |
164-
echo "Waiting for ClickHouse to start..."
165-
for i in {1..15}; do
166-
if ./clickhouse client --query "SELECT 1" 2>/dev/null; then
167-
echo "ClickHouse is ready!"
168-
./clickhouse client --query "SELECT version()"
169-
break
170-
fi
171-
if [ $i -eq 60 ]; then
172-
echo "ClickHouse failed to start. Logs:"
173-
cat ./clickhouse_server.log || echo "No log file found"
174-
exit 1
175-
fi
176-
echo "Still waiting... ($i/60)"
177-
sleep 2
178-
done
179-
./clickhouse client --query "SELECT 1"
180-
181-
- name: Install dependencies
182-
run: |
183-
brew install cmake openssl
184-
mix deps.get
185-
186-
- name: Precompile NIFs
187-
run: |
188-
export ELIXIR_MAKE_CACHE_DIR=$(pwd)/cache
189-
mkdir -p $ELIXIR_MAKE_CACHE_DIR
190-
MIX_ENV=prod mix elixir_make.precompile
191-
192-
- name: Upload artifacts to release
193-
uses: softprops/action-gh-release@v1
194-
if: startsWith(github.ref, 'refs/tags/')
195-
with:
196-
files: cache/*.tar.gz
197-
draft: true
198-
199-
- name: Run tests on x86_64 macOS
200-
run: mix test --exclude integration
201-
env:
202-
CLICKHOUSE_HOST: localhost
203-
CLICKHOUSE_PORT: 9000
204-
205-
# Build and test on macOS Apple Silicon
206-
macos-arm:
207-
name: macOS Apple Silicon (ARM64)
132+
# Build and test on macOS Apple Silicon (builds both ARM64 and x86_64)
133+
macos:
134+
name: macOS (ARM64 + x86_64)
208135
runs-on: macos-14
209136
strategy:
210137
matrix:
@@ -269,7 +196,7 @@ jobs:
269196
files: cache/*.tar.gz
270197
draft: true
271198

272-
- name: Run tests on ARM64 macOS
199+
- name: Run tests on macOS
273200
run: mix test --exclude integration
274201
env:
275202
CLICKHOUSE_HOST: localhost

0 commit comments

Comments
 (0)