Skip to content

Commit dcc8a94

Browse files
antonwolfyclaude
andcommitted
fix(ci): pin both cp314 and cp314t ABIs explicitly for Python 3.14
The previous fix pinned only the free-threaded variant (*_cp314t) and left the GIL variant relying on a bare `conda build --python 3.14`. That default is no longer reliable: conda-forge bumped the free-threaded python_abi to a higher build number (8_cp314t), so conda-build's solver now resolves a bare `--python 3.14` to cp314t rather than cp314. As a result both 3.14 build jobs produced cp314t artifacts, the GIL build disappeared, and the two upload jobs collided again on the identical cp314-cp314t wheel filename. Fix: remove 3.14 from every base `python` list and define both ABIs as explicit, pinned matrix entries (3.14.* *_cp314 for GIL and 3.14.* *_cp314t for free-threading) across all matrix blocks in both workflows. This makes the build/test/install steps request an explicit ABI instead of trusting whichever python_abi build number the solver happens to prefer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 5aa1f77 commit dcc8a94

2 files changed

Lines changed: 29 additions & 9 deletions

File tree

.github/workflows/conda-package.yml

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,11 @@ jobs:
2626

2727
strategy:
2828
matrix:
29-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
29+
python: ['3.10', '3.11', '3.12', '3.13']
3030
python_spec: ['']
3131
include:
32+
- python: '3.14'
33+
python_spec: '3.14.* *_cp314'
3234
- python: '3.14'
3335
python_spec: '3.14.* *_cp314t'
3436
steps:
@@ -101,9 +103,11 @@ jobs:
101103

102104
strategy:
103105
matrix:
104-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
106+
python: ['3.10', '3.11', '3.12', '3.13']
105107
python_spec: ['']
106108
include:
109+
- python: '3.14'
110+
python_spec: '3.14.* *_cp314'
107111
- python: '3.14'
108112
python_spec: '3.14.* *_cp314t'
109113
steps:
@@ -176,9 +180,13 @@ jobs:
176180

177181
strategy:
178182
matrix:
179-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
183+
python: ['3.10', '3.11', '3.12', '3.13']
180184
python_spec: ['']
181185
include:
186+
- python: '3.14'
187+
python_spec: '3.14.* *_cp314'
188+
experimental: false
189+
runner: ubuntu-22.04
182190
- python: '3.14'
183191
python_spec: '3.14.* *_cp314t'
184192
experimental: false
@@ -291,9 +299,13 @@ jobs:
291299
shell: cmd /C CALL {0}
292300
strategy:
293301
matrix:
294-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
302+
python: ['3.10', '3.11', '3.12', '3.13']
295303
python_spec: ['']
296304
include:
305+
- python: '3.14'
306+
python_spec: '3.14.* *_cp314'
307+
experimental: false
308+
runner: windows-latest
297309
- python: '3.14'
298310
python_spec: '3.14.* *_cp314t'
299311
experimental: false
@@ -480,9 +492,11 @@ jobs:
480492
timeout-minutes: 20
481493
strategy:
482494
matrix:
483-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
495+
python: ['3.10', '3.11', '3.12', '3.13']
484496
python_spec: ['']
485497
include:
498+
- python: '3.14'
499+
python_spec: '3.14.* *_cp314'
486500
- python: '3.14'
487501
python_spec: '3.14.* *_cp314t'
488502
steps:
@@ -527,9 +541,11 @@ jobs:
527541
shell: cmd /C CALL {0}
528542
strategy:
529543
matrix:
530-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
544+
python: ['3.10', '3.11', '3.12', '3.13']
531545
python_spec: ['']
532546
include:
547+
- python: '3.14'
548+
python_spec: '3.14.* *_cp314'
533549
- python: '3.14'
534550
python_spec: '3.14.* *_cp314t'
535551
steps:
@@ -573,7 +589,7 @@ jobs:
573589
strategy:
574590
matrix:
575591
python: ['3.14']
576-
python_spec: ['']
592+
python_spec: ['3.14.* *_cp314']
577593
experimental: [false]
578594
runner: [ubuntu-latest]
579595
include:

.github/workflows/run-tests-from-dppy-bits.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@ jobs:
2727

2828
strategy:
2929
matrix:
30-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
30+
python: ['3.10', '3.11', '3.12', '3.13']
3131
python_spec: ['']
3232
include:
33+
- python: '3.14'
34+
python_spec: '3.14.* *_cp314'
3335
- python: '3.14'
3436
python_spec: '3.14.* *_cp314t'
3537
experimental: [false]
@@ -86,9 +88,11 @@ jobs:
8688
shell: cmd /C CALL {0}
8789
strategy:
8890
matrix:
89-
python: ['3.10', '3.11', '3.12', '3.13', '3.14']
91+
python: ['3.10', '3.11', '3.12', '3.13']
9092
python_spec: ['']
9193
include:
94+
- python: '3.14'
95+
python_spec: '3.14.* *_cp314'
9296
- python: '3.14'
9397
python_spec: '3.14.* *_cp314t'
9498
experimental: [false]

0 commit comments

Comments
 (0)