Skip to content

Commit 660873e

Browse files
authored
rename routingMode to routerMode (#88)
Signed-off-by: kerthcet <kerthcet@gmail.com>
1 parent ce459c3 commit 660873e

10 files changed

Lines changed: 24 additions & 24 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ use tokio::runtime::Runtime;
4949
fn main() {
5050
let config = client::Config::builder()
5151
.provider("deepinfra")
52-
.routing_mode(client::RoutingMode::WRR)
52+
.routing_mode(client::RouterMode::WRR)
5353
.model(
5454
client::ModelConfig::builder()
5555
.name("deepseek-ai/DeepSeek-V3.2")

bindings/python/amrs/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
from amrs.config import ModelConfig, Config, RoutingMode
1+
from amrs.config import ModelConfig, Config, RouterMode
22

33
__all__ = [
44
"ModelConfig",
55
"Config",
6-
"RoutingMode",
6+
"RouterMode",
77
]

bindings/python/amrs/config.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,15 @@ class Message(BaseModel):
7272
content: str = Field(description="Content of the message.")
7373

7474

75-
class RoutingMode(str, Enum):
75+
class RouterMode(str, Enum):
7676
RANDOM = "random"
7777
WEIGHTED = "weighted"
7878

7979

8080
class Config(BasicModelConfig):
8181
models: List[ModelConfig] = Field(description="List of model configurations")
82-
routing_mode: RoutingMode = Field(
83-
default=RoutingMode.RANDOM,
82+
routing_mode: RouterMode = Field(
83+
default=RouterMode.RANDOM,
8484
description="Routing mode for the model, default is random.",
8585
)
8686
callback_funcs: Optional[List[Callable]] = Field(

bindings/python/amrs/router/router.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ def __init__(self, model_list: list[config.ModelName]):
1414
def sample(self, content: str) -> config.ModelName:
1515
pass
1616

17-
def new_router(model_cfgs: list[config.ModelConfig], mode: config.RoutingMode) -> Router:
17+
def new_router(model_cfgs: list[config.ModelConfig], mode: config.RouterMode) -> Router:
1818
model_list = [f"{model_cfg.provider}/{model_cfg.id}" for model_cfg in model_cfgs]
1919

20-
if mode == config.RoutingMode.RANDOM:
20+
if mode == config.RouterMode.RANDOM:
2121
from amrs.router.random import RandomRouter
2222
return RandomRouter(model_list)
2323
else:

examples/wrr.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use tokio::runtime::Runtime;
55
fn main() {
66
let config = client::Config::builder()
77
.provider("deepinfra")
8-
.routing_mode(client::RoutingMode::WRR)
8+
.routing_mode(client::RouterMode::WRR)
99
.model(
1010
client::ModelConfig::builder()
1111
.name("deepseek-ai/DeepSeek-V3.2")

src/client/client.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ impl Client {
5151
#[cfg(test)]
5252
mod tests {
5353
use super::*;
54-
use crate::client::config::{Config, ModelConfig, RoutingMode};
54+
use crate::client::config::{Config, ModelConfig, RouterMode};
5555
use dotenvy::from_filename;
5656

5757
#[test]
@@ -81,7 +81,7 @@ mod tests {
8181
TestCase {
8282
name: "weighted round-robin router",
8383
config: Config::builder()
84-
.routing_mode(RoutingMode::WRR)
84+
.routing_mode(RouterMode::WRR)
8585
.models(vec![
8686
crate::client::config::ModelConfig::builder()
8787
.name("model_a".to_string())

src/client/config.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ lazy_static! {
2222

2323
// ------------------ Routing Mode ------------------
2424
#[derive(Debug, Clone, PartialEq)]
25-
pub enum RoutingMode {
25+
pub enum RouterMode {
2626
Random,
2727
WRR, // WeightedRoundRobin,
2828
}
@@ -83,8 +83,8 @@ pub struct Config {
8383
#[builder(default = "DEFAULT_PROVIDER.to_string()", setter(custom))]
8484
pub(crate) provider: String,
8585

86-
#[builder(default = "RoutingMode::Random")]
87-
pub(crate) routing_mode: RoutingMode,
86+
#[builder(default = "RouterMode::Random")]
87+
pub(crate) routing_mode: RouterMode,
8888
#[builder(default = "vec![]")]
8989
pub(crate) models: Vec<ModelConfig>,
9090
}
@@ -152,7 +152,7 @@ impl ConfigBuilder {
152152

153153
for model in self.models.as_ref().unwrap() {
154154
if self.routing_mode.is_some()
155-
&& self.routing_mode.as_ref().unwrap() == &RoutingMode::WRR
155+
&& self.routing_mode.as_ref().unwrap() == &RouterMode::WRR
156156
&& model.weight <= 0
157157
{
158158
return Err(format!(
@@ -218,7 +218,7 @@ mod tests {
218218
assert!(valid_simplest_models_cfg.is_ok());
219219
assert!(valid_simplest_models_cfg.as_ref().unwrap().provider == DEFAULT_PROVIDER);
220220
assert!(valid_simplest_models_cfg.as_ref().unwrap().base_url == None);
221-
assert!(valid_simplest_models_cfg.as_ref().unwrap().routing_mode == RoutingMode::Random);
221+
assert!(valid_simplest_models_cfg.as_ref().unwrap().routing_mode == RouterMode::Random);
222222
assert!(valid_simplest_models_cfg.as_ref().unwrap().models.len() == 1);
223223
assert!(valid_simplest_models_cfg.as_ref().unwrap().models[0].base_url == None);
224224
assert!(valid_simplest_models_cfg.as_ref().unwrap().models[0].provider == None);

src/client/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ pub mod client;
22
pub mod config;
33

44
pub use client::Client;
5-
pub use config::{Config, ModelConfig, ModelName, RoutingMode};
5+
pub use config::{Config, ModelConfig, ModelName, RouterMode};

src/router/router.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use crate::client::config::{ModelConfig, ModelName, RoutingMode};
1+
use crate::client::config::{ModelConfig, ModelName, RouterMode};
22
use crate::router::random::RandomRouter;
33
use crate::router::wrr::WeightedRoundRobinRouter;
44

@@ -8,7 +8,7 @@ pub struct ModelInfo {
88
pub weight: i32,
99
}
1010

11-
pub fn construct_router(mode: RoutingMode, models: Vec<ModelConfig>) -> Box<dyn Router> {
11+
pub fn construct_router(mode: RouterMode, models: Vec<ModelConfig>) -> Box<dyn Router> {
1212
let model_infos: Vec<ModelInfo> = models
1313
.iter()
1414
.map(|m| ModelInfo {
@@ -17,8 +17,8 @@ pub fn construct_router(mode: RoutingMode, models: Vec<ModelConfig>) -> Box<dyn
1717
})
1818
.collect();
1919
match mode {
20-
RoutingMode::Random => Box::new(RandomRouter::new(model_infos)),
21-
RoutingMode::WRR => Box::new(WeightedRoundRobinRouter::new(model_infos)),
20+
RouterMode::Random => Box::new(RandomRouter::new(model_infos)),
21+
RouterMode::WRR => Box::new(WeightedRoundRobinRouter::new(model_infos)),
2222
}
2323
}
2424

@@ -47,10 +47,10 @@ mod tests {
4747
.unwrap(),
4848
];
4949

50-
let random_router = construct_router(RoutingMode::Random, model_configs.clone());
50+
let random_router = construct_router(RouterMode::Random, model_configs.clone());
5151
assert_eq!(random_router.name(), "RandomRouter");
5252

53-
let weighted_router = construct_router(RoutingMode::WRR, model_configs.clone());
53+
let weighted_router = construct_router(RouterMode::WRR, model_configs.clone());
5454
assert_eq!(weighted_router.name(), "WeightedRoundRobinRouter");
5555
}
5656
}

tests/client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ mod tests {
5757
// case 3: multiple models with router.
5858
let config = client::Config::builder()
5959
.provider("faker")
60-
.routing_mode(client::RoutingMode::WRR)
60+
.routing_mode(client::RouterMode::WRR)
6161
.model(
6262
client::ModelConfig::builder()
6363
.name("gpt-3.5-turbo")

0 commit comments

Comments
 (0)