there are several stuct fields with int types, but bool semantics

[sleeptightAnsiC]

This is a follow up from #883

Change the field type in nk_style_slider and nk_style_scrollbar to nk_bool.

I would rather not do this. Not only there are way more int fields with bool semantics like these two, there is simply no other use of nk_bool type anywhere in the style structs (EDIT: I think I found one somewhere). If you want these two changed, you should probably also change other similar fields elsewhere [...]

I may missing something, but I’m not entirely sure why this issue is being generalized to such a broad scope in the discussion. [...] broadening the problem to all similar cases, the conclusion naturally becomes that fixing it would be complex and risky. To me, this feels like a conceptual trap.

Those were the only ones that we had the code coverage to catch.

Nuklear/src/nuklear.h

Line 4642 in 25f33c8

int use_clipping;

Nuklear/src/nuklear.h

Line 5038 in 25f33c8

int show_buttons;

Nuklear/src/nuklear.h

Line 5134 in 25f33c8

int show_buttons;

Nuklear/src/nuklear.h

Line 5359 in 25f33c8

int cursor_visible;

Nuklear/src/nuklear.h

Line 5741 in 25f33c8

int use_pool;

^ Those are the ones I was able to quickly find. There are probably more.

I personally do NOT want to change any of this. It can cause more issues like #812 and this isn't affecting any new code anyway. I gave many reasons under #883 why changing any of those struct fields is risky.

I'm only reporting this for the sake of documenting. I will not be doing anything about it myself, and would suggest everyone else to ignore it, at least for now.

Edit: related to: #183 ; #185

[sleeptightAnsiC]

And also, for anyone who ever comes here: if you take a look at the structs in Nuklear, you will notice that most of the fields use wrong types in one way or another (for example: unsigned int instead of nk_uint). So this isn't really only about nk_bool at this point (but the bool ones are the most obvious)

[RobLoach]

I think it does warrant cleaning up the data types. Understand that it could break compatibility, but honestly, a nk_bool should be used for boolean-cases 🙃