Fixed character set limitations. Added tests.

Author: rohe

src/oidcmsg/oauth2/__init__.py

@@ -46,7 +46,7 @@ def verify(self, **kwargs):
         if "error_description" in self:
             # Verify that the characters used are within the allow ranges
             # %x20-21 / %x23-5B / %x5D-7E
-            if all(x in error_chars for x in self["error_description"]):
+            if not all(x in error_chars for x in self["error_description"]):
                 raise ValueError("Characters outside allowed set")
         return True
 

tests/test_4_message.py

@@ -34,6 +34,8 @@
 
 __author__ = 'Roland Hedberg'
 
+from oidcmsg.oauth2 import ResponseMessage
+
 keys = [
     {"type": "RSA", "use": ["sig"]},
     {"type": "RSA", "use": ["enc"]},
@@ -496,3 +498,16 @@ def test_msg_ser():
         msg_ser([1,2], 'dict')
     with pytest.raises(OidcMsgError):
         msg_ser([1,2], 'list')
+
+
+def test_error_description():
+    msg = ResponseMessage(error="foobar", error_description="ÅÄÖ")
+    with pytest.raises(ValueError):
+        msg.verify()
+
+    msg = ResponseMessage(error="foobar", error_description="abc\ndef")
+    with pytest.raises(ValueError):
+        msg.verify()
+
+    msg = ResponseMessage(error="foobar", error_description="abc def")
+    msg.verify()

tests/test_7_session.py

@@ -62,7 +62,6 @@ def full_path(local_file):
 class TestEndSessionResponse(object):
     def test_example(self):
         esr = EndSessionResponse()
-        pass
 
 
 class TestEndSessionRequest(object):