Skip to content

Commit cc17420

Browse files
committed
fix external request bug, fix tests
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
1 parent fe99083 commit cc17420

5 files changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
runs-on: ${{ matrix.os }}
7070
services:
7171
rabbitmq:
72-
image: "bitnamilegacy/rabbitmq:3.13.3"
72+
image: "bitnamilegacy/rabbitmq:4.1"
7373
env:
7474
# space-delimited list of plugins
7575
RABBITMQ_PLUGINS: "rabbitmq_mqtt"

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ We follow [Common Changelog](https://common-changelog.org/) formatting for this
2424
### Removed
2525

2626
- Dropped MQTT 3.1.1 support ([commit](https://github.com/INTERSECT-SDK/python-sdk/commit/e09f13f9b244b92b6bcecc814df49c81340dcc02)) (Lance Drane)
27+
- Dropped support for Python versions <= 3.9
2728

2829
## [0.8.4] - 2026-02-05
2930

src/intersect_sdk/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,7 @@ def _handle_client_message(
881881
)
882882
return
883883

884-
extreq = self._get_external_request(headers.message_id)
884+
extreq = self._get_external_request(headers.request_id)
885885
if extreq is not None:
886886
error_msg: str | None = None
887887
try:

tests/integration/test_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ def userspace_msg_callback(
143143

144144
assert msg[0] == b'[5,8,13]'
145145
# make sure header IDs were not modified
146-
assert msg[2]['request_id'] == request_id
147-
assert msg[2]['campaign_id'] == campaign_id
146+
assert msg[2].request_id == request_id
147+
assert msg[2].campaign_id == campaign_id
148148

149149

150150
# call a @staticmethod user function, which should work as normal

tests/unit/test_schema_ref_resolution.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import json
2+
from collections.abc import Iterable
23
from pathlib import Path
3-
from typing import Iterable, List
44

55
from referencing import Registry, Resource
66
from referencing.exceptions import Unresolvable
@@ -30,7 +30,7 @@ def assert_refs_resolve(schema: dict) -> None:
3030
resource = Resource.from_contents(schema, default_specification=DRAFT202012)
3131
base_uri = ''
3232
resolver = Registry().with_resource(base_uri, resource).resolver(base_uri)
33-
unresolved: List[str] = []
33+
unresolved: list[str] = []
3434
for ref in iter_ref_values(schema):
3535
try:
3636
resolver.lookup(ref)

0 commit comments

Comments
 (0)