Use prepared statement for number of active raw sessions

Author: mBeym

components/ILIAS/Authentication/classes/class.ilSessionStatistics.php

@@ -22,6 +22,8 @@ class ilSessionStatistics
 {
     private const int SLOT_SIZE = 15;
 
+    protected static ?ilDBStatement $number_of_active_raw_sessions_statement = null;
+
     /**
      * Is session statistics active at all?
      */
@@ -171,12 +173,8 @@ protected static function getNumberOfActiveRawSessions(int $a_time): int
 
         $ilDB = $DIC['ilDB'];
 
-        $sql = 'SELECT COUNT(*) counter FROM usr_session_stats_raw' .
-            ' WHERE (end_time IS NULL OR end_time >= ' . $ilDB->quote($a_time, 'integer') . ')' .
-            ' AND start_time <= ' . $ilDB->quote($a_time, 'integer') .
-            ' AND ' . $ilDB->in('type', ilSessionControl::$session_types_controlled, false, 'integer');
-        $res = $ilDB->query($sql);
-        $row = $ilDB->fetchAssoc($res);
+        $statement = self::getNumberOfActiveRawSessionsPreparedStatement();
+        $row = $DIC->database()->fetchAssoc($DIC->database()->execute($statement, [$a_time, $a_time]));
         return (int) $row['counter'];
     }
 
@@ -262,6 +260,22 @@ public static function aggretateRaw(int $a_now): void
         self::deleteAggregatedRaw($a_now);
     }
 
+    protected static function getNumberOfActiveRawSessionsPreparedStatement(): ilDbStatement
+    {
+        if (self::$number_of_active_raw_sessions_statement === null) {
+            global $DIC;
+            self::$number_of_active_raw_sessions_statement = $DIC->database()->prepare(
+                'SELECT COUNT(*) counter FROM usr_session_stats_raw '
+                . 'WHERE (end_time IS NULL OR end_time >= ?) '
+                . 'AND start_time <= ? '
+                . 'AND ' . $DIC->database()->in('type', ilSessionControl::$session_types_controlled, false, 'integer'),
+                [ilDBConstants::T_INTEGER, ilDBConstants::T_INTEGER]
+            );
+        }
+
+        return self::$number_of_active_raw_sessions_statement;
+    }
+
     protected static function getAggregatedRawDataPreparedStatement(): ilDBStatement
     {
         global $DIC;