Skip to content

Commit 20bffb1

Browse files
authored
Fix visibility display on the all reviews view. (#4759)
Fixes #4757
1 parent fe0633c commit 20bffb1

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

hypha/apply/review/views.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@
2020
from hypha.apply.activity.messaging import MESSAGES, messenger
2121
from hypha.apply.funds.models import ApplicationSubmission, AssignedReviewers
2222
from hypha.apply.funds.workflows import INITIAL_STATE
23-
from hypha.apply.review.blocks import RecommendationBlock, RecommendationCommentsBlock
23+
from hypha.apply.review.blocks import (
24+
RecommendationBlock,
25+
RecommendationCommentsBlock,
26+
VisibilityBlock,
27+
)
2428
from hypha.apply.review.forms import ReviewModelForm, ReviewOpinionForm
2529
from hypha.apply.stream_forms.models import BaseStreamForm
2630
from hypha.apply.todo.options import REVIEW_DRAFT
@@ -408,7 +412,12 @@ def get_queryset(self):
408412
def should_display(self, field):
409413
return not isinstance(
410414
field.block,
411-
(RecommendationBlock, RecommendationCommentsBlock, RichTextBlock),
415+
(
416+
RecommendationBlock,
417+
RecommendationCommentsBlock,
418+
RichTextBlock,
419+
VisibilityBlock,
420+
),
412421
)
413422

414423
def get_context_data(self, **kwargs):
@@ -420,6 +429,7 @@ def get_context_data(self, **kwargs):
420429
review_data["score"] = {"question": "Overall Score", "answers": []}
421430
review_data["recommendation"] = {"question": "Recommendation", "answers": []}
422431
review_data["revision"] = {"question": "Revision", "answers": []}
432+
review_data["visibility"] = {"question": "Visibility", "answers": []}
423433
review_data["comments"] = {"question": "Comments", "answers": []}
424434

425435
responses = self.object_list.count()
@@ -459,6 +469,7 @@ def get_context_data(self, **kwargs):
459469
else:
460470
revision = '<a href="{}">Compare</a>'.format(review.get_compare_url())
461471
review_data["revision"]["answers"].append(revision)
472+
review_data["visibility"]["answers"].append(review.get_visibility_display())
462473

463474
for field_id in review.fields:
464475
field = review.field(field_id)

0 commit comments

Comments
 (0)