[prefab] Change parent access to catch old @:privateAccess use case

These broke due to the fact that parent doesn't have a setter anymore

Author: EspeuteClement

hide_js/hide/comp/SceneEditor.hx

@@ -2483,7 +2483,7 @@ class SceneEditor {
 		}
 
 		for (prefab in prefabs) {
-			prefab.parent = targetPrefab;
+			targetPrefab.addChild(prefab);
 		}
 
 		var ser = ide.toJSON(targetPrefab.serialize());
@@ -4636,7 +4636,6 @@ class SceneEditor {
 		if (prefab == null)
 			return null;
 
-		prefab.parent = parent;
 		parent.addChildAt(prefab, index);
 
 		var ref = Std.downcast(prefab, Reference);
@@ -4843,10 +4842,10 @@ class SceneEditor {
 		undo.change(Custom(function(undo) {
 			if(undo) {
 				effectFunc(true);
-				group.parent = null;
+				group.remove();
 			}
 			else {
-				group.parent = parent;
+				parent.addChild(group);
 				effectFunc(false);
 			}
 			if(undo)

hide_js/hide/tools/ThumbnailGenerator.hx

@@ -277,7 +277,7 @@ class ThumbnailGenerator {
 				// Remove all editor only prefabs
 				var toRemove = prefab.findAll(hrt.prefab.Prefab, (p) -> p.editorOnly == true, true);
 				for (r in toRemove) {
-					r.parent = null;
+					r.remove();
 				}
 
 				var prefab = prefab.make(ctx);

hide_js/hide/view/FXEditor.hx

@@ -706,7 +706,7 @@ class FXEditor extends hide.view.FileView {
 						// We're currently supporting blending with only 2 curves
 						for (i in 0...2) {
 							var c = new Curve(null, null);
-							c.parent = curve;
+							curve.addChild(c.parent);
 							c.name = '$i';
 							if (i == 0) {
 								for (k in curve.keys) {

hrt/impl/RemoteConsole.hx

@@ -364,7 +364,7 @@ class RemoteConsoleConnection {
 					var prefabView : hide.view.Prefab = cast v;
 					var toEdit = hrt.prefab.Prefab.createFromDynamic(args.data);
 					prefabView.createData();
-					toEdit.parent = prefabView.data;
+					prefabView.data.addChild(toEdit);
 					prefabView.sceneEditor.delayReady(() -> {
 						prefabView.sceneEditor.setPrefab(cast prefabView.data);
 						prefabView.sceneEditor.selectElements([toEdit], NoHistory);

hrt/prefab/Object3D.hx

@@ -180,7 +180,7 @@ class Object3D extends Prefab {
 	}
 
 	public function getAbsPos( followRefs : Bool = false ) {
-		inline function getParent( p ) {
+		inline function getParent( p : Prefab ) {
 			var parent = p.parent;
 			if( parent == null && followRefs )
 				parent = p.shared.parentPrefab;

hrt/prefab/Prefab.hx

@@ -104,7 +104,8 @@ class Prefab {
 	/**
 		The parent of the prefab in the tree view
 	**/
-	public var parent(default, null) : Prefab;
+	public var parent(get, never) : Prefab;
+	var _parent : Prefab; // Catch invalid usages of parent in old prefabs
 
 	/**
 		Infos shared by all the prefabs in a given prefab hierarchy (but not by references)
@@ -133,7 +134,8 @@ class Prefab {
 		return getClassTypeName(thisClass);
 	}
 
-	inline function get_children() return _children ?? NULL_CHILDREN;
+	inline function get_parent() : Prefab return _parent;
+	inline function get_children() : Array<Prefab> return _children ?? NULL_CHILDREN;
 
 	/**
 		Instanciate this prefab. If `newContextShared` is given or if `this.shared.isInstance` is false,
@@ -844,7 +846,7 @@ class Prefab {
 				oldParent._children = null;
 			}
 		}
-		child.parent = newParent;
+		child._parent = newParent;
 		if (newParent != null) {
 			if (newParent._children == null)
 				newParent._children = [];

hrt/prefab/l3d/MeshSpray.hx

@@ -431,7 +431,7 @@ class MeshSpray extends Spray {
 			c.editorRemoveInstanceObjects();
 			c.dispose();
 			#end
-			c.parent = null;
+			c.remove();
 			binaryChanged = true;
 		}
 		if( !binaryChanged )

hrt/prefab/l3d/modellibrary/ModelLibrary.hx

@@ -761,7 +761,7 @@ class ModelLibrary extends Prefab {
 			throw "There is no destination path for saving the model library";
 
 		var root = new hrt.prefab.Prefab(null, null);
-		parent = root;
+		root.addChild(this);
 		sys.io.File.saveContent(getSystemPath(path), haxe.Json.stringify(@:privateAccess root.serialize(), "\t"));
 	}