[prefab] Remove parent setter

Only one way to setup prefab hierarchy now with
addChild()

Migration notes : `a.parent = b` -> `b.addChild(a)`

Author: EspeuteClement

hrt/prefab/Model.hx

@@ -132,7 +132,6 @@ class Model extends Object3D {
 			toAdd.props = toRemove.props;
 			toAdd.setTransform(toRemove.getTransform());
 			parent.addChildAt(toAdd, idx);
-			@:bypassAccessor toAdd.parent = parent;
 			@:privateAccess ctx.scene.editor.rebuild(toAdd);
 		}
 

hrt/prefab/Prefab.hx

@@ -104,7 +104,7 @@ class Prefab {
 	/**
 		The parent of the prefab in the tree view
 	**/
-	public var parent(default, set) : Prefab;
+	public var parent(default, null) : Prefab;
 
 	/**
 		Infos shared by all the prefabs in a given prefab hierarchy (but not by references)
@@ -125,7 +125,7 @@ class Prefab {
 			}
 		}
 		else
-			this.parent = parent;
+			parent.addChild(this);
 	}
 
 	function get_type() {
@@ -135,11 +135,6 @@ class Prefab {
 
 	inline function get_children() return _children ?? NULL_CHILDREN;
 
-	function set_parent(p) {
-		handleParenting(this, this.parent, p, p?.children.length ?? 0);
-		return p;
-	}
-
 	/**
 		Instanciate this prefab. If `newContextShared` is given or if `this.shared.isInstance` is false,
 		this prefab is cloned and then the clone is instanciated and returned.
@@ -208,15 +203,10 @@ class Prefab {
 
 		inst.copy(this);
 		if (withChildren && children.length > 0) {
-			inst._children = [];
-			inst._children.resize(children.length);
 			for (idx => child in children) {
 				var cloneChild = child.clone(null, sh);
 
-				// "parent" setter pushes into children, but we don't want that
-				// as we have prealocated the array children
-				@:bypassAccessor cloneChild.parent = inst;
-				inst._children[idx] = cloneChild;
+				inst.addChildAt(cloneChild, idx);
 			}
 		}
 
@@ -341,7 +331,9 @@ class Prefab {
 	}
 
 	public function remove() : Void {
-		parent = null;
+		if (parent != null) {
+			parent.removeChild(this);
+		}
 	}
 
 	/**
@@ -852,7 +844,7 @@ class Prefab {
 				oldParent._children = null;
 			}
 		}
-		@:bypassAccessor child.parent = newParent;
+		child.parent = newParent;
 		if (newParent != null) {
 			if (newParent._children == null)
 				newParent._children = [];

hrt/prefab/Reference.hx

@@ -593,8 +593,7 @@ class Reference extends Object3D {
 						break;
 					}
 					editor.removeInstance(selectedRef, false);
-					@:bypassAccessor clones[i].parent = parents[i];
-					@:bypassAccessor selectedRef.parent = null;
+					selectedRef.remove();
 					newSelection.push(clones[i]);
 				}
 				else {
@@ -607,8 +606,7 @@ class Reference extends Object3D {
 						break;
 					}
 					editor.removeInstance(clones[i], false);
-					@:bypassAccessor clones[i].parent = null;
-					@:bypassAccessor selectedRef.parent = parents[i];
+					clones[i].remove();
 					newSelection.push(selectedRef);
 				}
 				editor.queueRebuild(parents[i]);

hrt/prefab/fx/ShaderTarget.hx

@@ -11,7 +11,7 @@ class ShaderTargetObj extends h3d.scene.Object {
 			while ( i < obj.children.length ) {
 				var c = obj.children[i];
 				if ( (c.enabled && !c.editorOnly) && (Std.isOfType(c, Shader) || Std.isOfType(c, Material) || Std.isOfType(c, MaterialSelector)) ) {
-					c.parent = shadersRoot;
+					shadersRoot.addChild(c);
 					i--;
 				}
 				i++;