Add percentile aggregation types (p25-p99)#1
Open
fayvor wants to merge 2 commits into
Open
Conversation
Added p25, p50, p75, p90, p95 measure types that generate PERCENTILE_CONT SQL for multi-stage aggregations. Enables benchmarking use cases like "median reports per org". Changes: - CubeValidator.ts: Added types to validation lists - BaseQuery.js: Added SQL generation for percentiles Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Extends the percentile measure types to include p99 (99th percentile) for capturing extreme outliers in distributions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERCENTILE_CONTSQL function for multi-stage measuresChanges
CubeValidator.ts: Added percentile types to measure type validatorsBaseQuery.js: Added SQL generation forPERCENTILE_CONT(x) WITHIN GROUP (ORDER BY ...)Test plan
add_group_byfor multi-stage aggregations🤖 Generated with Claude Code