-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
A regression introduced by @Keavon in #3662.
Previously you could connect a number to the text (create text with text tool, open node graph, select text node, click dot next to text input)

Now it doesn't work:
This input type is incompatible:
• Input 2:
…found: f64 called with Context
…expected: string called with Context
The name of the String type is now for some reason changed:
Graphite/node-graph/libraries/core-types/src/types.rs
Lines 389 to 391 in 7af60e0
| if self == &concrete!(&str) || self == &concrete!(String) { | |
| return write!(f, "string"); | |
| } |
So no convert node is found to match it:
Graphite/node-graph/preprocessor/src/lib.rs
Lines 72 to 84 in 7af60e0
| let into_node_identifier = ProtoNodeIdentifier::with_owned_string(format!("graphene_core::ops::IntoNode<{}>", input_ty.clone())); | |
| let convert_node_identifier = ProtoNodeIdentifier::with_owned_string(format!("graphene_core::ops::ConvertNode<{}>", input_ty.clone())); | |
| let proto_node = if into_node_registry.keys().any(|ident: &ProtoNodeIdentifier| ident.as_str() == into_node_identifier.as_str()) { | |
| generated_nodes += 1; | |
| into_node_identifier | |
| } else if into_node_registry.keys().any(|ident| ident.as_str() == convert_node_identifier.as_str()) { | |
| generated_nodes += 1; | |
| inputs.push(NodeInput::value(TaggedValue::None, false)); | |
| convert_node_identifier | |
| } else { | |
| identity_node.clone() | |
| }; |
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Completed This Milestone