required more constructors, equality check

Author: Gillgamesh

include/sketch/sketch_columns.h

@@ -38,6 +38,14 @@ class FixedSizeSketchColumn {
   void reset_sample_state() {
     //no-op
   };
+  bool operator==(const FixedSizeSketchColumn &other) const {
+    for (size_t i = 0; i < capacity; ++i) {
+      if (buckets[i] != other.buckets[i]) {
+        return false;
+      }
+    }
+    return true;
+  }
   friend std::ostream& operator<<(std::ostream &os, const FixedSizeSketchColumn &sketch) {
     os << "FixedSizeSketchColumn: " << std::endl;
     os << "Capacity: " << (int)sketch.capacity << std::endl;
@@ -140,6 +148,14 @@ class ResizeableSketchColumn {
     //no-op
   };
   void serialize(std::ostream &binary_out) const;
+  bool operator==(const ResizeableSketchColumn &other) const {
+    for (size_t i = 0; i < capacity; ++i) {
+      if (aligned_buckets[i] != other.aligned_buckets[i]) {
+        return false;
+      }
+    }
+    return true;
+  }
 private:
   void reallocate(uint8_t new_capacity);
 };

include/sketch/sketch_concept.h

@@ -1,5 +1,6 @@
 #pragma once
 #include <format>
+#include <concepts>
 #include "bucket.h"
 
 enum SampleResult {
@@ -23,13 +24,15 @@ struct ExhaustiveSketchSample {
 };
 
 template <typename T, typename V>
-concept ConnectivitySketchConcept = requires(T t) {
+concept ConnectivitySketchConcept = requires(T t, T other) {
   { t.sample() } -> std::same_as<SketchSample<V>>;
   { t.clear()} -> std::same_as<void>;
   { t.update(std::declval<V>()) };
   { t.merge(std::declval<T>()) };
   { t.range_merge(std::declval<T>(), std::declval<size_t>(), std::declval<size_t>()) };
   { t.serialize(std::declval<std::ostream&>()) };
+  { t == other } -> std::same_as<bool>;
+  requires std::constructible_from<T, const T&>;
 };
 
 template <typename T, typename V>
@@ -43,6 +46,11 @@ concept SketchColumnConcept = requires(T t, T other) {
 
   { t.serialize(std::declval<std::ostream&>()) };
   { t.reset_sample_state()} -> std::same_as<void>;
+  { t == other } -> std::same_as<bool>;
+  // copy constructor required
+  requires std::constructible_from<T, const T&>;
+  // constructor with capacity hint, column index for seeding
+  requires std::constructible_from<T, uint8_t, uint16_t>;
 };
 
 /*