From ec63b893771b5de8f19d64f9b0e7ffabee51da53 Mon Sep 17 00:00:00 2001 From: Gordon Beeming Date: Wed, 25 Mar 2026 10:28:36 +1000 Subject: [PATCH] fix: Use single quotes for build_args to prevent shell variable expansion The matrix build_args values contain $PLACEHOLDER tokens (e.g. $COPILOT_VERSION) that are meant to be replaced by bash string substitution in the "Prepare build args" step. However, using double quotes on the ARGS assignment caused bash to expand these as shell variables (which are unset, so they become empty strings) before the substitution step could replace them. This resulted in all Docker build args being empty, with images falling back to Dockerfile ARG defaults. Switching to single quotes preserves the $ placeholders so the substitution step works correctly. Co-authored-by: Claude Opus 4.6 (1M context) Co-authored-by: GitButler --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c133852..39d0593 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -435,7 +435,7 @@ jobs: - name: Prepare build args id: args run: | - ARGS="${{ matrix.build_args }}" + ARGS='${{ matrix.build_args }}' ARGS="${ARGS//\$COPILOT_VERSION/${{ needs.prepare-versions.outputs.copilot_version }}}" ARGS="${ARGS//\$PLAYWRIGHT_VERSION/${{ needs.prepare-versions.outputs.playwright_version }}}" ARGS="${ARGS//\$DOTNET_8_VERSION/${{ needs.prepare-versions.outputs.dotnet_8_version }}}"