Skip to content

Commit eb4eed0

Browse files
GordonBeemingclaudegitbutler-client
authored
fix: Use single quotes for build_args to prevent shell variable expansion (#86)
The matrix build_args values contain $PLACEHOLDER tokens (e.g. $COPILOT_VERSION) that are meant to be replaced by bash string substitution in the "Prepare build args" step. However, using double quotes on the ARGS assignment caused bash to expand these as shell variables (which are unset, so they become empty strings) before the substitution step could replace them. This resulted in all Docker build args being empty, with images falling back to Dockerfile ARG defaults. Switching to single quotes preserves the $ placeholders so the substitution step works correctly. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: GitButler <gitbutler@gitbutler.com>
1 parent cddf42b commit eb4eed0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ jobs:
435435
- name: Prepare build args
436436
id: args
437437
run: |
438-
ARGS="${{ matrix.build_args }}"
438+
ARGS='${{ matrix.build_args }}'
439439
ARGS="${ARGS//\$COPILOT_VERSION/${{ needs.prepare-versions.outputs.copilot_version }}}"
440440
ARGS="${ARGS//\$PLAYWRIGHT_VERSION/${{ needs.prepare-versions.outputs.playwright_version }}}"
441441
ARGS="${ARGS//\$DOTNET_8_VERSION/${{ needs.prepare-versions.outputs.dotnet_8_version }}}"

0 commit comments

Comments
 (0)