Resolving gemini comments

Author: dhavalbhensdadiya-crest

secretmanager/README.md

@@ -19,8 +19,8 @@ This simple command-line application demonstrates how to invoke
     Set the following environment variables:
 
     - GOOGLE_CLOUD_PUBSUB_TOPIC - Full name of topic (projects/{project}/topics/{topic}).
-    -  GOOGLE_CLOUD_KMS_KEY - Full name of global KMS key (projects/{project}/locations/global/keyRings/{keyring}/cryptoKeys/{key}).
-    -  GOOGLE_CLOUD_REGIONAL_KMS_KEY - Full name of regional KMS key (projects/{project}/locations/{location}/keyRings/{keyring}/cryptoKeys/{key}).
+    - GOOGLE_CLOUD_KMS_KEY - Full name of global KMS key (projects/{project}/locations/global/keyRings/{keyring}/cryptoKeys/{key}).
+    - GOOGLE_CLOUD_REGIONAL_KMS_KEY - Full name of regional KMS key (projects/{project}/locations/{location}/keyRings/{keyring}/cryptoKeys/{key}).
 
 1.  **Download The Credentials** - Click "Go to credentials" after enabling the
     APIs. Click "New Credentials" and select "Service Account Key". Create a new

secretmanager/src/create_regional_secret_with_cmek.php

@@ -37,7 +37,7 @@
  * @param string $projectId Google Cloud project id (e.g. 'my-project-id')
  * @param string $locationId Secret location (e.g. 'us-central1')
  * @param string $secretId Id for the new secret (e.g. 'my-secret-id')
- * @param string $kmsKeyName Full KMS key resource name (e.g. 'projects/my-project/locations/global/keyRings/my-kr/cryptoKeys/my-key')
+ * @param string $kmsKeyName Full KMS key resource name (e.g. 'projects/my-project/locations/us-central1/keyRings/my-kr/cryptoKeys/my-key')
  */
 function create_regional_secret_with_cmek(string $projectId, string $locationId, string $secretId, string $kmsKeyName): void
 {

secretmanager/test/regionalsecretmanagerTest.php

@@ -825,8 +825,8 @@ public function testCreateSecretWithCmek()
     {
         $kmsKey = getenv('GOOGLE_CLOUD_REGIONAL_KMS_KEY');
         if ($kmsKey === false || $kmsKey === '') {
-            $this->markTestSkipped('GOOGLE_CLOUD_KMS_KEY not set');
-            printf('Skipping testCreateSecretWithTopic dependent on GOOGLE_CLOUD_KMS_KEY%s', PHP_EOL);
+            $this->markTestSkipped('GOOGLE_CLOUD_REGIONAL_KMS_KEY not set');
+            printf('Skipping testCreateSecretWithTopic dependent on GOOGLE_CLOUD_REGIONAL_KMS_KEY%s', PHP_EOL);
         }
 
         $name = self::$client->parseName(self::$testSecretWithCMEKToCreateName);