feat: Add GKE CustomNodeInit support#17743
Conversation
Adds support for GKE custom node initialization scripts configuration in LinuxNodeConfig. This includes: - Adding custom_node_init schema to linux_node_config block. - Implementing expander and flattener helpers for CustomNodeInit and InitScript. - Adding TestAccContainerNodePool_withCustomNodeInit integration test template. This supports both GCS URI (with specific generation) and GCP Secret Manager secret URI configurations. TAG=agy CONV=753c21e2-16d4-4cc3-9aef-bf8b374d142c
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 46d0291: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_config {
linux_node_config {
custom_node_init {
init_script {
gcp_secret_manager_secret_uri = # value needed
gcs_generation = # value needed
gcs_uri = # value needed
}
}
}
}
node_pool {
node_config {
linux_node_config {
custom_node_init {
init_script {
gcp_secret_manager_secret_uri = # value needed
gcs_generation = # value needed
gcs_uri = # value needed
}
}
}
}
}
}
Resource: resource "google_container_node_pool" "primary" {
node_config {
linux_node_config {
custom_node_init {
init_script {
gcp_secret_manager_secret_uri = # value needed
gcs_generation = # value needed
}
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @zicongmei, @trodge VCR tests complete for 46d0291! |
Adds support for GKE custom node initialization scripts configuration in LinuxNodeConfig. This includes:
This supports both GCS URI (with specific generation) and GCP Secret Manager secret URI configurations.
TAG=agy
CONV=753c21e2-16d4-4cc3-9aef-bf8b374d142c
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.