Migrate flattenGuestAccelerators, resourceInstanceTags functions in compute_instance_helpers.go.tmpl to use direct HTTP rather than a client library service/compute-instances

[jcromanu]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

migrated compute_instance_helpers interfaces

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8474e13:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	5 files changed, 51 insertions(+), 16 deletions(-)
google-beta provider	View Diff	5 files changed, 51 insertions(+), 16 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 26 insertions(+), 20 deletions(-)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@jcromanu, @trodge VCR tests complete for 8474e13!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e39a45c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	6 files changed, 57 insertions(+), 19 deletions(-)
google-beta provider	View Diff	6 files changed, 57 insertions(+), 19 deletions(-)
terraform-google-conversion	View Diff	2 files changed, 26 insertions(+), 20 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6468	5735	659	74

Affected Service Packages

• All service packages are affected

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 74 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
• TestAccCloudRunService_cloudRunServiceGpuExample
• TestAccComputeInstanceFromRegionTemplate_basic
• TestAccComputeInstanceFromTemplate_diskResourcePolicies
• TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures
• TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain
• TestAccComputeRegionInstanceTemplate_GuestOsFeatures
• TestAccComputeRegionInstanceTemplate_IP
• TestAccComputeRegionInstanceTemplate_IPv6
• TestAccComputeRegionInstanceTemplate_aliasIpv6Range
• TestAccComputeRegionInstanceTemplate_basic
• TestAccComputeRegionInstanceTemplate_diskEncryptionKey
• TestAccComputeRegionInstanceTemplate_diskIops
• TestAccComputeRegionInstanceTemplate_diskIopsThroughput
• TestAccComputeRegionInstanceTemplate_diskResourcePolicies
• TestAccComputeRegionInstanceTemplate_dynamicNic
• TestAccComputeRegionInstanceTemplate_enableDisplay
• TestAccComputeRegionInstanceTemplate_enableUefiNetworking
• TestAccComputeRegionInstanceTemplate_gracefulShutdown
• TestAccComputeRegionInstanceTemplate_guestAccelerator
• TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip
• TestAccComputeRegionInstanceTemplate_imageShorthand
• TestAccComputeRegionInstanceTemplate_instanceResourcePolicies
• TestAccComputeRegionInstanceTemplate_instanceResourcePoliciesSpread
• TestAccComputeRegionInstanceTemplate_keyRevocationActionType
• TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
• TestAccComputeRegionInstanceTemplate_maintenance_interval
• TestAccComputeRegionInstanceTemplate_managedEnvoy
• TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
• TestAccComputeRegionInstanceTemplate_metadataGceContainerDeclaration
• TestAccComputeRegionInstanceTemplate_metadata_startup_script
• TestAccComputeRegionInstanceTemplate_minCpuPlatform
• TestAccComputeRegionInstanceTemplate_networkAttachment
• TestAccComputeRegionInstanceTemplate_networkIP
• TestAccComputeRegionInstanceTemplate_networkIPAddress
• TestAccComputeRegionInstanceTemplate_networkTier
• TestAccComputeRegionInstanceTemplate_nictype_update
• TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
• TestAccComputeRegionInstanceTemplate_preemptible
• TestAccComputeRegionInstanceTemplate_primaryAliasIpRange
• TestAccComputeRegionInstanceTemplate_queueCount
• TestAccComputeRegionInstanceTemplate_regionDisks
• TestAccComputeRegionInstanceTemplate_reservationAffinities
• TestAccComputeRegionInstanceTemplate_resourceManagerTags
• TestAccComputeRegionInstanceTemplate_schedulingPreemptionNoticeDuration
• TestAccComputeRegionInstanceTemplate_schedulingSkipGuestOSShutdown
• TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange
• TestAccComputeRegionInstanceTemplate_shieldedVmConfig1
• TestAccComputeRegionInstanceTemplate_shieldedVmConfig2
• TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities
• TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey
• TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey
• TestAccComputeRegionInstanceTemplate_spot
• TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
• TestAccComputeRegionInstanceTemplate_storagePool
• TestAccComputeRegionInstanceTemplate_subnet_auto
• TestAccComputeRegionInstanceTemplate_subnet_custom
• TestAccComputeRegionInstanceTemplate_with18TbScratchDisk
• TestAccComputeRegionInstanceTemplate_withScratchDisk
• TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
• TestAccComputeRegionalInstanceTemplate_partnerMetadata
• TestAccComputeResizeRequest_computeMigResizeRequestExample
• TestAccContainerCluster_withLoggingConfig
• TestAccContainerNodePool_withHostMaintenancePolicy
• TestAccDataformConfig_update
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccProjectIamMemberRemove_memberInMultipleBindings
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample
• TestAccRegionInstanceTemplateDatasource_filter
• TestAccRegionInstanceTemplateDatasource_filter_mostRecent
• TestAccRegionInstanceTemplateDatasource_name

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeInstanceFromRegionTemplate_basic
✅ Log	✅	TestAccComputeInstanceFromTemplate_diskResourcePolicies
✅ Log	✅	TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures
✅ Log	✅	TestAccComputeRegionInstanceTemplate_ConfidentialInstanceConfigMain
✅ Log	✅	TestAccComputeRegionInstanceTemplate_GuestOsFeatures
✅ Log	✅	TestAccComputeRegionInstanceTemplate_IP
✅ Log	✅	TestAccComputeRegionInstanceTemplate_IPv6
✅ Log	✅	TestAccComputeRegionInstanceTemplate_aliasIpv6Range
✅ Log	✅	TestAccComputeRegionInstanceTemplate_basic
✅ Log	✅	TestAccComputeRegionInstanceTemplate_diskEncryptionKey
✅ Log	✅	TestAccComputeRegionInstanceTemplate_diskIops
✅ Log	✅	TestAccComputeRegionInstanceTemplate_diskIopsThroughput
✅ Log	✅	TestAccComputeRegionInstanceTemplate_diskResourcePolicies
✅ Log	✅	TestAccComputeRegionInstanceTemplate_dynamicNic
✅ Log	✅	TestAccComputeRegionInstanceTemplate_enableDisplay
✅ Log	✅	TestAccComputeRegionInstanceTemplate_enableUefiNetworking
✅ Log	✅	TestAccComputeRegionInstanceTemplate_gracefulShutdown
✅ Log	✅	TestAccComputeRegionInstanceTemplate_guestAccelerator
✅ Log	✅	TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip
✅ Log	✅	TestAccComputeRegionInstanceTemplate_imageShorthand
✅ Log	✅	TestAccComputeRegionInstanceTemplate_instanceResourcePoliciesSpread
✅ Log	✅	TestAccComputeRegionInstanceTemplate_keyRevocationActionType
✅ Log	✅	TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
✅ Log	✅	TestAccComputeRegionInstanceTemplate_maintenance_interval
✅ Log	✅	TestAccComputeRegionInstanceTemplate_managedEnvoy
✅ Log	✅	TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
✅ Log	✅	TestAccComputeRegionInstanceTemplate_metadataGceContainerDeclaration
✅ Log	✅	TestAccComputeRegionInstanceTemplate_metadata_startup_script
✅ Log	✅	TestAccComputeRegionInstanceTemplate_minCpuPlatform
✅ Log	✅	TestAccComputeRegionInstanceTemplate_networkAttachment
✅ Log	✅	TestAccComputeRegionInstanceTemplate_networkIP
✅ Log	✅	TestAccComputeRegionInstanceTemplate_networkIPAddress
✅ Log	✅	TestAccComputeRegionInstanceTemplate_networkTier
✅ Log	✅	TestAccComputeRegionInstanceTemplate_nictype_update
✅ Log	✅	TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit
✅ Log	✅	TestAccComputeRegionInstanceTemplate_preemptible
✅ Log	✅	TestAccComputeRegionInstanceTemplate_primaryAliasIpRange
✅ Log	✅	TestAccComputeRegionInstanceTemplate_queueCount
✅ Log	✅	TestAccComputeRegionInstanceTemplate_regionDisks
✅ Log	✅	TestAccComputeRegionInstanceTemplate_reservationAffinities
✅ Log	✅	TestAccComputeRegionInstanceTemplate_resourceManagerTags
✅ Log	✅	TestAccComputeRegionInstanceTemplate_schedulingPreemptionNoticeDuration
✅ Log	✅	TestAccComputeRegionInstanceTemplate_schedulingSkipGuestOSShutdown
✅ Log	✅	TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange
✅ Log	✅	TestAccComputeRegionInstanceTemplate_shieldedVmConfig1
✅ Log	✅	TestAccComputeRegionInstanceTemplate_shieldedVmConfig2
✅ Log	✅	TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities
✅ Log	✅	TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey
✅ Log	✅	TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey
✅ Log	✅	TestAccComputeRegionInstanceTemplate_spot
✅ Log	✅	TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
✅ Log	✅	TestAccComputeRegionInstanceTemplate_storagePool
✅ Log	✅	TestAccComputeRegionInstanceTemplate_subnet_auto
✅ Log	✅	TestAccComputeRegionInstanceTemplate_subnet_custom
✅ Log	✅	TestAccComputeRegionInstanceTemplate_with18TbScratchDisk
✅ Log	✅	TestAccComputeRegionInstanceTemplate_withScratchDisk
✅ Log	✅	TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
✅ Log	✅	TestAccComputeRegionalInstanceTemplate_partnerMetadata
✅ Log	✅	TestAccComputeResizeRequest_computeMigResizeRequestExample
✅ Log	✅	TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log	✅	TestAccRegionInstanceTemplateDatasource_filter
✅ Log	✅	TestAccRegionInstanceTemplateDatasource_filter_mostRecent
✅ Log	✅	TestAccRegionInstanceTemplateDatasource_name
✅ Log	❌ Error · Log	TestAccDataformConfig_update
❌ Error · Log	-	TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log	-	TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log	-	TestAccComputeRegionInstanceTemplate_instanceResourcePolicies
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log	-	TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@jcromanu, @trodge VCR tests complete for e39a45c!