Skip to content

Migrate expandAdvancedMachineFeatures, flattenAdvancedMachineFeatures functions in compute_instance_helpers.go.tmpl to use direct HTTP rather than a client library#17723

Draft
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-region-instance-AdvancedMachine-migration
Draft

Migrate expandAdvancedMachineFeatures, flattenAdvancedMachineFeatures functions in compute_instance_helpers.go.tmpl to use direct HTTP rather than a client library#17723
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-region-instance-AdvancedMachine-migration

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Migrate `expandAdvancedMachineFeatures`, `flattenAdvancedMachineFeatures` functions

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 25, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3d42789:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 65 insertions(+), 32 deletions(-)
google-beta provider View Diff 4 files changed, 65 insertions(+), 32 deletions(-)
terraform-google-conversion View Diff 2 files changed, 42 insertions(+), 36 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1361 93 3
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures
  • TestAccComputeRegionInstanceTemplate_enableUefiNetworking
  • TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures
❌ Error · Log - TestAccComputeRegionInstanceTemplate_enableUefiNetworking
❌ Error · Log - TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 3d42789!

@nsamartsev nsamartsev force-pushed the resource-compute-region-instance-AdvancedMachine-migration branch from 3d42789 to 23f716a Compare May 25, 2026 15:03
@nsamartsev nsamartsev changed the title Migrate expandAdvancedMachineFeatures, flattenAdvancedMachineFeatures functions Migrate expandAdvancedMachineFeatures, flattenAdvancedMachineFeatures functions in compute_instance_helpers.go.tmpl to use direct HTTP rather than a client library May 25, 2026
@nsamartsev nsamartsev changed the title Migrate expandAdvancedMachineFeatures, flattenAdvancedMachineFeatures functions in compute_instance_helpers.go.tmpl to use direct HTTP rather than a client library Migrate expandAdvancedMachineFeatures, flattenAdvancedMachineFeatures functions in compute_instance_helpers.go.tmpl to use direct HTTP rather than a client library May 25, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 25, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 23f716a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 65 insertions(+), 32 deletions(-)
google-beta provider View Diff 4 files changed, 65 insertions(+), 32 deletions(-)
terraform-google-conversion View Diff 4 files changed, 85 insertions(+), 61 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1362 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeRegionInstanceTemplate_enableUefiNetworking
  • TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeRegionInstanceTemplate_enableUefiNetworking
❌ Error · Log - TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 23f716a!

@nsamartsev nsamartsev force-pushed the resource-compute-region-instance-AdvancedMachine-migration branch from 23f716a to db9e56a Compare May 25, 2026 15:19
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 25, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit db9e56a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 65 insertions(+), 32 deletions(-)
google-beta provider View Diff 4 files changed, 65 insertions(+), 32 deletions(-)
terraform-google-conversion View Diff 5 files changed, 95 insertions(+), 62 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1362 93 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeRegionInstanceTemplate_enableUefiNetworking
  • TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeRegionInstanceTemplate_enableUefiNetworking
❌ Error · Log - TestAccComputeRegionInstanceTemplate_performanceMonitoringUnit

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for db9e56a!

@nsamartsev nsamartsev force-pushed the resource-compute-region-instance-AdvancedMachine-migration branch from db9e56a to 3f432eb Compare May 25, 2026 16:11
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 25, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3f432eb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 77 insertions(+), 32 deletions(-)
google-beta provider View Diff 4 files changed, 77 insertions(+), 32 deletions(-)
terraform-google-conversion View Diff 5 files changed, 119 insertions(+), 62 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1363 93 1
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRegionInstanceTemplate_AdvancedMachineFeatures

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for 3f432eb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants