Skip to content

Migrate compute instance flatten functions from Apiary structs to maps#17716

Draft
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-region-instance-template-migration-2
Draft

Migrate compute instance flatten functions from Apiary structs to maps#17716
nsamartsev wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
nsamartsev:resource-compute-region-instance-template-migration-2

Conversation

@nsamartsev
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Migrate compute instance flatten functions from Apiary structs to maps

@nsamartsev nsamartsev force-pushed the resource-compute-region-instance-template-migration-2 branch from 1cbb976 to 4276521 Compare May 24, 2026 21:54
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 24, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1cbb976:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 575 insertions(+), 262 deletions(-)
google-beta provider View Diff 6 files changed, 656 insertions(+), 298 deletions(-)
terraform-google-conversion View Diff 4 files changed, 651 insertions(+), 246 deletions(-)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@nsamartsev VCR tests complete for 1cbb976!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 24, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4276521:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 575 insertions(+), 262 deletions(-)
google-beta provider View Diff 6 files changed, 656 insertions(+), 298 deletions(-)
terraform-google-conversion View Diff 6 files changed, 673 insertions(+), 256 deletions(-)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@nsamartsev VCR tests complete for 4276521!

@nsamartsev nsamartsev force-pushed the resource-compute-region-instance-template-migration-2 branch from 4276521 to b4bb7ef Compare May 24, 2026 22:07
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 24, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b4bb7ef:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 575 insertions(+), 262 deletions(-)
google-beta provider View Diff 6 files changed, 656 insertions(+), 298 deletions(-)
terraform-google-conversion View Diff 6 files changed, 689 insertions(+), 256 deletions(-)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@nsamartsev VCR tests complete for b4bb7ef!

@nsamartsev nsamartsev force-pushed the resource-compute-region-instance-template-migration-2 branch from b4bb7ef to f69223d Compare May 24, 2026 23:08
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 24, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f69223d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 599 insertions(+), 279 deletions(-)
google-beta provider View Diff 6 files changed, 680 insertions(+), 315 deletions(-)
terraform-google-conversion View Diff 6 files changed, 689 insertions(+), 256 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1457 1283 93 81
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 81 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImage_maxRunDuration
  • TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
  • TestAccComputeInstanceFromRegionTemplate_basic
  • TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeInstanceFromTemplate_basic
  • TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeInstanceFromTemplate_overrideAttachedDisk
  • TestAccComputeInstanceFromTemplate_overrideBootDisk
  • TestAccComputeInstanceFromTemplate_overrideScratchDisk
  • TestAccComputeInstanceFromTemplate_partnerMetadata
  • TestAccComputeInstanceFromTemplate_schedulingPreemptionNoticeDuration
  • TestAccComputeInstanceFromTemplate_self_link_unique
  • TestAccComputeInstanceFromTemplate_useDiskSelfLink
  • TestAccComputeInstanceTemplate_GuestOsFeatures
  • TestAccComputeInstanceTemplate_NetworkAttachment
  • TestAccComputeInstanceTemplate_diskIops
  • TestAccComputeInstanceTemplate_diskIopsThroughput
  • TestAccComputeInstanceTemplate_disks
  • TestAccComputeInstanceTemplate_gracefulShutdown
  • TestAccComputeInstanceTemplate_guestAccelerator
  • TestAccComputeInstanceTemplate_guestAcceleratorSkip
  • TestAccComputeInstanceTemplate_keyRevocationActionType
  • TestAccComputeInstanceTemplate_localSsdRecoveryTimeout
  • TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeInstanceTemplate_metadata_startup_script
  • TestAccComputeInstanceTemplate_minCpuPlatform
  • TestAccComputeInstanceTemplate_primaryAliasIpRange
  • TestAccComputeInstanceTemplate_regionDisks
  • TestAccComputeInstanceTemplate_resourceManagerTags
  • TestAccComputeInstanceTemplate_schedulingPreemptionNoticeDuration
  • TestAccComputeInstanceTemplate_secondaryAliasIpRange
  • TestAccComputeInstanceTemplate_spot_maxRunDuration
  • TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
  • TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
  • TestAccComputeInstanceTemplate_subnet_auto
  • TestAccComputeInstanceTemplate_subnet_custom
  • TestAccComputeInstanceTemplate_with18TbScratchDisk
  • TestAccComputeInstance_GracefulShutdownWithResetUpdate
  • TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
  • TestAccComputeInstance_localSsdRecoveryTimeout
  • TestAccComputeInstance_localSsdRecoveryTimeout_update
  • TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
  • TestAccComputeInstance_maxRunDuration_update
  • TestAccComputeInstance_preemptionNoticeDuration
  • TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
  • TestAccComputeInstance_spotVM_maxRunDuration_update
  • TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
  • TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
  • TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
  • TestAccComputeRegionInstanceTemplate_GuestOsFeatures
  • TestAccComputeRegionInstanceTemplate_diskEncryptionKey
  • TestAccComputeRegionInstanceTemplate_diskIops
  • TestAccComputeRegionInstanceTemplate_diskIopsThroughput
  • TestAccComputeRegionInstanceTemplate_gracefulShutdown
  • TestAccComputeRegionInstanceTemplate_guestAccelerator
  • TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip
  • TestAccComputeRegionInstanceTemplate_keyRevocationActionType
  • TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
  • TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeRegionInstanceTemplate_metadata_startup_script
  • TestAccComputeRegionInstanceTemplate_minCpuPlatform
  • TestAccComputeRegionInstanceTemplate_networkAttachment
  • TestAccComputeRegionInstanceTemplate_primaryAliasIpRange
  • TestAccComputeRegionInstanceTemplate_regionDisks
  • TestAccComputeRegionInstanceTemplate_resourceManagerTags
  • TestAccComputeRegionInstanceTemplate_schedulingPreemptionNoticeDuration
  • TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange
  • TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
  • TestAccComputeRegionInstanceTemplate_subnet_auto
  • TestAccComputeRegionInstanceTemplate_subnet_custom
  • TestAccComputeRegionInstanceTemplate_with18TbScratchDisk
  • TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
  • TestAccComputeResizeRequest_computeMigResizeRequestExample
  • TestAccInstanceGroupManager_targetSizePolicy
  • TestAccRegionInstanceGroupManager_resourcePoliciesWorkloadPolicyUpdate
  • TestAccRegionInstanceGroupManager_targetSizePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeInstanceFromMachineImage_maxRunDuration
❌ Error · Log - TestAccComputeInstanceFromMachineImage_preemptionNoticeDuration
❌ Error · Log - TestAccComputeInstanceFromRegionTemplate_basic
❌ Error · Log - TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeInstanceFromTemplate_basic
❌ Error · Log - TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
❌ Error · Log - TestAccComputeInstanceFromTemplate_overrideAttachedDisk
❌ Error · Log - TestAccComputeInstanceFromTemplate_overrideBootDisk
❌ Error · Log - TestAccComputeInstanceFromTemplate_overrideScratchDisk
❌ Error · Log - TestAccComputeInstanceFromTemplate_partnerMetadata
❌ Error · Log - TestAccComputeInstanceFromTemplate_schedulingPreemptionNoticeDuration
❌ Error · Log - TestAccComputeInstanceFromTemplate_self_link_unique
❌ Error · Log - TestAccComputeInstanceFromTemplate_useDiskSelfLink
❌ Error · Log - TestAccComputeInstanceTemplate_GuestOsFeatures
❌ Error · Log - TestAccComputeInstanceTemplate_NetworkAttachment
❌ Error · Log - TestAccComputeInstanceTemplate_diskIops
❌ Error · Log - TestAccComputeInstanceTemplate_diskIopsThroughput
❌ Error · Log - TestAccComputeInstanceTemplate_disks
❌ Error · Log - TestAccComputeInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeInstanceTemplate_guestAccelerator
❌ Error · Log - TestAccComputeInstanceTemplate_guestAcceleratorSkip
❌ Error · Log - TestAccComputeInstanceTemplate_keyRevocationActionType
❌ Error · Log - TestAccComputeInstanceTemplate_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction
❌ Error · Log - TestAccComputeInstanceTemplate_metadata_startup_script
❌ Error · Log - TestAccComputeInstanceTemplate_minCpuPlatform
❌ Error · Log - TestAccComputeInstanceTemplate_primaryAliasIpRange
❌ Error · Log - TestAccComputeInstanceTemplate_regionDisks
❌ Error · Log - TestAccComputeInstanceTemplate_resourceManagerTags
❌ Error · Log - TestAccComputeInstanceTemplate_schedulingPreemptionNoticeDuration
❌ Error · Log - TestAccComputeInstanceTemplate_secondaryAliasIpRange
❌ Error · Log - TestAccComputeInstanceTemplate_spot_maxRunDuration
❌ Error · Log - TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction
❌ Error · Log - TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction
❌ Error · Log - TestAccComputeInstanceTemplate_subnet_auto
❌ Error · Log - TestAccComputeInstanceTemplate_subnet_custom
❌ Error · Log - TestAccComputeInstanceTemplate_with18TbScratchDisk
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithResetUpdate
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
❌ Error · Log - TestAccComputeInstance_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeInstance_localSsdRecoveryTimeout_update
❌ Error · Log - TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
❌ Error · Log - TestAccComputeInstance_maxRunDuration_update
❌ Error · Log - TestAccComputeInstance_preemptionNoticeDuration
❌ Error · Log - TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction
❌ Error · Log - TestAccComputeInstance_spotVM_maxRunDuration_update
❌ Error · Log - TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction
❌ Error · Log - TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction
❌ Error · Log - TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
❌ Error · Log - TestAccComputeRegionInstanceTemplate_GuestOsFeatures
❌ Error · Log - TestAccComputeRegionInstanceTemplate_diskEncryptionKey
❌ Error · Log - TestAccComputeRegionInstanceTemplate_diskIops
❌ Error · Log - TestAccComputeRegionInstanceTemplate_diskIopsThroughput
❌ Error · Log - TestAccComputeRegionInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeRegionInstanceTemplate_guestAccelerator
❌ Error · Log - TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip
❌ Error · Log - TestAccComputeRegionInstanceTemplate_keyRevocationActionType
❌ Error · Log - TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout
❌ Error · Log - TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction
❌ Error · Log - TestAccComputeRegionInstanceTemplate_metadata_startup_script
❌ Error · Log - TestAccComputeRegionInstanceTemplate_minCpuPlatform
❌ Error · Log - TestAccComputeRegionInstanceTemplate_networkAttachment
❌ Error · Log - TestAccComputeRegionInstanceTemplate_primaryAliasIpRange
❌ Error · Log - TestAccComputeRegionInstanceTemplate_regionDisks
❌ Error · Log - TestAccComputeRegionInstanceTemplate_resourceManagerTags
❌ Error · Log - TestAccComputeRegionInstanceTemplate_schedulingPreemptionNoticeDuration
❌ Error · Log - TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange
❌ Error · Log - TestAccComputeRegionInstanceTemplate_spot_maxRunDuration
❌ Error · Log - TestAccComputeRegionInstanceTemplate_subnet_auto
❌ Error · Log - TestAccComputeRegionInstanceTemplate_subnet_custom
❌ Error · Log - TestAccComputeRegionInstanceTemplate_with18TbScratchDisk
❌ Error · Log - TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
❌ Error · Log - TestAccComputeResizeRequest_computeMigResizeRequestExample
❌ Error · Log - TestAccInstanceGroupManager_targetSizePolicy
❌ Error · Log - TestAccRegionInstanceGroupManager_resourcePoliciesWorkloadPolicyUpdate
❌ Error · Log - TestAccRegionInstanceGroupManager_targetSizePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@nsamartsev VCR tests complete for f69223d!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants