From 6e0c72c61f2f6a538ca029ccfe6492bea9d88bee Mon Sep 17 00:00:00 2001 From: GoodNotesCI Date: Thu, 16 Jul 2026 16:08:58 +0800 Subject: [PATCH] Bump deployment target to iOS/macCatalyst 18.6 GoodNotes only supports iOS 18.6+. Apple validates that the MinimumOSVersion in the framework Info.plist matches what the app declares. The deploy target flows from --apple_deploy_target through cmake/Info.plist.in (@CMAKE_OSX_DEPLOYMENT_TARGET@) into each framework slice's Info.plist, and from there into the xcframework root Info.plist via xcodebuild -create-xcframework. Co-Authored-By: Claude Sonnet 4.6 (1M context) --- .../github/apple/goodnotes_maccatalyst_build_settings.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/ci_build/github/apple/goodnotes_maccatalyst_build_settings.json b/tools/ci_build/github/apple/goodnotes_maccatalyst_build_settings.json index 8cb539ef07c6c..1d5d8a41254e3 100644 --- a/tools/ci_build/github/apple/goodnotes_maccatalyst_build_settings.json +++ b/tools/ci_build/github/apple/goodnotes_maccatalyst_build_settings.json @@ -26,17 +26,17 @@ "--ios", "--use_xcode", "--use_xnnpack", - "--apple_deploy_target=15.1" + "--apple_deploy_target=18.6" ], "iphonesimulator": [ "--ios", "--use_xcode", "--use_xnnpack", - "--apple_deploy_target=15.1" + "--apple_deploy_target=18.6" ], "macabi": [ "--macos=Catalyst", - "--apple_deploy_target=14.0", + "--apple_deploy_target=18.6", "--cmake_extra_defines=FETCHCONTENT_TRY_FIND_PACKAGE_MODE=NEVER" ] }