Use SearchComment instead of dedicated iteration

Author: GlancingMind

bug/op_edit_comment.go

@@ -71,15 +71,10 @@ func (op *EditCommentOperation) Apply(snapshot *Snapshot) {
 	snapshot.addActor(op.Author_)
 
 	// Updating the corresponding comment
-
-	//TODO use snapshot.SearchComment instead of iteration
-	//TODO put *editComment* in snapshot or add *edit* to Comment interface?
-	for i := range snapshot.Comments() {
-		if snapshot.Comments()[i].Id() == commentId {
-			snapshot.Comments()[i].Message = op.Message
-			snapshot.Comments()[i].Files = op.Files
-			break
-		}
+	editedComment, err := snapshot.SearchComment(commentId)
+	if err == nil {
+		editedComment.Message = op.Message
+		editedComment.Files = op.Files
 	}
 }
 

bug/snapshot.go

@@ -102,9 +102,11 @@ func (snap *Snapshot) SearchTimelineItem(id entity.Id) (TimelineItem, error) {
 
 // SearchComment will search for a comment matching the given hash
 func (snap *Snapshot) SearchComment(id entity.Id) (*Comment, error) {
-	for _, c := range snap.comments {
+	for i, c := range snap.comments {
 		if c.id == id {
-			return &c, nil
+			// NOTE don't return c or &c! Otherwise callers cannot change the
+			// returned comment. As c is a copy the found comment!
+			return &snap.comments[i], nil
 		}
 	}